Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <83aa53cb-e444-9397-96d2-eaeb92db6492@canonical.com>
Date:   Tue, 22 Feb 2022 13:38:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] ASoC: samsung: i2s: check the return value of kstrdup()
Content-Language: en-US
To:     xkernel.wang@foxmail.com, tiwai@suse.com, perex@perex.cz
Cc:     s.nawrocki@samsung.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
References: <tencent_5F9F4223DC44A9ECBF02649AF934F786E305@qq.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
In-Reply-To: <tencent_5F9F4223DC44A9ECBF02649AF934F786E305@qq.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22/02/2022 12:53, xkernel.wang@foxmail.com wrote:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
> 
> kstrdup() is a memory allocation function which can return NULL when
> some internal memory errors happen. It is better to check the return
> value of it to catch the error in time.
> 
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> ---
>  sound/soc/samsung/i2s.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof