Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <656c6e1e-4947-4af6-bf63-dea60e9d0855@ti.com>
Date:   Tue, 22 Feb 2022 20:34:20 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-*: Drop address and size cells
 from flash nodes
Content-Language: en-US
To:     Pratyush Yadav <p.yadav@ti.com>, Nishanth Menon <nm@ti.com>
CC:     Vignesh Raghavendra <vigneshr@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220217181025.1815118-1-p.yadav@ti.com>
 <20220217181025.1815118-2-p.yadav@ti.com>
From:   Apurva Nandan <a-nandan@ti.com>
In-Reply-To: <20220217181025.1815118-2-p.yadav@ti.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 17/02/22 23:40, Pratyush Yadav wrote:
> Specifying partitions directly under the flash nodes is deprecated. A
> partitions node should used instead. The address and size cells are not
> needed. Remove them.
>
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>

Reviewed-by: Apurva Nandan<a-nandan@ti.com>

> ---
>
> Only compile-tested.
>
>   arch/arm64/boot/dts/ti/k3-am642-evm.dts               | 2 --
>   arch/arm64/boot/dts/ti/k3-am642-sk.dts                | 2 --
>   arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi           | 2 --
>   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 2 --
>   arch/arm64/boot/dts/ti/k3-j721e-sk.dts                | 2 --
>   arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi           | 2 --
>   6 files changed, 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> index edf80e277267..8e7893e58b03 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> @@ -509,8 +509,6 @@ flash@0 {
>   		cdns,tchsh-ns = <60>;
>   		cdns,tslch-ns = <60>;
>   		cdns,read-delay = <4>;
> -		#address-cells = <1>;
> -		#size-cells = <1>;
>   	};
>   };
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> index 30b956276060..1d7db8bf3a5c 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> @@ -380,8 +380,6 @@ flash@0 {
>   		cdns,tchsh-ns = <60>;
>   		cdns,tslch-ns = <60>;
>   		cdns,read-delay = <4>;
> -		#address-cells = <1>;
> -		#size-cells = <1>;
>   	};
>   };
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
> index 7d819f0db8df..2d615c3e9fa1 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
> @@ -267,7 +267,5 @@ flash@0 {
>   		cdns,tchsh-ns = <60>;
>   		cdns,tslch-ns = <60>;
>   		cdns,read-delay = <4>;
> -		#address-cells = <1>;
> -		#size-cells = <1>;
>   	};
>   };
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> index 2ecc4541f6d8..f5ca8e26ed99 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> @@ -493,8 +493,6 @@ flash@0 {
>   		cdns,tchsh-ns = <60>;
>   		cdns,tslch-ns = <60>;
>   		cdns,read-delay = <2>;
> -		#address-cells = <1>;
> -		#size-cells = <1>;
>   	};
>   };
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> index b726310d867c..f25d85169e0d 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> @@ -475,8 +475,6 @@ flash@0 {
>   		cdns,tchsh-ns = <60>;
>   		cdns,tslch-ns = <60>;
>   		cdns,read-delay = <4>;
> -		#address-cells = <1>;
> -		#size-cells = <1>;
>   	};
>   };
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
> index 990dfcd61018..e36335232cf8 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
> @@ -182,8 +182,6 @@ flash@0 {
>   		cdns,tchsh-ns = <60>;
>   		cdns,tslch-ns = <60>;
>   		cdns,read-delay = <0>;
> -		#address-cells = <1>;
> -		#size-cells = <1>;
>   	};
>   };
>
> --
> 2.34.1
>