Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4e638a79-8b2e-291c-3b91-57677ffcc1fa@amd.com>
Date:   Tue, 22 Feb 2022 10:42:25 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] x86/mce: Simplify CPU vendor checks for AMD/Hygon and
 Intel/Zhaoxin
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     tony.luck@intel.com, yazen.ghannam@amd.com,
        Smita.KoralahalliChannabasappa@amd.com,
        linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org
References: <20220222155857.276286-1-carlos.bilbao@amd.com>
 <YhUK87H4PQ22rpLw@zn.tnic>
From:   Carlos Bilbao <carlos.bilbao@amd.com>
In-Reply-To: <YhUK87H4PQ22rpLw@zn.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eE1zeXJoazB1QzdyUmRoM0x3QmtFbW15WnVKQ3FiVjMwT0x6QzMrSm9LVlhB?=
 =?utf-8?B?Zk0yYjhacVB5Tzd3VjBJb2I1ZVAxdU16THdHR2RIRmZEb3NIQjhkWEd5WmlW?=
 =?utf-8?B?ekQ5MVRMazNWakYwL3Z4SENYN0RUTTNZRnFEOW5ybUozNVQyUWlielAyV29o?=
 =?utf-8?B?YlVHcnFsM3V3amVCajd0OWtpZVhnSW9NYXJWQnJMSi9kN0gwSC9vT052NjdE?=
 =?utf-8?B?RnNDdGZvNVpKamhBc1FwWit6Q0daZVhGN3RVOWlCaVBRVDBKRDV6UmlCbHA2?=
 =?utf-8?B?ZXVJdlBVNnJyWDJMWmFYbWQ1UEh2K25leG9PdWRQYW82aDhPSk1tVTlZd3Fj?=
 =?utf-8?B?Y2FrSU1LM3hvbGwxT2tjQXF2M2p1SHYyL1MrUFRHSUpxd1N1T3ZlUnVsbHJX?=
 =?utf-8?B?TDRJbDh1VE9nWWY4SGwxdkY1NEVCbG1tdTVjWUYxRVNlRkw1anBwMmJuM3ZY?=
 =?utf-8?B?RWt5M0tjc3ZOWno5NXFjQ1FKVlcvd0lpNE1GVXBucnhBVGo3SnQ3aTBaR0c1?=
 =?utf-8?B?cDJ5c0g0Z0hJSk5FMFlNM2hvYlN4Z3ZTZEVaMURmM1N2MVQzVjlhcnRJMHlr?=
 =?utf-8?B?cG94Y1QxUi9XZHZCN0JZQTA4WlFnQ3JtSnhCelFCK3pjY0JTKzFQZmM1M29P?=
 =?utf-8?B?QnB2UndDc0RTRGdYaDFuNmlJSlloYXQ0RUVWeFZhbGFQQTgwUElST2VuVWFq?=
 =?utf-8?B?S0VyOWlBVmVjUE4xanA3aUZJd1JtWnQ3NFFPM1ZuM2lPcGs3cUhic0pnSUpX?=
 =?utf-8?B?MVM1K29yWExRYjZCV0dmanQ3WGpKZTVKN0VsblU0U3BMK3ovRjFSdUZjZGlG?=
 =?utf-8?B?TFJhN1hQcklhR2JLdmdZVFFlc1JQZkdRM1VJalZkVSs1KytrRUlUUmNyVjJ0?=
 =?utf-8?B?UndWQXNEWkVKdGZMTkJlT1NuRGI5OElOL1RYSUxKQnhuR29VMi9jYUVrcW1W?=
 =?utf-8?B?TVRsYWxLYkNJMm1icFo2cEF3TGswTkVMbi9zL1NYYndzNG9YWTdTaGczMTV5?=
 =?utf-8?B?VnZ0aHdEUmUzMUJWMk55ditjRDNtQmoxdWNyeENIbG1qeSs4VG5SbjZEbmFI?=
 =?utf-8?B?VjhvUnVad1FBMlpHVlpaMjhBOXhLRHVGQ0Z5b3B3eW1SNnMvYzJmMlAyTzRD?=
 =?utf-8?B?RFdIbm1CNG5rSFVPTURRSGhtbm0xUk9UVFNCVldNZ09LQlNwdDJveGROdVVX?=
 =?utf-8?B?TjNTVE5VOTRjUEVyZ1dXSU5KMUdqS2dEVkNIKzh6VmhBYmN5c3V0R3YxYnFu?=
 =?utf-8?B?Y3AvaEFOcFZQK3QvTlQvTldIcWFXcnYxNmdIT3gyRzBlcjJVWlJuWDJiRDZB?=
 =?utf-8?B?eVExMDllanhFWm9PbGtHdkxhektZNXRUOEhLcXRGemwzTHJ4b1dhS0RsSENq?=
 =?utf-8?B?QmtyVzY2V3UwZmZsZEVWbUxIa2ZhK01pZG54UUYvNVB3c0NoQmd3NTE1cGZr?=
 =?utf-8?B?b3BqMmMrQlNOVXRLd2thN25vWmM4MzhEaXRPSWIvTTVwV205bmxkbnpCQzRo?=
 =?utf-8?B?S29RaS82OERqSk5WRVR4bFFOd2puMnBleG1uaHJrdnhaSzdkb2hRcmRXVzRV?=
 =?utf-8?B?aWZ1VW9pVStsaTF3dmRoWUFDeEVzdjNiSjQxVkxIdG1rNS9SUmZWMFVMdHZq?=
 =?utf-8?B?SlRDNlJNYU1lblJORTJqNTNGWTdLaGZhN0hZRk5tcFJESHdxZ1lRZU94TWV5?=
 =?utf-8?B?dERqY09oQjN6akxsK01qV0FTVUhRRVZWeGZTQTVxR200Wm1DUkxQOFBETlVK?=
 =?utf-8?B?QzRYdTdrU3ZkaFdacDh6YUY0azdHREZydW5lVFRIWGM5dnVmVlJGNkpuSytN?=
 =?utf-8?B?eVpPTnBwRVg3ZFpKSitnZk01M1pnNnRCMXdBNHVGbzVEUzR3RzRETGNCZzlq?=
 =?utf-8?B?Uk9GK0MyT3BNTDI0NXRPL3ordDZsNWFQZTc3OXB0SnRYV3BCbmlDbDRLNjlY?=
 =?utf-8?B?OEY0bGhMTTFiUkZVaUFrZXNad3RvSGFLTWJMWWtTL3FoYVFuQm8yc2FDZ0ky?=
 =?utf-8?B?aExqZTB3RnpGSGZnb2lyWkNKRmdjUUZyR2ZHZmZlaGtZSjd4V3BiNXY4V3Rv?=
 =?utf-8?B?SlFoWnR2cUc4R0RFeExBb09iVStlWnlhWDIzOXFwUUFFU2tDV2tyQ01RZFI5?=
 =?utf-8?B?eW5PeFZlR21kZUo4SllMNDhYblpRZVhlZEpoMy95SDdCNHlIYWVUaVVwTldh?=
 =?utf-8?Q?XlDQsWP+ev8fdXpenLbhgj8=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6649680b-e8ab-44ee-ca9f-08d9f6224f7f
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 16:42:27.4137
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NV8Bp92p8lhSoBr1zxzRaF9EJMak6FzkFIZ+oHu/jQoRBAT0budUPWZ1HyUV9MwNBFBYcRfQqEoM5RM4QJCEqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4600
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

On 2/22/2022 10:10 AM, Borislav Petkov wrote:
> On Tue, Feb 22, 2022 at 09:58:58AM -0600, Carlos Bilbao wrote:
>> In a number of places across the MCE subsystem we check if we are running
>> an x86 processor from AMD/Hygon or Intel/Zhaoxin vendors. Simplify these
>> checks with two mce_flags updated at CPU MCE initialization.
> 
> ... and what's the point of this silliness?
> 

the point is to simplify the code (as the patch stated). Since we have 57
bits reserved but unused, it also wouldn't cost anything.

> Btw, you don't have to send it to my *two* email addresses - one is
> enough. :)
> 

Noted.

Carlos.