Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Feb 2022 17:54:35 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
        pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, quic_srivasam@quicinc.com
Subject: Re: [PATCH 09/16] ASoC: codecs: wcd934x: fix return value of
 wcd934x_rx_hph_mode_put
Message-ID: <YhUjW6B8LmoEWLRx@sirena.org.uk>
References: <20220222115933.9114-1-srinivas.kandagatla@linaro.org>
 <20220222115933.9114-10-srinivas.kandagatla@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mpa+mWrNm0hr054s"
Content-Disposition: inline
In-Reply-To: <20220222115933.9114-10-srinivas.kandagatla@linaro.org>
Precedence: bulk


--mpa+mWrNm0hr054s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Feb 22, 2022 at 11:59:26AM +0000, Srinivas Kandagatla wrote:
> wcd934x_rx_hph_mode_put currently returns zero eventhough it changes the value.
> Fix this, so that change notifications are sent correctly.

> -	return 0;
> +	return 1;

This now has the opposite issue where it will unconditionally flag a
change even if none occurred, that's less bad but still an issue.  It
should check to see if the value written is different to that already
set and report that.

--mpa+mWrNm0hr054s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIVI1oACgkQJNaLcl1U
h9Do7Qf9EZHwn4KoVflO91QHGRDyRPg2k3SZvPgEuaYXy4SxFSPrrxosil+RBxW3
wIoS20OhKfHkF+jirulBOcN3Sw3hV8MEuvpVZRUt9LhfH0EpZKIOytnVd13JBMJK
CUDiZGRUaqKBy0XtSOQ5WxqHqQgXTNYflj8hn6vWkuKqOEC6q3GHLf6UDDBO1B77
7GAiVMvBvYSsn2BrchOzaseSnd0uxHkxTeoUO+w78LeyNPRhg07mjlml4iS+wb4d
YBOQLtM/87JOdVbfvEvzQZSO1vM+Zd/1+lT0xslve4B126/o1Lvw1BZxAtkB9Jhv
ermlPqh8YhuwDuzqhenDhlLLzadmuA==
=Xc7o
-----END PGP SIGNATURE-----

--mpa+mWrNm0hr054s--