Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Feb 2022 18:10:57 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Carlos Bilbao <carlos.bilbao@amd.com>
Cc:     tony.luck@intel.com, yazen.ghannam@amd.com,
        Smita.KoralahalliChannabasappa@amd.com,
        linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH] x86/mce: Simplify CPU vendor checks for AMD/Hygon and
 Intel/Zhaoxin
Message-ID: <YhUZISFZRaBLbJ31@zn.tnic>
References: <20220222155857.276286-1-carlos.bilbao@amd.com>
 <YhUK87H4PQ22rpLw@zn.tnic>
 <4e638a79-8b2e-291c-3b91-57677ffcc1fa@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4e638a79-8b2e-291c-3b91-57677ffcc1fa@amd.com>
Precedence: bulk

Hi,

On Tue, Feb 22, 2022 at 10:42:25AM -0600, Carlos Bilbao wrote:
> the point is to simplify the code (as the patch stated).

But it doesn't simplify the code - it makes it obscure.

Also, your "simplification" breaks the moment you need to do something
for the one vendor but *not* for the other.

Because in such cases you'll have to do

	if (mce_flags.amd_compatible && m->cpuvendor != X86_VENDOR_HYGON)

which makes me go, "huh what?!"

So no, that's not better.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette