Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6230f480-a8cb-6807-35eb-b5ee407297f9@linaro.org>
Date:   Tue, 22 Feb 2022 17:30:11 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] nvmem: qfprom: Increase fuse blow timeout to prevent
 write fail.
Content-Language: en-US
To:     Knox Chiou <knoxchiou@chromium.org>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     Evan Green <evgreen@chromium.org>
References: <20220107103056.1.Ifc6ce6bb655ddb8ebbb0f340fcaaa58369bb009c@changeid>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
In-Reply-To: <20220107103056.1.Ifc6ce6bb655ddb8ebbb0f340fcaaa58369bb009c@changeid>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 07/01/2022 02:31, Knox Chiou wrote:
> sc7180 blow fuses got slightly chances to hit qfprom_reg_write timeout.
> Current timeout is simply too low. Since blowing fuses is a
> very rare operation, so the risk associated with overestimating this
> number is low.
> Increase fuse blow timeout from 1ms to 10ms.
> 
> Signed-off-by: Knox Chiou <knoxchiou@chromium.org>

Applied thanks,

--srini
> ---
> 
>   drivers/nvmem/qfprom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
> index c500d6235bf6b..1840d400fb53c 100644
> --- a/drivers/nvmem/qfprom.c
> +++ b/drivers/nvmem/qfprom.c
> @@ -22,7 +22,7 @@
>   
>   /* Amount of time required to hold charge to blow fuse in micro-seconds */
>   #define QFPROM_FUSE_BLOW_POLL_US	100
> -#define QFPROM_FUSE_BLOW_TIMEOUT_US	1000
> +#define QFPROM_FUSE_BLOW_TIMEOUT_US	10000
>   
>   #define QFPROM_BLOW_STATUS_OFFSET	0x048
>   #define QFPROM_BLOW_STATUS_BUSY		0x1