Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Christophe Leroy <christophe.leroy@csgroup.eu>
To:     Aaron Tomlin <atomlin@redhat.com>,
        "mcgrof@kernel.org" <mcgrof@kernel.org>
CC:     "cl@linux.com" <cl@linux.com>,
        "pmladek@suse.com" <pmladek@suse.com>,
        "mbenes@suse.cz" <mbenes@suse.cz>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "jeyu@kernel.org" <jeyu@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
        "void@manifault.com" <void@manifault.com>,
        "atomlin@atomlin.com" <atomlin@atomlin.com>,
        "allen.lkml@gmail.com" <allen.lkml@gmail.com>,
        "joe@perches.com" <joe@perches.com>,
        "msuchanek@suse.de" <msuchanek@suse.de>,
        "oleksandr@natalenko.name" <oleksandr@natalenko.name>
Subject: Re: [PATCH v8 02/13] module: Simple refactor in preparation for split
Thread-Topic: [PATCH v8 02/13] module: Simple refactor in preparation for
 split
Thread-Index: AQHYJ/ZTQttAsW+A00ePIvbeGZp2Jayf26wA
Date:   Tue, 22 Feb 2022 17:58:31 +0000
Message-ID: <df2eb4a4-36e5-a656-b127-1ab5591b6981@csgroup.eu>
References: <20220222141303.1392190-1-atomlin@redhat.com>
 <20220222141303.1392190-3-atomlin@redhat.com>
In-Reply-To: <20220222141303.1392190-3-atomlin@redhat.com>
Accept-Language: fr-FR, en-US
Content-Language: en-US
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OWk5T2YwOEh0RVFBN0F5SWdFaHQ4c0tOdzczRlYrMFhDWktFREszakhYWEpW?=
 =?utf-8?B?RGl6dW5Oayt5T3UvRmVrMXd5ZWJwTTdnWnEwelhDTkhJR0RqNmtwS055T2pZ?=
 =?utf-8?B?MjJ4aXN4b0xrcWpFUk5QcGRINXlicTJZU2tnVzJldUUvM0xWdmZmN3U3WGFm?=
 =?utf-8?B?UWhZa0wwUWJzTkpGS3pFYU16T29veHFHbWZ2UlJnaWlrLzBBSkJMeENRTGpx?=
 =?utf-8?B?TU0yT0VUZVh1dmxIdE8wcFUxVGxwOXRzbEh1aVRtczBZVVg4OGZRK3JtNCtq?=
 =?utf-8?B?Ym1UNlN5ME96NUd5MWRZRVZjNmV2TmhOOURsMGxNUG5seVpKTU5YakNyMjFD?=
 =?utf-8?B?RmZUTlZJZkh2eXg5bUM2RUJNdFplYzRPMlR6b0lSOWgxaDRKWGtLaFYvRXFu?=
 =?utf-8?B?MmM5a1ErVHFJTlNWalpVVjc5L3RwaDVIaDNCQWJERWxNaFUwMnJqR1pYT1lL?=
 =?utf-8?B?RlRteGxZdVUzMUtHTS91SnpBbk1Ma3U4ZzdGM3I1Q1g2L3JkeWpobzROUTdz?=
 =?utf-8?B?U3pEWExwWVZVZzh4MHNsM2ovYzVOTndUeW1IWiszUWJDelgybW8xYmtGUXdB?=
 =?utf-8?B?MHlWZURxZ0lJVmg4OHFGZDNOc1ZvTkxJbjcvSjVUd3JJeVl3N0Fld1M5SEp4?=
 =?utf-8?B?TXRUcXJyTG11OVZZQkFJYUo3WFBSanJROGp3dFJyd0Y5TmMxVFNlN1grTjNG?=
 =?utf-8?B?cnBjSjg1OWQ2Q3Q5V1ZrYXhlbUxEbG50emhNYXJ0Ums3dEwwdnA1emN6NXIv?=
 =?utf-8?B?S2NVZkFZUVNwWWtuLythSzhPMHlGaFRyRGQ3dG1yUVprVHhpeGdEcU9tYjR0?=
 =?utf-8?B?UnNySjlGUWxSR2xqcTZublpPQzNXM0F2cnlESkJjQU1HK1lQbitxMEFXZzRq?=
 =?utf-8?B?bTdWWm9SMnVYVzFyWkhJb3hMbEdJZ1ZkWDVyV3hpRVFaR0h4bDU2b1I1Njda?=
 =?utf-8?B?K3Q3WWZ3NS9CKzJ0c0RqMVRpeEdzMWFpaUtoYmpoQzNtUk42eUNreUYyZ2lS?=
 =?utf-8?B?TkNwWmNiTEdYTllaUUp3WDQ1WkM4V3lwYkthZU1NQmNKNWREQmM2bi9rRVcy?=
 =?utf-8?B?MkZkdS9jMHA5MmRPRWt5dzZFRFJwQVJwY0JIRDJFZkZ2Sk5hdW1iV2syWjk5?=
 =?utf-8?B?K1dzQ3hvdm5kM0Mzc0ZNSWh5TEoyOUNhNng1VjhoV3NpREh6RC9RdlRLM1FE?=
 =?utf-8?B?a1MxUjZHZzFkeHZWNjNVR1poWVVzZldkd2JTdVE3MW8vMXJ1SklrMGhRU3Ru?=
 =?utf-8?B?aUoyWWlrZ2VRN1ZKWDk1KzNuaEkxZUVJZHBVdnNQYm5xRFZJamw3aUNNTVFX?=
 =?utf-8?B?VWs5VGJ2WUxQMmRTNU5UL055T29WczlYRnJoTWxXbUhjSklNSmltaldhTlJM?=
 =?utf-8?B?TCtFMkptamw3MVB5bzdkeXdJUEI3NkwwbWsxUWdDckI0Q1A3aWVkV2VzcnFI?=
 =?utf-8?B?RmNsZXNIb3pyTWZ2Vld5bFdCc3FvV050Rnpjcm5kT3Vzb25ZRGh6ZzZhWkpa?=
 =?utf-8?B?NTVvWEl0TkZ4allrSzlKZWpPWEQ2diszTUc0UnJ4Ukh3SXFsY0pyRUgyOWFE?=
 =?utf-8?B?dzFqZ1Bmc0VBN1RXNVRIZWl5SGk2d3l4b1hUM0NoOGc2T29waXFjVzMwYTZr?=
 =?utf-8?B?SE8zZ1V0SEJDdFllcHpUem1PYUM1UnMvdCtxOGhIZ2dIaWRETXg3a3ZabmxR?=
 =?utf-8?B?U1lDanRnK2xETmFXZ25IQ1g5WEh4V3pUTmVOaFlIM2pHOFJOSmtTLzczNCsy?=
 =?utf-8?B?VDR5VVdGVXVsL0ZuRm02NFpXd0pGcTJVMmRQR2dZMkowRHd3OFZGYWhqSHZQ?=
 =?utf-8?B?eHlZb29yTTBjN2VEbTdZSHVDTXp3K1VTWTUxcEVRdnRpdEZTUlBPOG1xRnhL?=
 =?utf-8?B?OHZTK3I2Wk5XYnFNa3JxcXhZeW54V3FDT2J1ajZ2VGxUNnRqbWVRTUFEc1lm?=
 =?utf-8?B?SkNaeU5oUTgrQUsvS0ZGZDE3YUNLZmE3YlZHbXlZREhkWmRIcGIwbVE4YUJZ?=
 =?utf-8?B?SFZzWERCV2dJSXhNZ2x2SUIvUnV6Q1RqdTdSZnBKRzc1V0xFMnhCNDFkZVNC?=
 =?utf-8?B?Z0NnYUZydzc4WUM1ZDl1R0dteml1U1o5SzlGaXdqRHlwVGJ2TG1lVEZyTTdp?=
 =?utf-8?B?Mm1FaDYvYTdDdjF6a0pZbmZlRG4wR0pseHhoOHZremFsUHlLQWJqUVNzZDYz?=
 =?utf-8?B?Q2tzVktrNHcrblFleFJrT2hGOWdnakpRdFJKRGV5THg4OGwvWkNlODVTUkdE?=
 =?utf-8?Q?XbxBhXdyd5nLcsDkJxmx4gkuDthN4Cb/XZVVzXe1PY=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <0038A705E77F9A49AA9DB15F78671C45@FRAP264.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: csgroup.eu
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MRZP264MB2988.FRAP264.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d388c95-378e-4155-206a-08d9f62cefc3
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2022 17:58:31.0234
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 9914def7-b676-4fda-8815-5d49fb3b45c8
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ItHPjJCwWX1C3MPe93V0YnsidSLwhZIxMB3sQJYKC1usXrVQZC7LJ3LAtuHhe93H3i6H9veA1roWGG0OdhcXoyo/xwpmOcVok2MXzqtQ8rk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MR1P264MB3442
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

DQoNCkxlIDIyLzAyLzIwMjIgw6AgMTU6MTIsIEFhcm9uIFRvbWxpbiBhIMOpY3JpdMKgOg0KPiBO
byBmdW5jdGlvbmFsIGNoYW5nZS4NCj4gDQo+IFRoaXMgcGF0Y2ggbWFrZXMgaXQgcG9zc2libGUg
dG8gbW92ZSBub24tZXNzZW50aWFsIGNvZGUNCj4gb3V0IG9mIGNvcmUgbW9kdWxlIGNvZGUuDQo+
IA0KPiBTaWduZWQtb2ZmLWJ5OiBBYXJvbiBUb21saW4gPGF0b21saW5AcmVkaGF0LmNvbT4NCg0K
UmV2aWV3ZWQtYnk6IENocmlzdG9waGUgTGVyb3kgPGNocmlzdG9waGUubGVyb3lAY3Nncm91cC5l
dT4NCg0KPiAtLS0NCj4gICBrZXJuZWwvbW9kdWxlL2ludGVybmFsLmggfCAyMSArKysrKysrKysr
KysrKysrKysrKysNCj4gICBrZXJuZWwvbW9kdWxlL21haW4uYyAgICAgfCAyMiArKy0tLS0tLS0t
LS0tLS0tLS0tLS0tDQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCAyMCBk
ZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9rZXJuZWwvbW9kdWxlL2ludGVybmFsLmgg
Yi9rZXJuZWwvbW9kdWxlL2ludGVybmFsLmgNCj4gaW5kZXggOGMzODFjOTkwNjJmLi5lYThjNGMw
MjYxNGMgMTAwNjQ0DQo+IC0tLSBhL2tlcm5lbC9tb2R1bGUvaW50ZXJuYWwuaA0KPiArKysgYi9r
ZXJuZWwvbW9kdWxlL2ludGVybmFsLmgNCj4gQEAgLTcsNiArNywyNyBAQA0KPiAgIA0KPiAgICNp
bmNsdWRlIDxsaW51eC9lbGYuaD4NCj4gICAjaW5jbHVkZSA8YXNtL21vZHVsZS5oPg0KPiArI2lu
Y2x1ZGUgPGxpbnV4L211dGV4Lmg+DQo+ICsNCj4gKyNpZm5kZWYgQVJDSF9TSEZfU01BTEwNCj4g
KyNkZWZpbmUgQVJDSF9TSEZfU01BTEwgMA0KPiArI2VuZGlmDQo+ICsNCj4gKy8qIElmIHRoaXMg
aXMgc2V0LCB0aGUgc2VjdGlvbiBiZWxvbmdzIGluIHRoZSBpbml0IHBhcnQgb2YgdGhlIG1vZHVs
ZSAqLw0KPiArI2RlZmluZSBJTklUX09GRlNFVF9NQVNLICgxVUwgPDwgKEJJVFNfUEVSX0xPTkcg
LSAxKSkNCj4gKy8qIE1heGltdW0gbnVtYmVyIG9mIGNoYXJhY3RlcnMgd3JpdHRlbiBieSBtb2R1
bGVfZmxhZ3MoKSAqLw0KPiArI2RlZmluZSBNT0RVTEVfRkxBR1NfQlVGX1NJWkUgKFRBSU5UX0ZM
QUdTX0NPVU5UICsgNCkNCj4gKw0KPiArZXh0ZXJuIHN0cnVjdCBtdXRleCBtb2R1bGVfbXV0ZXg7
DQo+ICtleHRlcm4gc3RydWN0IGxpc3RfaGVhZCBtb2R1bGVzOw0KPiArDQo+ICsvKiBQcm92aWRl
ZCBieSB0aGUgbGlua2VyICovDQo+ICtleHRlcm4gY29uc3Qgc3RydWN0IGtlcm5lbF9zeW1ib2wg
X19zdGFydF9fX2tzeW10YWJbXTsNCj4gK2V4dGVybiBjb25zdCBzdHJ1Y3Qga2VybmVsX3N5bWJv
bCBfX3N0b3BfX19rc3ltdGFiW107DQo+ICtleHRlcm4gY29uc3Qgc3RydWN0IGtlcm5lbF9zeW1i
b2wgX19zdGFydF9fX2tzeW10YWJfZ3BsW107DQo+ICtleHRlcm4gY29uc3Qgc3RydWN0IGtlcm5l
bF9zeW1ib2wgX19zdG9wX19fa3N5bXRhYl9ncGxbXTsNCj4gK2V4dGVybiBjb25zdCBzMzIgX19z
dGFydF9fX2tjcmN0YWJbXTsNCj4gK2V4dGVybiBjb25zdCBzMzIgX19zdGFydF9fX2tjcmN0YWJf
Z3BsW107DQo+ICAgDQo+ICAgc3RydWN0IGxvYWRfaW5mbyB7DQo+ICAgCWNvbnN0IGNoYXIgKm5h
bWU7DQo+IGRpZmYgLS1naXQgYS9rZXJuZWwvbW9kdWxlL21haW4uYyBiL2tlcm5lbC9tb2R1bGUv
bWFpbi5jDQo+IGluZGV4IDM0YTJiMGNmM2MzZS4uNWY1ZTIxZjk3MmRkIDEwMDY0NA0KPiAtLS0g
YS9rZXJuZWwvbW9kdWxlL21haW4uYw0KPiArKysgYi9rZXJuZWwvbW9kdWxlL21haW4uYw0KPiBA
QCAtNjMsMTAgKzYzLDYgQEANCj4gICAjZGVmaW5lIENSRUFURV9UUkFDRV9QT0lOVFMNCj4gICAj
aW5jbHVkZSA8dHJhY2UvZXZlbnRzL21vZHVsZS5oPg0KPiAgIA0KPiAtI2lmbmRlZiBBUkNIX1NI
Rl9TTUFMTA0KPiAtI2RlZmluZSBBUkNIX1NIRl9TTUFMTCAwDQo+IC0jZW5kaWYNCj4gLQ0KPiAg
IC8qDQo+ICAgICogTW9kdWxlcycgc2VjdGlvbnMgd2lsbCBiZSBhbGlnbmVkIG9uIHBhZ2UgYm91
bmRhcmllcw0KPiAgICAqIHRvIGVuc3VyZSBjb21wbGV0ZSBzZXBhcmF0aW9uIG9mIGNvZGUgYW5k
IGRhdGEsIGJ1dA0KPiBAQCAtNzgsOSArNzQsNiBAQA0KPiAgICMgZGVmaW5lIGRlYnVnX2FsaWdu
KFgpIChYKQ0KPiAgICNlbmRpZg0KPiAgIA0KPiAtLyogSWYgdGhpcyBpcyBzZXQsIHRoZSBzZWN0
aW9uIGJlbG9uZ3MgaW4gdGhlIGluaXQgcGFydCBvZiB0aGUgbW9kdWxlICovDQo+IC0jZGVmaW5l
IElOSVRfT0ZGU0VUX01BU0sgKDFVTCA8PCAoQklUU19QRVJfTE9ORy0xKSkNCj4gLQ0KPiAgIC8q
DQo+ICAgICogTXV0ZXggcHJvdGVjdHM6DQo+ICAgICogMSkgTGlzdCBvZiBtb2R1bGVzIChhbHNv
IHNhZmVseSByZWFkYWJsZSB3aXRoIHByZWVtcHRfZGlzYWJsZSksDQo+IEBAIC04OCw4ICs4MSw4
IEBADQo+ICAgICogMykgbW9kdWxlX2FkZHJfbWluL21vZHVsZV9hZGRyX21heC4NCj4gICAgKiAo
ZGVsZXRlIGFuZCBhZGQgdXNlcyBSQ1UgbGlzdCBvcGVyYXRpb25zKS4NCj4gICAgKi8NCj4gLXN0
YXRpYyBERUZJTkVfTVVURVgobW9kdWxlX211dGV4KTsNCj4gLXN0YXRpYyBMSVNUX0hFQUQobW9k
dWxlcyk7DQo+ICtERUZJTkVfTVVURVgobW9kdWxlX211dGV4KTsNCj4gK0xJU1RfSEVBRChtb2R1
bGVzKTsNCj4gICANCj4gICAvKiBXb3JrIHF1ZXVlIGZvciBmcmVlaW5nIGluaXQgc2VjdGlvbnMg
aW4gc3VjY2VzcyBjYXNlICovDQo+ICAgc3RhdGljIHZvaWQgZG9fZnJlZV9pbml0KHN0cnVjdCB3
b3JrX3N0cnVjdCAqdyk7DQo+IEBAIC00MDgsMTQgKzQwMSw2IEBAIHN0YXRpYyBfX21heWJlX3Vu
dXNlZCB2b2lkICphbnlfc2VjdGlvbl9vYmpzKGNvbnN0IHN0cnVjdCBsb2FkX2luZm8gKmluZm8s
DQo+ICAgCXJldHVybiAodm9pZCAqKWluZm8tPnNlY2hkcnNbc2VjXS5zaF9hZGRyOw0KPiAgIH0N
Cj4gICANCj4gLS8qIFByb3ZpZGVkIGJ5IHRoZSBsaW5rZXIgKi8NCj4gLWV4dGVybiBjb25zdCBz
dHJ1Y3Qga2VybmVsX3N5bWJvbCBfX3N0YXJ0X19fa3N5bXRhYltdOw0KPiAtZXh0ZXJuIGNvbnN0
IHN0cnVjdCBrZXJuZWxfc3ltYm9sIF9fc3RvcF9fX2tzeW10YWJbXTsNCj4gLWV4dGVybiBjb25z
dCBzdHJ1Y3Qga2VybmVsX3N5bWJvbCBfX3N0YXJ0X19fa3N5bXRhYl9ncGxbXTsNCj4gLWV4dGVy
biBjb25zdCBzdHJ1Y3Qga2VybmVsX3N5bWJvbCBfX3N0b3BfX19rc3ltdGFiX2dwbFtdOw0KPiAt
ZXh0ZXJuIGNvbnN0IHMzMiBfX3N0YXJ0X19fa2NyY3RhYltdOw0KPiAtZXh0ZXJuIGNvbnN0IHMz
MiBfX3N0YXJ0X19fa2NyY3RhYl9ncGxbXTsNCj4gLQ0KPiAgICNpZm5kZWYgQ09ORklHX01PRFZF
UlNJT05TDQo+ICAgI2RlZmluZSBzeW12ZXJzaW9uKGJhc2UsIGlkeCkgTlVMTA0KPiAgICNlbHNl
DQo+IEBAIC00NTQyLDkgKzQ1MjcsNiBAQCBzdGF0aWMgdm9pZCBjZmlfY2xlYW51cChzdHJ1Y3Qg
bW9kdWxlICptb2QpDQo+ICAgI2VuZGlmDQo+ICAgfQ0KPiAgIA0KPiAtLyogTWF4aW11bSBudW1i
ZXIgb2YgY2hhcmFjdGVycyB3cml0dGVuIGJ5IG1vZHVsZV9mbGFncygpICovDQo+IC0jZGVmaW5l
IE1PRFVMRV9GTEFHU19CVUZfU0laRSAoVEFJTlRfRkxBR1NfQ09VTlQgKyA0KQ0KPiAtDQo+ICAg
LyogS2VlcCBpbiBzeW5jIHdpdGggTU9EVUxFX0ZMQUdTX0JVRl9TSVpFICEhISAqLw0KPiAgIHN0
YXRpYyBjaGFyICptb2R1bGVfZmxhZ3Moc3RydWN0IG1vZHVsZSAqbW9kLCBjaGFyICpidWYpDQo+
ICAgew==