Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <39e919dd-f73c-6698-dd4c-e42c5cbe1494@redhat.com>
Date:   Tue, 22 Feb 2022 20:50:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v1] drivers/base/memory: clarify adding and removing of
 memory blocks
Content-Language: en-US
To:     Oscar Salvador <osalvador@suse.de>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Andrew Morton <akpm@linux-foundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michal Hocko <mhocko@suse.com>
References: <20220221154531.11382-1-david@redhat.com>
 <YhR5coy7OGyjwQtx@localhost.localdomain>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <YhR5coy7OGyjwQtx@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22.02.22 06:49, Oscar Salvador wrote:
> On Mon, Feb 21, 2022 at 04:45:31PM +0100, David Hildenbrand wrote:
>> Let's make it clearer at which places we actually add and remove memory
>> blocks -- streamlining the terminology -- and highlight which memory
>> block start out online and which start out as offline.
>>
>> * rename add_memory_block -> add_boot_memory_block
>> * rename init_memory_block -> add_memory_block
>> * rename unregister_memory -> remove_memory_block
>> * rename register_memory -> __add_memory_block
>> * add add_hotplug_memory_block
>> * mark add_boot_memory_block with __init (suggested by Oscar)
>>
>> __add_memory_block() is  a pure helper for add_memory_block(), remove
>> the somewhat obvious comment.
>>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Michal Hocko <mhocko@suse.com>
>> Cc: Oscar Salvador <osalvador@suse.de>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
> 
> Thanks for doing this, it makes the code much more clear.
> 
> Reviewed-by: Oscar Salvador <osalvador@suse.de>
> 
>> ---
>>
>> Based on v5.17-rc5 and:
>> 	[PATCH v2 0/2] drivers/base/memory: determine and store zone for
>> 	single-zone memory blocks [1]
> 
> Maybe just my thing, but I also had to pull in [1] in order to apply
> this error-free. 
> 
> [1] https://patchwork.kernel.org/project/linux-mm/patch/20220128144540.153902-1-david@redhat.com/

Ah, yes, I forgot to mention that -- also already in -mm and -next.

Thanks!

-- 
Thanks,

David / dhildenb