Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v3 4/4] x86/mce: Avoid unnecessary padding in struct
 mce_bank
To:     Borislav Petkov <bp@alien8.de>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Cc:     x86@kernel.org, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H . Peter Anvin" <hpa@zytor.com>,
        James Morse <james.morse@arm.com>,
        Robert Richter <rric@kernel.org>,
        Yazen Ghannam <yazen.ghannam@amd.com>
References: <20220211223442.254489-1-Smita.KoralahalliChannabasappa@amd.com>
 <20220211223442.254489-5-Smita.KoralahalliChannabasappa@amd.com>
 <YhUC+T44sQK43+QZ@zn.tnic>
From:   "Koralahalli Channabasappa, Smita" <skoralah@amd.com>
Message-ID: <56166aca-8605-ec6b-6ccf-d76565518421@amd.com>
Date:   Tue, 22 Feb 2022 15:02:50 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.2.1
In-Reply-To: <YhUC+T44sQK43+QZ@zn.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mzk0UGxhL1QzU0lhbGx1ak5yNUlENEN5Sk9iUXJUNlF5U3FmMnRDaFEycno3?=
 =?utf-8?B?KzY4UnlWUjhnL1cwS0VMU2g0VUE1ZGVHYXRDb3BmU25DM3c3WmRzbytPU3VL?=
 =?utf-8?B?eGJGMGlWR3RvWXkrTVU0eUJ2eE80V0NMVURvcFpoN0ZKU0F1d0k4c2NxN1Vk?=
 =?utf-8?B?aEtwcW5RL3QveXdYdys4Q0RKQUd1VDBPQy91TThTQ0RSc2p3Szk5bnJ5eEhT?=
 =?utf-8?B?Y2Ztd1VFRnQ2ZVFvNDd4TStGN3F4MGJZQytFUHprQ0tEWnEvV3puUURCNDBI?=
 =?utf-8?B?Qy9DVlF0WGZMUU5DNlF0TGk4WnFZbVRJRVFzVEIzYUpmWXhueVlvSkVnU1dL?=
 =?utf-8?B?bWZnb2RPYUx4VHptRmJ0YTFrUWZaNUhoeWFwc1pHU040U2lOaFZmNDVaV3pW?=
 =?utf-8?B?a3l1YU1KR0hCRVlqTVBJVi9CWVEvVHhRMXk3bzBEM0I4TU5yNVVsc2tFek9O?=
 =?utf-8?B?WmJCR2diZWhwektRS0ZuY1dqQndIeEhwN2NueU0vQjlYUUJGWlVrSTVpK3Nw?=
 =?utf-8?B?MXZSbVg5Z2Noam9PcFB0MnViQlNwVmM3Sng5Z1VqR2UrWGFUd0Fqd1prNGFY?=
 =?utf-8?B?Z2dmcDY3ZzZLWjZmeDlOcmlWM3RGRmpUN0ZrdVhyS2JLMExEZXZiS242TDBl?=
 =?utf-8?B?UkV0bmdPTUhBR2J1akRGd2JFellOSkhoUzNva3E3WE9EVVM1Q0srd3ZoYTJ0?=
 =?utf-8?B?aUFZRDNFeFBwRjR2R3RUTGp5dDZrZEN3V0FNejZ2V1RYNmVaOVpYUjhwYUNx?=
 =?utf-8?B?TWhDK2NBSHFDTkp0cy9zajE5Z2svYm5yRWNsK3VPazhrSUd2dGdHWE5MaGFz?=
 =?utf-8?B?WWRuUHE5VFZoZWE1MWlKQ3RYajJTcVdCazlKaUtENkMzWVFxMWc1a2NwTzV4?=
 =?utf-8?B?Y0QySVJxaC85K1BjRWlUTUFLQWpxMlNoQ1BkTW0rTGswUHBOSWJFVXNtQ0pi?=
 =?utf-8?B?M2pEaFpQSS9NbTRhSjJNZ3oyck5zam5ZcGE5ZHJMdkJ0bjBVSXFQMk41c2Er?=
 =?utf-8?B?QkVndHZsQ056V3dCZk9hamZvUW1JQmpDVkFqN2F0djNIZU1CR1AxdFhxWmtI?=
 =?utf-8?B?dnZRbko1UXhXaE5yU1oyMHRGdzFKS0VpKzhRclErOHAwLzFPVk5peXJ5b2N1?=
 =?utf-8?B?ZVNrbmVRempoZjFZNnZIMmtvblBqTHZUdkxNeUhlbVBBZWRvODZxQmphd2dD?=
 =?utf-8?B?Y21nL0hlZkJOSGlBUyttN0hKMytZY0JiVk45d3ZHQ3RYWldWMGNWK3ozVHp0?=
 =?utf-8?B?RWRVbW9mMTdEYU5adkc0ZGpVbUpKMU1waFR2d0ZPeFBOTDFQQ0J6M2o2QzQ4?=
 =?utf-8?B?SXZRUk41c3JBWjBkWjc4K0JsRjI4d2hoVEN1K2svWTVoaVBtRkNQTkVyeXdM?=
 =?utf-8?B?d3lxcnRUZmdZNFJ5aEt5VFd5dWVxWkdRZmFTbmdmd0dIVWlaSnFUbW1nSWJ3?=
 =?utf-8?B?OHVIWStoeVRrZ2lGZEN2TGNiNXVERjVCWUZhd2dnVmpOWGduV1d6dDhpdmwy?=
 =?utf-8?B?TGhVSnZ3WWhRQ2c2bTNkZU50Sk9Sd1NXYm5OTk4yajl2YmxtOWVaVGhkeU5h?=
 =?utf-8?B?NG8xOUxQSTBnT3BtVUtJdUdHcC9VTXZpa0N3WTlvWEx0Q3hLYUh2NUZ6c0Fy?=
 =?utf-8?B?VTE2ckR6S3Q2WHFVNnByc0M5RE5QY0hQdmhuTkwyaFE0bDNMNzRzSTF5aTJU?=
 =?utf-8?B?ZVVCbXpKejUySTZNUk9hN2pzZElGdzB3YWhaV0RHU25jWTgrVmpLZ0FDc3gy?=
 =?utf-8?B?NjZSSExpR0U0QngrYUpGT1IwclVDYWxKVWxkK1JvOXdCbUNLeUpGMlY3N081?=
 =?utf-8?B?YUFRaGc0a2tKaGtXTzdZSGRJZmlUNFZva2h2aVN4MGtHa091NTFUZUM3L1RT?=
 =?utf-8?B?SS9Za2RtTDhuVXRYaDdIRytQNXUzRUswZ2dtRSsxRnJnaCtZTVV2OVBSUGxP?=
 =?utf-8?B?MTcyNkcwMm1GUVFXYXQ0d0pteGVWWjhWTUhIWWZlTk5NYVVJRE44dTBKN3cx?=
 =?utf-8?B?UHJyenpSZE0wMmhGT01SWlkxYkRIME5GV3FsdWpLQTJIM3AvRFZPYzJ3T2FR?=
 =?utf-8?B?RFJSdDQwK3ZSNGhtbHdiZERubkRzWmlCT1FmWHRyUEV2MW9Ob3YrcVJCYXBp?=
 =?utf-8?B?T0N4N2Y5M0dZbElhVlFFUUZOa3RnMEd6L0JMMVAxZWl0MlRYcW51QU9nUjFJ?=
 =?utf-8?B?TE1aVlRiYmc1T0srMDRTblpoVHptdHdsSFI4b0Fidk11Um44Tk0yYjJMakNx?=
 =?utf-8?Q?qArtEM3/cO0QsxO7b69S53yQ2AiR+OCyOL6kgwnvDc=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 96f74787-f6da-4de1-5df0-08d9f646b131
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2876.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2022 21:02:53.5425
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PHgrLRtoSpgoykC7DZo3WlbtpHXPYGqCZPIAFaeroNBEecu8bLIJtfEpmltOYgSlGKil0tj3OCQ5a2fH9Z05zg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2638
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Boris,

On 2/22/22 9:36 AM, Borislav Petkov wrote:

> On Fri, Feb 11, 2022 at 04:34:42PM -0600, Smita Koralahalli wrote:
>> Include struct mce_bank member "init" in the bitfield by changing its type
>> from bool to get rid of unnecessary padding and to reduce the overall
>> struct size.
>>
>> Outputs collected before and after the change.
>>
>> $ pahole -C mce_bank arch/x86/kernel/cpu/mce/core.o
>>
>> before:
>>
>> 	/* size: 24, cachelines: 1, members: 5 */
>> 	/* bit holes: 1, sum bit holes: 62 bits */
>> 	/* bit_padding: 2 bits */
>> 	/* last cacheline: 24 bytes */
>>
>> after:
>>
>> 	/* size: 16, cachelines: 1, members: 5 */
>> 	/* last cacheline: 16 bytes */
> I don't mind cleanups like that but when you send them as part of a set
> adding new functionality, the usual rule is to put bug fixes, cleanups,
> improvements, etc to the existing code *first*, and then, ontop you add
> your new code.
>
> IOW, this patch should be first in your set.
>
> Thx.
>
Thanks for letting me know.
Will correct and move it to first in the next series.

Thanks,
Smita