Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Feb 2022 12:25:53 -0600
From:   Rob Herring <robh@kernel.org>
To:     Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc:     Cristian Marussi <cristian.marussi@arm.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/1] dt-bindings: arm: Add scmi_devid property
 description for SCMI
Message-ID: <YhUqsWRldHcVVmre@robh.at.kernel.org>
References: <cover.1645460043.git.oleksii_moisieiev@epam.com>
 <c751add9b54e9661e463ae265d8d5f0314eac33e.1645460043.git.oleksii_moisieiev@epam.com>
 <1645539763.068794.3016153.nullmailer@robh.at.kernel.org>
 <20220222145116.GA2024457@EPUAKYIW015D>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220222145116.GA2024457@EPUAKYIW015D>
Precedence: bulk

On Tue, Feb 22, 2022 at 02:51:16PM +0000, Oleksii Moisieiev wrote:
> On Tue, Feb 22, 2022 at 08:22:43AM -0600, Rob Herring wrote:
> > On Mon, 21 Feb 2022 17:26:47 +0000, Oleksii Moisieiev wrote:
> > > Document scmi_devid property for the devices, using SCMI protocol
> > > to work with clocks/resets/power-domains etc. This property is intended
> > > to set the device id, which should be used to manage device permissions
> > > in the firmware. Device permissions management is descibed in DEN 0056,
> > > Section 4.2.2.10 [0].
> > > 
> > > This property is useful for the virtualized systems, when several agents
> > > are running on the same platform. Agent term is descibed in Section
> > > 4.1.1 [0].
> > > 
> > > [0] https://urldefense.com/v3/__https://developer.arm.com/documentation/den0056/latest__;!!GF_29dbcQIUBPA!m_dudHGSVg6mys2GtScvkfHNbQ1mv2kCGeU2GEdcV_C0cqHoWuknIkJPdLTaKiq6Ed9f$ [developer[.]arm[.]com]
> > > 
> > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > ---
> > >  .../bindings/firmware/arm,scmi-devid.yaml     | 41 +++++++++++++++++++
> > >  1 file changed, 41 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/firmware/arm,scmi-devid.yaml
> > > 
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scmi-devid.example.dt.yaml: example-0: usb@ee0a0000:reg:0: [0, 3993632768, 0, 256] is too long
> > 	From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
> > 
> > doc reference errors (make refcheckdocs):
> > 
> > See https://urldefense.com/v3/__https://patchwork.ozlabs.org/patch/1595720__;!!GF_29dbcQIUBPA!m_dudHGSVg6mys2GtScvkfHNbQ1mv2kCGeU2GEdcV_C0cqHoWuknIkJPdLTaKsRHUfCS$ [patchwork[.]ozlabs[.]org]
> > 
> > This check can fail if there are any dependencies. The base for a patch
> > series is generally the most recent rc1.
> > 
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> > 
> > pip3 install dtschema --upgrade
> > 
> > Please check and re-submit.
> > 
> 
> Hi Rob,
> 
> Thank you. I will recheck on my side.

The default address and size cell size for examples are 1 cell.

Rob