Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp123333pxm; Tue, 22 Feb 2022 18:30:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJxNB/VfcU2TDxcZSSJi2mwjsMyK7HC9LRrruHvl4ampE4m5oXZr+dOs4DhVWDGG/g7WDiMg X-Received: by 2002:a17:906:4cca:b0:6ce:6a06:bf7 with SMTP id q10-20020a1709064cca00b006ce6a060bf7mr22025819ejt.109.1645583401088; Tue, 22 Feb 2022 18:30:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645583401; cv=none; d=google.com; s=arc-20160816; b=wIZvo9NsweMIH2RX4kCFjzyambkxgJkR81WT7Nnn2uXmkUDvUIfzjU1IloPX1kMjVd eclsXMrkYlubmrFGExGjXrdtlhjTrpG9z5yaYaCl/8YiZSHJSAXfMkcpiEoekX3JoLlp CL8sCgy1GzLOoXBMJyq3FBc4bKeSIE9JbhmDPjflVcYRt+JBdakEdfMlJx9cAYCzfU09 hXMRDOSuTbhatf2uzXdH2wrWLVto6QtjF5ECDLPAjfSwzYD9AGcaHm74JRfQBQiFNeCz M+/lXZ3NkK4eUHl7zYnd5UkgsznDDJo1aLdLNIY6ii0gkqU7vVGU7rmIvlcyS+WfxoLG EZrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=zJjW40gRYjxp9MOc6prbOQbeJQ4Y96DDyPM3W2oQ0zQ=; b=de2C0hR5EeUm1A7zlCMAZYyhl7boB7M3l6FnMVw2dWXokoVpLNuOw4TStRv28IPbbx NicfOKeS5MwSBuc6s6w00mMZDVCHL5lXyGz2B9Vj1x1BRdF6VPQQifZASERyHfwgDXs1 CeaZHB6ShpVlVpwI+CB/Ir8K19AnwG3UVQ/+CARyUBJ+Me4nWHjyS+Ptu3TdrIAB/0Z8 IjmzHiVnN+B+WrkUocer26Ts/vucbtL/ERdkCAR9XeqeaOkTMf+OPwGG6gJRevYcubN5 /2HscMYvBTyZSzxdSKYMP1e2Syrca6JxA4OsJ1cYWh2GbBJp+7hyT63/BJkhDaaBUx40 Wvow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LopXt5kB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n7si11189064edb.457.2022.02.22.18.29.38; Tue, 22 Feb 2022 18:30:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LopXt5kB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235474AbiBVUfO (ORCPT + 99 others); Tue, 22 Feb 2022 15:35:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235501AbiBVUfG (ORCPT ); Tue, 22 Feb 2022 15:35:06 -0500 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8462112D93E; Tue, 22 Feb 2022 12:34:40 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id bg10so46520851ejb.4; Tue, 22 Feb 2022 12:34:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zJjW40gRYjxp9MOc6prbOQbeJQ4Y96DDyPM3W2oQ0zQ=; b=LopXt5kB3hxGK0aA50DzHk+5tKlxBFD9uSUtVWerRLtJSjayu4367XM1r5cIPFx+Sq c7R4HaBJSrHWKruQItW+p5U4+D7gdLHfm4lyOROOXL+7LHH+F39SWgQ0XpaS0731nRZd w0svFDzd5lt1KhGVvPfz1BgU36ugsCUoYlluYMxvKYH7Irn8VjYxWrlGZxyX7nYfNSPM 0oRC0t/L9CzbqWisTVsMbW/QXQcgfU3Z4NRby95+ND3dPSTcj31BmCQLodu6VllVag3H 3m66m5/vRzsl9wSiY0ZTrBcWYgKQRRDUgng0hzxTkErcwcf4S3Tc6MQmRh5o0HI1E3W8 +PtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zJjW40gRYjxp9MOc6prbOQbeJQ4Y96DDyPM3W2oQ0zQ=; b=MnMpN5x2xISQ9Qx6kn91IPGsB53S0ms3iQd83STvXrbnt33B3TSYHraweNo590tDRm iKkW76iASZ7q2WD/lVJFcj5fwcTM2CEAN6hdUiwuFaHx/2qYC8JGy7TCUonAmF8kTlt/ 5WEgUVYM0wpr+semN5/dAIe6UWwDWaoanQVrzPUnj65DbE6k6oYReqo5dmRSqu874CqI sZxuhkGrASrrWJydKUZXZbkxtAJrSry9HxZSWqXiu3JhdTwTJgBjmaJdELfp3FlWeqmZ JTvTpVWQB/VKyCH+JiIgLKauizPBg405EAvDliwb4GWK5Fj6Q43YWY+u/v/1p5Q+xRbd rmig== X-Gm-Message-State: AOAM531AFUgKptQ+yipXT6andfbV9bFzIMmQUBEmjZV1JJ+Kw9gdnzHt e7/D4PWb1JRdfbUjCS1atmFL2atbpKsNIttr X-Received: by 2002:a17:907:1183:b0:6cf:ce2f:51c1 with SMTP id uz3-20020a170907118300b006cfce2f51c1mr20466998ejb.209.1645562078864; Tue, 22 Feb 2022 12:34:38 -0800 (PST) Received: from nergzd-desktop.localdomain ([62.122.67.26]) by smtp.gmail.com with ESMTPSA id ec37sm10358388edb.19.2022.02.22.12.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 12:34:38 -0800 (PST) From: Markuss Broks To: linux-kernel@vger.kernel.org Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Markuss Broks , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Henrik Rydberg , Stephen Rothwell , linux-input@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v6 0/2] Add support for Imagis touchscreens Date: Tue, 22 Feb 2022 22:34:09 +0200 Message-Id: <20220222203414.8656-1-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add support for Imagis touchscreens, used on various mobile devices such as Samsung Galaxy J5 (2015), J3 (2015), J5 (2016). v2: rebase on top of the correct tree v3: - prefix all defines as IST3038C - use two tabs for all defines - add missing header - drop ADDR_LEN and DATA_LEN defines; use sizeof(reg_be) instead - use __be32 type for reg_be - add a comment about i2c read not being successful on first try - use "ret" instead of "res" in read_reg function - don't use the internal __cpu_to_be32 function, use cpu_to_be32 instead - use "error" instead of "ret" in interrupt handler - pass the slot state directly, without ternary operator - drop the dev_err in init_input_dev function - reorder the functions in _probe so that the chipid command is read as fast as possible - don't use imagis_start in probe - initialize the irq after the chip is powered - save the return value in imagis_resume - drop WIDTH_MAJOR since only TOUCH_MAJOR is reported - the "chip detected" message is now dev_dbg - reorder headers so they are in alphabetic order - use GENMASK to generate masks for getting the X and Y coordinates and touch area - drop *_pressure from device tree bindings since the driver doesn't support reporting pressure - fix the typo with i2c address in device treee bindings (48 instead of 50) - add IRQF_NO_AUTOEN flag to avoid unbalanced irq enable v4: - alphabetically order MAINTAINERS entry - alphabetically order Kconfig and Makefile - drop the error message in init_regulators - disable regulators on probe error - drop IRQF_TRIGGER_FALLING - @ is not optional (device tree bindings) - don't use items for compatible - add maxItems property to reg, drop the comment v5: - compatible enum is not an item of the list, drop "-" v6: - add _MS suffix to the delay define, drop the comment - change the reason for retry comment - add imagis_power_off and imagis_power_on functions to turn regulators on and off - use imagis_power_on/off in imagis_start and imagis_stop as well as in probe function - use error instead of ret in calls to functions which only return 0 or -errno - include linux/bits.h - proper indentation in Kconfig - drop the dev_dbg chip id message - MODULE_DEVICE_TABLE(of, ...); - no extra tabs in i2c_driver struct - save the return value in imagis_suspend Markuss Broks (2): dt-bindings: input/touchscreen: bindings for Imagis Input: add Imagis touchscreen driver .../input/touchscreen/imagis,ist3038c.yaml | 78 +++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + MAINTAINERS | 6 + drivers/input/touchscreen/Kconfig | 10 + drivers/input/touchscreen/Makefile | 1 + drivers/input/touchscreen/imagis.c | 329 ++++++++++++++++++ 6 files changed, 426 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml create mode 100644 drivers/input/touchscreen/imagis.c -- 2.35.0