Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp125390pxm; Tue, 22 Feb 2022 18:33:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJwrV2URCU1ZERrl98NFaczVp5i2SDq9M5FrLaNuBQrgpDeO9jUPXRVx7XlV8wz9CdaWUa4E X-Received: by 2002:a17:906:b2d8:b0:6cf:d1b2:8d25 with SMTP id cf24-20020a170906b2d800b006cfd1b28d25mr20879029ejb.652.1645583607976; Tue, 22 Feb 2022 18:33:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645583607; cv=none; d=google.com; s=arc-20160816; b=D2MzrF9BXMvU496Ekxa1Nl7X/2cTJSHPd2JYPKsPDyHPZ5OvElRfAwjzKOGYfu1ZZI RDdUKyWKmzTsOiZspLfsZ02XzgGeaSXtWsrdpTZKwKk/idPrO6PtHGhEK2XGPiObKLZr pPVonCDzO35w1j/WT9VqDrwyqVNVRF12c5eF0UhwfSdLR3Q61rKVkco0EO/Z7GNgxZj+ wzTgSNzB8g07kOql/pt/3AiokfEOKW2XmgJKwG4ot1pwkASdNQ58VQ5HMrGjD817tDwB x4DWUDzHH7t2OIFt8NV7m7MRbATiCi6qSh8P/Yi5ZoVT7qkw0odTkf4ponQ6ZJBC5eSJ ZB5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rqGrmy6lbtN8CiyKUgUga48hRbH1yOq0jwvMOL2mylw=; b=QJ6LB78A8cJ9P9Gy8Kpufz4nxeSOYntmo4xWX3KUmoWQ6NiiwN+30wktwRT5JVN1VK AQmmZZdDTANb0dc5xlsaDMqbblz7W4eyRkmG4dZvSs5wzYXM7rCIZMrkxBZJM580hsv0 jxaQo8mWy/j6I/IVdu5O9aFbmnPdsdZAY9tSn2vnrGTI6of+9wqrIWCxWGb9Yzko/t2Q ctj2fLBZWj5Y9TWH+5kSPW4QvQDmY2LDb0r1f2DsIlsQGcqp6MRt0C88CoT7j4ZE+r0u hwBXu4D1s5SijysDCmAYNRAUarpx4LXSlgeuTrh1GMaGCLic+sAz3GUqW+yEBYAC7wtS wi9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CeAFQh4z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e21si14034098eds.371.2022.02.22.18.33.05; Tue, 22 Feb 2022 18:33:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CeAFQh4z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236587AbiBWBgc (ORCPT + 99 others); Tue, 22 Feb 2022 20:36:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232372AbiBWBgb (ORCPT ); Tue, 22 Feb 2022 20:36:31 -0500 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 522B34A93B for ; Tue, 22 Feb 2022 17:36:05 -0800 (PST) Received: by mail-pf1-x42b.google.com with SMTP id g1so13861358pfv.1 for ; Tue, 22 Feb 2022 17:36:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rqGrmy6lbtN8CiyKUgUga48hRbH1yOq0jwvMOL2mylw=; b=CeAFQh4zL40mHQRpMM4poJnfaYnjJ/3vwjsyaR/T7gdO3wW/MyqDi56j/tQxq9F/4m YpufggfH2s8FqmVgBe2AxuB29WOeGgvEKqALHKgLVcI7lT9kcOfLhYttfmxmv183KDE3 D2SefRWEOrrDAHI8yRN8j31+ZgUJV5oH5hnps= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rqGrmy6lbtN8CiyKUgUga48hRbH1yOq0jwvMOL2mylw=; b=6SI+IApeCCcyuF/BjnUi2OCi46UVoHw5gSHyWMOSoNdRjd3oRI+9I9yv6cqFQdho+V +Xg/9CXzeFpc4ArWx4PuHsr9K3HKVK7Dc5wqQ6vHzlf46/+KiTraErCKrhvWJA7FNnRk KDFXyvkRMmNCOJu2+BVOhjhLHJtcO8X3/2r5qeTsJTDcOe+y9OMMr5gJogrQryvP/jfL 62kvwXkkfmv2/LBAuEkRsoNJFGx0v8OM8DHmI0tv4ahMapngCsQe0jglGgZLawT3wirT H33uvWJ5/jC3bLv6Vu4UyC+IONIjUtWMhVtJKs1BZiftHsQTvEmj1GWQ9P4yH/WClNB4 cj6g== X-Gm-Message-State: AOAM532ziGijYTumCWLU7DkQS+8T+/O+bgwl8S5mWVpExB8WLki78Ur7 gy7yGezVd9Smr0XGXjmZU0xHcw== X-Received: by 2002:a63:4d10:0:b0:36c:dcd6:46d7 with SMTP id a16-20020a634d10000000b0036cdcd646d7mr21700493pgb.207.1645580164896; Tue, 22 Feb 2022 17:36:04 -0800 (PST) Received: from google.com ([240f:75:7537:3187:d2bd:9913:3c85:9aca]) by smtp.gmail.com with ESMTPSA id z15sm896340pjf.31.2022.02.22.17.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 17:36:04 -0800 (PST) Date: Wed, 23 Feb 2022 01:35:58 +0000 From: Sergey Senozhatsky To: "Guilherme G. Piccoli" Cc: Sergey Senozhatsky , bhe@redhat.com, pmladek@suse.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, anton@enomsg.org, ccross@android.com, dyoung@redhat.com, feng.tang@intel.com, john.ogness@linutronix.de, keescook@chromium.org, kernel@gpiccoli.net, kexec@lists.infradead.org, rostedt@goodmis.org, tony.luck@intel.com, vgoyal@redhat.com Subject: Re: [PATCH V6] panic: Move panic_print before kmsg dumpers Message-ID: References: <20220214141308.841525-1-gpiccoli@igalia.com> <7702bdc2-78ce-00f5-d5a4-c06527c3ae72@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7702bdc2-78ce-00f5-d5a4-c06527c3ae72@igalia.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (22/02/22 11:08), Guilherme G. Piccoli wrote: > Hi Sergey, thanks for your feedback. So, personally I prefer having the > flag - for me it's clear, it's just a matter of reading the prototype - > either we print the info _or_ we console_flush. > > But let's see if others have a preference - if the preference is to use > the bitmask as you suggest, we can do it in a next version. Sounds good to me, thanks.