Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Feb 2022 16:39:20 -0800
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     tangmeng <tangmeng@uniontech.com>
Cc:     Matthew Wilcox <willy@infradead.org>, viro@zeniv.linux.org.uk,
        akpm@linux-foundation.org, keescook@chromium.org,
        yzaikin@google.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        nizhen@uniontech.com, zhanglianjie@uniontech.com,
        nixiaoming@huawei.com, sujiaxun@uniontech.com
Subject: Re: [PATCH 10/11] fs/drop_caches: move drop_caches sysctls to its
 own file
Message-ID: <YhWCOBqKc8xIylmT@bombadil.infradead.org>
References: <20220220060626.15885-1-tangmeng@uniontech.com>
 <YhIokWPShGOYh9LK@casper.infradead.org>
 <cbc60b32-d69c-d848-ca4c-650016da65d3@uniontech.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cbc60b32-d69c-d848-ca4c-650016da65d3@uniontech.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Mon, Feb 21, 2022 at 09:55:18AM +0800, tangmeng wrote:
> I think it is obviously the right thing that we need to do.

Since you are following up on more changes, can you work on this?
Brownie points if you show size results to refelct no size difference
based on a new build with an example new user.

> However, many submissions have been commited which registers an array
> before, I think that having a register_sysctl_one() which registers exactly
> one ctl_table should submit in a separate submission, rather than modify it
> this time.

We can optimize this later and fix those.

  Luis