Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6383a6b9-5e03-25e3-922e-97240d7b59ca@oracle.com>
Date:   Tue, 22 Feb 2022 16:27:12 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] mm/hugetlb: use helper macro __ATTR_RW
Content-Language: en-US
To:     Miaohe Lin <linmiaohe@huawei.com>, akpm@linux-foundation.org
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20220222112731.33479-1-linmiaohe@huawei.com>
From:   Mike Kravetz <mike.kravetz@oracle.com>
In-Reply-To: <20220222112731.33479-1-linmiaohe@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjFHQXZNcUYrNnVzc1Y4RTNuUUhheWs1RTE2eHVjeVN5VU9Oek81VEdzLytj?=
 =?utf-8?B?UkQ0c3I1d3kyYUpvMU5XWGhqKzhtMkg3SnhtdWJxQUc5Y1IrNENjaGwxbWx4?=
 =?utf-8?B?dVFSVlJtcVNqMXRpRkQ1Umd1S3RLZHFjV0FMUmlCQ08vRC8yaWZ1V3FneFor?=
 =?utf-8?B?Z01TZEhsTGpsSHY3UGtlUE1rbE14YkR0dDBObGxucW1Tanp3USszc3NxRm5K?=
 =?utf-8?B?OW1JNjFvME1JU0RaR3JFTmdpNUVWRFBqQkJJb3Z6ZnJ4Y3NhdjJ3SVJ6ZjBu?=
 =?utf-8?B?Y0ZlOWMrUjBIb1BoR2Uvc1ZyRHEvSUhERElwNGdPWHdKd1RIZTc1VFR2VERT?=
 =?utf-8?B?K051Kzl4Q0FBYlZHMGYwMEU0OVprajRiK3k1dW5ZNS9QNHFPY2tENXlCUmYz?=
 =?utf-8?B?amFDeG9jZ2ZuaU5nRjQ5TGRBcVhjYWRnTzhUdS91TTJ3TzRGYmJXVUFqTmtK?=
 =?utf-8?B?NEUzZTU5a2tucEc5dFNZM3JUcldUOVl1NDh6Ky95aS8zZktyTFhVT2c3S25w?=
 =?utf-8?B?T0dRRGRtQWtLTlI4d2N1c0FFcVZid2tlMzZFN0lST3ZyZkRYYStwczlvV1o4?=
 =?utf-8?B?L2tuZU1CVk53aG9GRTJSVGc4NE9LRmNDSmJURFhjN3pyME9QOVBKYlVaYXBv?=
 =?utf-8?B?VS9XWVd0clI3RE9KRTJmK25MM09PZVE5T1JtTythcU1oMVRQOEpTQ1BsL2F1?=
 =?utf-8?B?bmczR29wYmRKZVEwaG51UzlwZzd5SGZiWUswTkhDR1ppOVpXL2dIM1EzWWdt?=
 =?utf-8?B?WmtRUGMxTzJIdnZmMXh0VEtnbFkxM1YvYnhhSkVPL1NTbXRVUS9HODFvK05W?=
 =?utf-8?B?Y3JDSDBHQ3lwOGRvWVhKbGRTYXZMMGh2MmRhaFBnLzk4clZXMXZ3K25WUEdP?=
 =?utf-8?B?TUc1R085NmNHaWh4TEVDMHZMWHpVSUpTdnRLUmVaYWw1anRObkVnd3czR1A3?=
 =?utf-8?B?WkxOZURhdEhhV2RFbTJjK0s1SG5UUi9RaWFXV0sweTZGck1FZUI1MTZGUSt0?=
 =?utf-8?B?dllocmdOWDdYT3UxeVlmZ0NMeTRZWmVYNTJBQ3VIUjdxMmo2bTdzSFNUSmx5?=
 =?utf-8?B?cXVGODBCb1crZWdvakFHUnNCWEc4S1Vuby90WTA5QjhRUDRoNEdaRjBRbjZj?=
 =?utf-8?B?WVVWQnZpaE4vRXZjaTB3VFZSamtDU3hCYXl1NjFkMnF0cENjdkxiTnNiN0Iw?=
 =?utf-8?B?TERqNzd2K05JbGN2bGdyV2tKUWpPN2VwMWpNcGo2Q0UwQkZ6cTBBK2Z1dFhK?=
 =?utf-8?B?RERYZ3FJVmZHaTdqUDFleERSVkVGRlY3ei93YUsrYnRqWHZTalJlRTRIemhQ?=
 =?utf-8?B?WmRrdjh6YTUzNjBCcnc0eWRxNURnUnB1ZXRtREtaZm9kZ0dYSStGenJWWlVX?=
 =?utf-8?B?MlR3ZGVhWnc0Rm9yQ082OXR0SkZjN1l6Sk85V2lLVDR4aHh5Rk5xQUhTNXNv?=
 =?utf-8?B?OGZpRWtMYVNjMjBmaVdobDJvR1I1enR6OThGdDBReXdzQ3lnaDhROC81Qnp0?=
 =?utf-8?B?Sy8rRWdKWFQ3QjBGTEg5Um5VVlRUNDdyQldqcEF3aHNNMEZqQ1RveTMyRVFC?=
 =?utf-8?B?U05ZQitMQkQ2cVI3cDlSZUlqOUlPU3FIcElqVmdQb0JLRDN1QVZwKzJOSjlw?=
 =?utf-8?B?cXdsQVZxZzBUaHZldzdqWUVYcXdSdXZBdTlOdXVvTUR0WGlCSGZ6QjBPeVVl?=
 =?utf-8?B?TkorUEZvM01vUDZJWEtkRElCcVJ1VkhVTTBlcHZiQkdCVndHby9xbkFBd3o0?=
 =?utf-8?B?ejdkQUJOQ3RyTlhVUU1qMVRLYWxzSW9odDBtWXJUdWl4WGhxcHRrQXYrNXFo?=
 =?utf-8?B?WmdsazQ5WEdOa05VZ255M09FSHFhN2kwK3Bjc1U1RjZ6ZWh2Q085LzRGVnZv?=
 =?utf-8?B?MFM4eCtRT0k1Tjk1Q09TZGVRQUlwNnFZbWYySU81UDNtLzJTdlJFR2IzVm50?=
 =?utf-8?B?RUNCWlFPbWhnSUNpamZTdmFzTko5azYyUWZnV1QrdXN2Mm9qWmhjR0c0RDFF?=
 =?utf-8?B?NTBqTG1YYVl3MDd1ZWZQVjJXaGJtNm1ucjk4aXUzTU9henBoRW05dzgvYTU1?=
 =?utf-8?B?U3gwQlRiTnpDZThXcWQzVlIyWkp5VHlhczBJL3pqQ3B2QmdSdFdza1lqUUZo?=
 =?utf-8?B?L3pRZ3FJaVZ4U2JqT0tLcUNkdlBCemVwMW14a0NLNDAxYkh6WnF0Mmg2R2R5?=
 =?utf-8?Q?aeGdaaE5WTm6qa+S7SSap8I=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3cc9e3e-9877-45c1-ef45-08d9f6633d4d
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 00:27:14.8472
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M7nUeNBqb9HDMAFJgzz/8lH2qWNpvzEM87+AUx0wHeUABihYPM4QzmjMYDSyx1B5BAuzB/0XJDT6Rpi+EUxbcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2372
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10266 signatures=677939
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 malwarescore=0 phishscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202230000
X-Proofpoint-ORIG-GUID: dqjgoNaIoV_C7ncI2ClS7pUOpY2R1uAa
X-Proofpoint-GUID: dqjgoNaIoV_C7ncI2ClS7pUOpY2R1uAa
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/22/22 03:27, Miaohe Lin wrote:
> Use helper macro __ATTR_RW to define HSTATE_ATTR to make code more
> clear. Minor readability improvement.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>  mm/hugetlb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Thanks!

I should have noticed and changed that when adding HSTATE_ATTR_WO.

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz

> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 1f0cca036f7f..c0405f3c8413 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -3498,8 +3498,7 @@ static int demote_pool_huge_page(struct hstate *h, nodemask_t *nodes_allowed)
>  	static struct kobj_attribute _name##_attr = __ATTR_WO(_name)
>  
>  #define HSTATE_ATTR(_name) \
> -	static struct kobj_attribute _name##_attr = \
> -		__ATTR(_name, 0644, _name##_show, _name##_store)
> +	static struct kobj_attribute _name##_attr = __ATTR_RW(_name)
>  
>  static struct kobject *hugepages_kobj;
>  static struct kobject *hstate_kobjs[HUGE_MAX_HSTATE];