Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Feb 2022 18:36:51 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Krishna Yarlagadda <kyarlagadda@nvidia.com>
Cc:     thierry.reding@gmail.com, jonathanh@nvidia.com,
        linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org,
        skomatineni@nvidia.com, ldewangan@nvidia.com, robh+dt@kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        p.zabel@pengutronix.de
Subject: Re: [PATCH v2 4/5] spi: tegra210-quad: add acpi support
Message-ID: <YhUtQ/8Kgcx4OY4S@sirena.org.uk>
References: <20220222175611.58051-1-kyarlagadda@nvidia.com>
 <20220222175611.58051-5-kyarlagadda@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2dt5HGRedkKEQZId"
Content-Disposition: inline
In-Reply-To: <20220222175611.58051-5-kyarlagadda@nvidia.com>
Precedence: bulk


--2dt5HGRedkKEQZId
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 22, 2022 at 11:26:10PM +0530, Krishna Yarlagadda wrote:

> Add ACPI ID for Tegra QUAD SPI. Switch to common device property calls.
> Skip clock calls that are not updated in ACPI boot.

> @@ -1377,6 +1400,8 @@ static int __maybe_unused tegra_qspi_runtime_suspen=
d(struct device *dev)
>  	struct spi_master *master =3D dev_get_drvdata(dev);
>  	struct tegra_qspi *tqspi =3D spi_master_get_devdata(master);
> =20
> +	if (has_acpi_companion(tqspi->dev))
> +		return 0;
>  	/* flush all write which are in PPSB queue by reading back */
>  	tegra_qspi_readl(tqspi, QSPI_COMMAND1);

As well as clock stuff this is also skipping flushing of pending writes
- is that intentional?  It's not called out in the changelog and seems
like something that could cause issues if someone runs on a system where
the firmware does implement runtime suspend.

--2dt5HGRedkKEQZId
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIVLUIACgkQJNaLcl1U
h9B91Af/V0Mz9zlkixlXsHowRNpP67V4tM0YmpfXrzB6Y1fCXNS+xNOoCC7CqsD7
tkhG66C+UKCmENOKOso53ErNiSYDswdKQdawM8fEmRI0Bm2CNhyG6JayCeCmsgCx
v2AMcW2Kw0pNAWJzR0SqJzreyT7A+zc4IrSt0dq45CFesYbwiayeEX11vzhzEL6z
8WZwfG1N4bCKWQnt/Fhu7unGmM42hIuWB3dXKm7XZP3+3QxxwUNYOPE6ZSUn6Vyz
wS9jxAknsbiNB7Nd8fayHaQrBF8w3Tw6Kg4oNLAFx198yz87DvcCUUlr2c2W/zgs
WRAEZKb3NizNWeBI6yHA0py8jXNEvQ==
=n2OX
-----END PGP SIGNATURE-----

--2dt5HGRedkKEQZId--