Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Krishna Yarlagadda <kyarlagadda@nvidia.com>
To:     Mark Brown <broonie@kernel.org>
CC:     "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        Sowjanya Komatineni <skomatineni@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>
Subject: RE: [PATCH v2 4/5] spi: tegra210-quad: add acpi support
Thread-Topic: [PATCH v2 4/5] spi: tegra210-quad: add acpi support
Thread-Index: AQHYKBWa+O2JqvcM5kOPguoIZ3KOyqyf5iWAgADIESA=
Date:   Wed, 23 Feb 2022 06:32:56 +0000
Message-ID: <DM4PR12MB57693F28A727964ED67BBEB4C33C9@DM4PR12MB5769.namprd12.prod.outlook.com>
References: <20220222175611.58051-1-kyarlagadda@nvidia.com>
 <20220222175611.58051-5-kyarlagadda@nvidia.com>
 <YhUtQ/8Kgcx4OY4S@sirena.org.uk>
In-Reply-To: <YhUtQ/8Kgcx4OY4S@sirena.org.uk>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6gZdQaQOdB+PNqkHaFT6+kOc/b1Z9kwmG/M+HWOa8iUq+MaNYQOmCpFJibPq?=
 =?us-ascii?Q?kRz+5xeSRg8cKGaPky37SdN9166W7eK3YeRBA370ZPq0PlUhfG9svxy049bu?=
 =?us-ascii?Q?HpLTU55kE1x8D2yyu7J9hksFhve5YfcUbusCH5Je0prrDkkzob8gEB55w8J+?=
 =?us-ascii?Q?ZeCgzFBHpJZ4TNal0Q3jjFCaPyVKNLxPEvXAwsHoWxywK3sT7hLc4g9i32L5?=
 =?us-ascii?Q?bR5hvWvdyFdQCLkOgdbiZcm2fr7Yem3ftfE2s5IOCfwGWMouhlMfj/NcmvH1?=
 =?us-ascii?Q?xOdbh1KbTeeI5U4Hp9KzmmXK6bngmP9VDPdll0SoRpViZWzlnJ68PDQgxIko?=
 =?us-ascii?Q?uq6HNz3WJer1fFzZcbpfTSF1XIBDwDLFi3J641HPVjVGPaa86bylsvOjWHOz?=
 =?us-ascii?Q?+cYVYtjPt3sjaC8rc5sQJwr68c0rGKCmn3Kp8Z5PGLU9IQmVK6nN0zmyVIKL?=
 =?us-ascii?Q?xWcbCf6tZcP4Lm2xvohnvwjjfeuXmkd9fy2tJhJTwLtLiE223RIGjPAGGPJR?=
 =?us-ascii?Q?2BlsKXiiafIS/BffsEuLbSXqGA3Adzr+ZEFnWjv6n+BBEvO0ORNOF6PyD5Mu?=
 =?us-ascii?Q?+ust1GCHs69yq/NiTRetaqWA+SzlDv7j8sXMLGSDVSGgVJ4/7MhskNzfZdle?=
 =?us-ascii?Q?Dr8izgt6q94UZtC5EeYZGzXeubKAyKoxkiRQOuSBjJS7H54WeyvrDgxZXMKB?=
 =?us-ascii?Q?TrVKEAlq7Qx9bFd1WrxtnEqyuYNS1NdzTavEM+OGTK2IGgBGJv5nVzUBTphv?=
 =?us-ascii?Q?w/VztIejsGRKfgOFVmB/ODWoYeigqqkNkbjq+JwIxjFzixC52BnaBVQoQu7+?=
 =?us-ascii?Q?DqwvX6MJeSDC9xRiBK6NfRHiOqm3cDba3UKy4yhQ1i1fyCG0r4x7w9VkYs2l?=
 =?us-ascii?Q?EUxxd+d9bYfjSpny1REPgJg9JtOvFRlajCgjglKlVOa8omzfGDzT6kL9sajo?=
 =?us-ascii?Q?hAf8iMeJ5spmxFGxXAS21dR3087nzcgEAOIfrk8nHncqn1uV8JqrgWypHN8z?=
 =?us-ascii?Q?hp154Pp9ZVZ8+m0no64mgs+R7D8Vf4nihdyX1XzBDJeXVCkyDRiLLx7wcXlu?=
 =?us-ascii?Q?Tx+7Do4Ng/OB3d31sT8HwhRwDvgPeguMxrrlhjN6mh8K9s7vjHMmEDKcIskO?=
 =?us-ascii?Q?jGv/oYVzmKkeXhL/QSY416mDDp9qebKV8RHP3bHxc7zvMlPPDPkZHiPDvUwe?=
 =?us-ascii?Q?w+GpKExBRB+la6siAcZrizjthe9HiN09Rd7JDyJBHPVk4LrY8mHuuK0HDq7w?=
 =?us-ascii?Q?td+nkb2mcw2btFJCbpRSg4zk9lH1DOyUk2op8waDW5oI/+iObX/gS3QZPkQq?=
 =?us-ascii?Q?XVsckaM4usoDYOCT6NkvpDYjEUGTLF420EbjR8phbGoA9KkKV2cRdutGKY9F?=
 =?us-ascii?Q?Olm5+iKINPCRnOzWhI+n0nZHhfcGj5/ikrFs8kwWzHXbLvk2sF7NzY5jFw1w?=
 =?us-ascii?Q?JkLC8f9Xr4MPTOYUJFzeH+hMYjGBIRksLJV5W/g26q8vxtym30hCDxaLwRwT?=
 =?us-ascii?Q?H4opKAqGugyBLPLFZkpq9yCXwsWvkMpos1En7D9kMiuPmiC89ugAbnQ4ArQs?=
 =?us-ascii?Q?n4UxBDVPyRHN9OXRHMIzRTiTR28DE0DY1mMKPgt8aHnhG75xJb0b4NqdMvvR?=
 =?us-ascii?Q?WT0I5nlGCvu/NRaCS+hbqx4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5769.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f564733-0d80-4a0d-5c57-08d9f696541d
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2022 06:32:56.5748
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mANbpjbBDMRbjRzbOE0t6MAqloshvD67ky0KnQLh45tWmtQh0YFSlzlRJyLzynpP6yC7XRj45+IFeDigH34O9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5956
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: 23 February 2022 00:07
> To: Krishna Yarlagadda <kyarlagadda@nvidia.com>
> Cc: thierry.reding@gmail.com; Jonathan Hunter
> <jonathanh@nvidia.com>; linux-spi@vger.kernel.org; linux-
> tegra@vger.kernel.org; Sowjanya Komatineni
> <skomatineni@nvidia.com>; Laxman Dewangan
> <ldewangan@nvidia.com>; robh+dt@kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> p.zabel@pengutronix.de
> Subject: Re: [PATCH v2 4/5] spi: tegra210-quad: add acpi support
>=20
> On Tue, Feb 22, 2022 at 11:26:10PM +0530, Krishna Yarlagadda wrote:
>=20
> > Add ACPI ID for Tegra QUAD SPI. Switch to common device property
> calls.
> > Skip clock calls that are not updated in ACPI boot.
>=20
> > @@ -1377,6 +1400,8 @@ static int __maybe_unused
> tegra_qspi_runtime_suspend(struct device *dev)
> >  	struct spi_master *master =3D dev_get_drvdata(dev);
> >  	struct tegra_qspi *tqspi =3D spi_master_get_devdata(master);
> >
> > +	if (has_acpi_companion(tqspi->dev))
> > +		return 0;
> >  	/* flush all write which are in PPSB queue by reading back */
> >  	tegra_qspi_readl(tqspi, QSPI_COMMAND1);
>=20
> As well as clock stuff this is also skipping flushing of pending writes
> - is that intentional?  It's not called out in the changelog and seems li=
ke
> something that could cause issues if someone runs on a system where
> the firmware does implement runtime suspend.
Runtime suspend is not enabled with ACPI firmware. Converted compiler flag =
in v1 to runtime check.
We must add more changes like setting DPM flags for runtime pm support with=
 ACPI.
Can take this as part of a different series.