Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e5c0cfdf-315c-836c-8be7-9f952ac0cd9e@oppo.com>
Date:   Wed, 23 Feb 2022 10:58:12 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] riscv: mm: Remove the copy operation of pmd
Content-Language: en-US
To:     Palmer Dabbelt <palmer@dabbelt.com>
Cc:     Paul Walmsley <paul.walmsley@sifive.com>,
        "aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
        "jszhang@kernel.org" <jszhang@kernel.org>,
        "alexandre.ghiti@canonical.com" <alexandre.ghiti@canonical.com>,
        "wangkefeng.wang@huawei.com" <wangkefeng.wang@huawei.com>,
        "zhengqi.arch@bytedance.com" <zhengqi.arch@bytedance.com>,
        "ebiederm@xmission.com" <ebiederm@xmission.com>,
        "liushixin2@huawei.com" <liushixin2@huawei.com>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <mhng-98c8a68c-ecb2-4db1-ab3e-3a35d5e764d0@palmer-ri-x1c9>
From:   hanchuanhua <hanchuanhua@oppo.com>
In-Reply-To: <mhng-98c8a68c-ecb2-4db1-ab3e-3a35d5e764d0@palmer-ri-x1c9>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cE91M0FrenpBeXUxRC9QK21BTXRvUTFCUEhqYUxPdWhYYm1Ub0hrZDB0RXJ3?=
 =?utf-8?B?anpyRXp1SWFXZjRlL1hkVzVjaWtpdWdOMy92Y0RhZkt4ZXVnL1I0amNVd0dG?=
 =?utf-8?B?KzNYVGh1MHQ2NTRhYU02c0xPY3ZaVEI1OUxHbXFabnFuS0s5YXlka1ZuVHlJ?=
 =?utf-8?B?eXQrcWgzSzcrSFJEWXlPWFhTTnY1Z2xHYnQ3dWdXOG01VkZTZ3JZNk1hVTBu?=
 =?utf-8?B?eXppS1kwTEVCYXJOcE9YdzVhVld2S2p2eU5pL1NMakxaT1VXNWVWd2FZdk1i?=
 =?utf-8?B?WHpmQzI3ckQ5Q3FlOHB4OWhkV3cveFNPN1BwaENYMWNHMnpINm5aV253aVlt?=
 =?utf-8?B?NFh5OFVxajdwa016YjZqQVduZzVmTUpGN3pVNzFiSDdDYjltcG9JTnVhR1Fa?=
 =?utf-8?B?RnYvWFJFVXRaRWRLaExBcVVZSUpaNVYycnl1TG9GNGJHeGJVZFk3TjdwbCtH?=
 =?utf-8?B?TVJpc3RydjBjMVU1cUc0NGlIc0VQTzZqYUtmM2pJVXlHTGtxT0cxdkZHeCtU?=
 =?utf-8?B?MkNUcDh3dlpZb0xkM3R6bEEwQzhnR2had29RbTdmUHQraHRFR2NMbEdQbDM1?=
 =?utf-8?B?Tk9HOFU5TUt3Q3F5YUROOFQ3WFFDSU9WRWRSN0FXTHBEVmRlNXBJRUN6VFVZ?=
 =?utf-8?B?NmZTcGNDOVNYOE84SWE1NHNpeEhTMElZdDY1eUVNYm51bHVmcllydDJzUFdk?=
 =?utf-8?B?ajRpbzRwd3h4L25SL2d3azBWMHpneGE5ZTgzckNYaGx0cTNSK29VcW1qSy9h?=
 =?utf-8?B?Q2RMcWJvYzBTV0YvSnJOT3E1dkNsb3pWQ0dOOWRKRktLMjZYV084NmNISVVF?=
 =?utf-8?B?OFl0WmNGZTdSbExHQlZyRmFkcWx4K0w4MTJHOCtTaDM2YTM0SlhweWFUUlFv?=
 =?utf-8?B?d1A2ZTV2UmtKdFdVNS9JVzdMMXRrb0xXQXpZd3BaOHZ1Vml2a1hXTmRYV0xR?=
 =?utf-8?B?SGQzRmphcVFudGRuSnJKZ0dJdG9ubWo4WGpRdHlYS1gxa2lQMTRkdGJGb1pF?=
 =?utf-8?B?bENRVTZ3YlFvRGJETU5QMXBiUjV3T2dOZDU1bUFRckRPRUF2aFFXU2o5bnVq?=
 =?utf-8?B?VUhMQzV4NFdWRHBsQW0zRWl3WGJaSXJTejNSRHZSTkRDemlQVGRNMzdaMm5q?=
 =?utf-8?B?Q3NTS0NQYTdleUpLQ1VHdXYwTjNyRUVhK1hPZWZhMEtrWFNweGtjcHR5NDI5?=
 =?utf-8?B?MU93VnFWMENRK1p2OVY0VU55ejR6Y3NrR080U21pQUdGMCt1YXJ6WWtLQXZN?=
 =?utf-8?B?YUZRa3h0SnhmOWNXNk5GcUhIcVNlMDFyZGNOMmpmTW50amV0RjlEMEVnL0RX?=
 =?utf-8?B?cVJETDVSQUZjME8vUEhtVkxpZEQ1cE82emd1VHhSSVBmL1Z4QnErUXZoRWtx?=
 =?utf-8?B?ZnRLSVd3US9uaU5iVXJqSXh1ZHVNVGQxNTBQV2NmQWZnQUZHM1BRR1NVdkkv?=
 =?utf-8?B?QlJpdG9telNIUktvMlEyMDZwTjFMZGVaVjJNbnMrcVFTbFp0dTFUaHRzQTV2?=
 =?utf-8?B?eE5HNi9oekswOG82S1kzUTcyakVyazJsY0o4NkFCZkg0K2puS2J3Sk9rcDNG?=
 =?utf-8?B?M3ZUSlpzMjZFcXZObFJ0ZThKaGNwR3NudVpJK0wvS0x3dXZPSHpYbmM1STZE?=
 =?utf-8?B?WWxKaURtOVA1WmRYcDZ2a1BOZWcwSGdwRTZHSTJZSTFyVGk1YjNjOENkUTdn?=
 =?utf-8?B?VG4wZmtKZjNUVE9tK0w4N29pZ2k0SDFuSFkrQW1JK3g3L1RhL1NxOUxhYnlG?=
 =?utf-8?B?STFxS0hPK1N1ZFNvZUNqVk9RclNlaDI5aWRTVDh3dnQrUUhMMmpTaDZOVE5G?=
 =?utf-8?B?eldWL1VRK1FOdUlLWk5pQ0lPaTlrZHlIT1A5bENtRjZjcHBUeXJhOWh2TFB6?=
 =?utf-8?B?TFhWTFhjNWxFKytqY0xnd0lESE5QUFp2bmtDZVFBN0g2UUhVUVZqUVk4bC9Z?=
 =?utf-8?B?TmJka2ZEcGN2NmdManl0VGtFTEhGREVhYnJYWmVtTUVHRWRPbmR2Q042VG16?=
 =?utf-8?B?MkdzUnhXbHh2WFFVR1hLQW9CRVRMVU9PYi9VMDlDYkwrUDg5bkM3RG0zaVVY?=
 =?utf-8?B?c3hQQmdVOFlLUWpsRXdwZERzcnlGUDNFckhweUp2SWIrMjBPbXJlYnFDNjhm?=
 =?utf-8?B?RHBYSEwzTXRLUXpvKzBwNDNRUEpVcnpuKzl3WlBOc1hrcmQ0SmdPbEw2OTF2?=
 =?utf-8?Q?lZNu51xMlAqRKSZQRg42rGA=3D?=
X-OriginatorOrg: oppo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2abfac51-a6df-406d-7d6b-08d9f67855f1
X-MS-Exchange-CrossTenant-AuthSource: SG2PR02MB5379.apcprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 02:58:15.1471
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gTZV0HqZZnceF8M7y0Hgc9AJRIKffaLwp1tzILvgb3d07NzfKUJ1G8eXZXBE+nw6OBoOda9uVkEBrH8sv6Uj3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR02MB5151
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022/2/23 5:25, Palmer Dabbelt wrote:
> On Thu, 27 Jan 2022 02:06:22 PST (-0800), hanchuanhua@oppo.com wrote:
>> Since all processes share the kernel address space,
>> we only need to copy pgd in case of a vmalloc page
>> fault exception, the other levels of page tables are
>> shared, so the operation of copying pmd is unnecessary.
>>
>> Signed-off-by: hanchuanhua <hanchuanhua@oppo.com>
>> ---
>>   arch/riscv/mm/fault.c | 10 +++-------
>>   1 file changed, 3 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/riscv/mm/fault.c b/arch/riscv/mm/fault.c
>> index 4e9efbe..40694f0 100644
>> --- a/arch/riscv/mm/fault.c
>> +++ b/arch/riscv/mm/fault.c
>> @@ -102,9 +102,9 @@ static inline void bad_area(struct pt_regs *regs, st=
ruct mm_struct *mm, int code
>>   static inline void vmalloc_fault(struct pt_regs *regs, int code, unsig=
ned long addr)
>>   {
>>          pgd_t *pgd, *pgd_k;
>> -       pud_t *pud, *pud_k;
>> -       p4d_t *p4d, *p4d_k;
>> -       pmd_t *pmd, *pmd_k;
>> +       pud_t *pud_k;
>> +       p4d_t *p4d_k;
>> +       pmd_t *pmd_k;
>>          pte_t *pte_k;
>>          int index;
>>          unsigned long pfn;
>> @@ -132,14 +132,12 @@ static inline void vmalloc_fault(struct pt_regs *r=
egs, int code, unsigned long a
>>          }
>>          set_pgd(pgd, *pgd_k);
>>
>> -       p4d =3D p4d_offset(pgd, addr);
>>          p4d_k =3D p4d_offset(pgd_k, addr);
>>          if (!p4d_present(*p4d_k)) {
>>                  no_context(regs, addr);
>>                  return;
>>          }
>>
>> -       pud =3D pud_offset(p4d, addr);
>>          pud_k =3D pud_offset(p4d_k, addr);
>>          if (!pud_present(*pud_k)) {
>>                  no_context(regs, addr);
>> @@ -150,13 +148,11 @@ static inline void vmalloc_fault(struct pt_regs *r=
egs, int code, unsigned long a
>>           * Since the vmalloc area is global, it is unnecessary
>>           * to copy individual PTEs
>>           */
>> -       pmd =3D pmd_offset(pud, addr);
>>          pmd_k =3D pmd_offset(pud_k, addr);
>>          if (!pmd_present(*pmd_k)) {
>>                  no_context(regs, addr);
>>                  return;
>>          }
>> -       set_pmd(pmd, *pmd_k);
>>
>>          /*
>>           * Make sure the actual PTE exists as well to
> This looks good, but "Signed off by" lines are supposed to have real
> names associated with them and this looks like a handle to me.  There
> also seems to be something broken with the email, as this is causing git
> to blow up, but for a small patch like this that's OK as I can resurrect
> it by hand.
>
> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com> # aside from the name
>
> Please send a v2 with the proper Signed off by line, as that's not
> something I'm supposed to just fix up myself.
>
> Thanks!

First of all, thank you for your review and reply. I don't quite
understand what's wrong with the line "Signed off by"?

Thanks!

________________________________
OPPO

=E6=9C=AC=E7=94=B5=E5=AD=90=E9=82=AE=E4=BB=B6=E5=8F=8A=E5=85=B6=E9=99=84=E4=
=BB=B6=E5=90=AB=E6=9C=89OPPO=E5=85=AC=E5=8F=B8=E7=9A=84=E4=BF=9D=E5=AF=86=
=E4=BF=A1=E6=81=AF=EF=BC=8C=E4=BB=85=E9=99=90=E4=BA=8E=E9=82=AE=E4=BB=B6=E6=
=8C=87=E6=98=8E=E7=9A=84=E6=94=B6=E4=BB=B6=E4=BA=BA=E4=BD=BF=E7=94=A8=EF=BC=
=88=E5=8C=85=E5=90=AB=E4=B8=AA=E4=BA=BA=E5=8F=8A=E7=BE=A4=E7=BB=84=EF=BC=89=
=E3=80=82=E7=A6=81=E6=AD=A2=E4=BB=BB=E4=BD=95=E4=BA=BA=E5=9C=A8=E6=9C=AA=E7=
=BB=8F=E6=8E=88=E6=9D=83=E7=9A=84=E6=83=85=E5=86=B5=E4=B8=8B=E4=BB=A5=E4=BB=
=BB=E4=BD=95=E5=BD=A2=E5=BC=8F=E4=BD=BF=E7=94=A8=E3=80=82=E5=A6=82=E6=9E=9C=
=E6=82=A8=E9=94=99=E6=94=B6=E4=BA=86=E6=9C=AC=E9=82=AE=E4=BB=B6=EF=BC=8C=E8=
=AF=B7=E7=AB=8B=E5=8D=B3=E4=BB=A5=E7=94=B5=E5=AD=90=E9=82=AE=E4=BB=B6=E9=80=
=9A=E7=9F=A5=E5=8F=91=E4=BB=B6=E4=BA=BA=E5=B9=B6=E5=88=A0=E9=99=A4=E6=9C=AC=
=E9=82=AE=E4=BB=B6=E5=8F=8A=E5=85=B6=E9=99=84=E4=BB=B6=E3=80=82

This e-mail and its attachments contain confidential information from OPPO,=
 which is intended only for the person or entity whose address is listed ab=
ove. Any use of the information contained herein in any way (including, but=
 not limited to, total or partial disclosure, reproduction, or disseminatio=
n) by persons other than the intended recipient(s) is prohibited. If you re=
ceive this e-mail in error, please notify the sender by phone or email imme=
diately and delete it!