Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1645454462-27867-1-git-send-email-quic_akhilpo@quicinc.com>
In-Reply-To: <1645454462-27867-1-git-send-email-quic_akhilpo@quicinc.com>
From:   Rob Clark <robdclark@gmail.com>
Date:   Tue, 22 Feb 2022 17:00:54 -0800
Message-ID: <CAF6AEGtF440x7Sho03ujeL6J4XXqOrF_NcqiQXGTewwLM5SObA@mail.gmail.com>
Subject: Re: [PATCH 0/5] Support 7c3 gpu SKUs
To:     Akhil P Oommen <quic_akhilpo@quicinc.com>
Cc:     freedreno <freedreno@lists.freedesktop.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS 
        <devicetree@vger.kernel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Abhinav Kumar <quic_abhinavk@quicinc.com>,
        Andy Gross <agross@kernel.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        Douglas Anderson <dianders@chromium.org>,
        Jonathan Marek <jonathan@marek.ca>,
        Jordan Crouse <jordan@cosmicpenguin.net>,
        Rob Herring <robh+dt@kernel.org>, Sean Paul <sean@poorly.run>,
        Stephen Boyd <swboyd@chromium.org>,
        Vladimir Lypak <vladimir.lypak@gmail.com>,
        Yangtao Li <tiny.windzz@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 21, 2022 at 6:41 AM Akhil P Oommen <quic_akhilpo@quicinc.com> wrote:
>
> This series supercedes [1]. Major change in this series is that it is now
> optional to include a gpu name in the gpu-list. This helps to avoid the
> confusion when we have different SKUs with different gpu names. And also
> I am pretty happy that the overall changes are smaller now.
>
> [1] https://patchwork.freedesktop.org/series/99048/
>

Other than a nit in 2/5, this looks good to me

BR,
-R

>
> Akhil P Oommen (5):
>   drm/msm: Use generic name for gpu resources
>   drm/msm/adreno: Generate name from chipid for 7c3
>   drm/msm/a6xx: Add support for 7c3 SKUs
>   drm/msm/adreno: Expose speedbin to userspace
>   arm64: dts: qcom: sc7280: Support gpu speedbin
>
>  arch/arm64/boot/dts/qcom/sc7280.dtsi       | 46 ++++++++++++++++++++++++++++++
>  drivers/gpu/drm/msm/adreno/a6xx_gpu.c      | 18 ++++++++++--
>  drivers/gpu/drm/msm/adreno/adreno_device.c |  1 -
>  drivers/gpu/drm/msm/adreno/adreno_gpu.c    | 35 +++++++++++++++++++----
>  drivers/gpu/drm/msm/adreno/adreno_gpu.h    |  3 ++
>  drivers/gpu/drm/msm/msm_gpu.c              |  4 +--
>  6 files changed, 96 insertions(+), 11 deletions(-)
>
> --
> 2.7.4
>