Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Krishna Yarlagadda <kyarlagadda@nvidia.com>
To:     Mark Brown <broonie@kernel.org>
CC:     "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        Sowjanya Komatineni <skomatineni@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>
Subject: RE: [PATCH v2 5/5] spi: tegra210-quad: combined sequence mode
Thread-Topic: [PATCH v2 5/5] spi: tegra210-quad: combined sequence mode
Thread-Index: AQHYKBWjj4LbNoGwBkCe53Tr2h3kVayf53KAgADHQ5A=
Date:   Wed, 23 Feb 2022 06:34:44 +0000
Message-ID: <DM4PR12MB5769CB86A0348A669647D0F3C33C9@DM4PR12MB5769.namprd12.prod.outlook.com>
References: <20220222175611.58051-1-kyarlagadda@nvidia.com>
 <20220222175611.58051-6-kyarlagadda@nvidia.com>
 <YhUuW+MlgeQRTVZB@sirena.org.uk>
In-Reply-To: <YhUuW+MlgeQRTVZB@sirena.org.uk>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/MCi2vy9R3cWx4ftZVIzZGDFvqi/CUgp/gIBfokobY49L2sxWNfPpJFGB2Hr?=
 =?us-ascii?Q?wIVtR60EHHOIUnjbW8oQe7dy6ocF7MvDXZvdYBDaqoha7A5VFhG0WJo60W6B?=
 =?us-ascii?Q?kNfVcw2Rk3SgHUhJuD0GG8HjMQcQQ6GV9Q8lPWY2ylC7qcL2ofKg1UqwiAn7?=
 =?us-ascii?Q?PguyKsiK3zWydga38WR2o0XjU6P58V/3rpRg70UO8igK9yhLoDnRazwia2nq?=
 =?us-ascii?Q?dB5+5cspIUNuY5T48AEyY7VYYBgnySM9ZpM0RxSKhS35IWJM4tZtqGxYxVAe?=
 =?us-ascii?Q?mNcivvN0cGP+vUT+sOoBw1GMlvC/vz39wzJpu+lR2ZCMGlM2832palXsHPSW?=
 =?us-ascii?Q?z89JuGXyS0yK29SR403S9dobgAeuEPq638bAjhGGaud3djfd7HD3QjFNQfJB?=
 =?us-ascii?Q?51rR/GU2fapn3f9Yc33nXxFaElcTVgqqvdgOKH8+abBsQ/b175H1eEJ3P7SM?=
 =?us-ascii?Q?0FGH+uVk1Xzn4LIhLAWEeh67NgGWj6vV36NsWyIdP+YSw0Ry6gTz8EEYGHGB?=
 =?us-ascii?Q?myl5bRl7QZpg7zL4jm+gqB44Ryd7kcBduwKIPPetsP/dskQRa/OwRJv6oEeP?=
 =?us-ascii?Q?lf/g5pO3rt/SoRHxYLC45a8GaRAPRsGHpT9mlk07EyUkUK6k1EuHFHwQH4uo?=
 =?us-ascii?Q?EtiRLBkT3WDusE80qX11V6+C9ZXRbcuQk3Prcz9fbGoDG179Uy0u1D9WJ24V?=
 =?us-ascii?Q?DaWdmCqjbC8X3msDHvvXV+av4uYJC/1XM9pfPkdTu/9HWgWB9wnFzZeMrewq?=
 =?us-ascii?Q?o2fGAIWyfhL1+3mQaPDVWWMGzD4GbTmUd9t3Q+3oNJk89kGwwL+xzZ3bgkON?=
 =?us-ascii?Q?f9NQgMLvnIKDEAN1hWzTGXNz6INXzyegmJUDEXDkcgfgiLJTWPv1hhXtK624?=
 =?us-ascii?Q?LdYHkA5U01+hivcsTwzDn6gGP6oUOhtSHbF1AR9orf+JOPyoDJ7GXJrpu0jd?=
 =?us-ascii?Q?w4ZE8iIvYQBIJWvdrjQSBFtfUvnEY1tK+aL01IpCiNKuat3RSnlUfJabvRA5?=
 =?us-ascii?Q?yr24a1HSlI5SbqMQnBHPMM/VnP/jBro/HHmnrw/HhyqywObq0RwJs4gZcrZl?=
 =?us-ascii?Q?xq7K5yWA3vh7uEXlZzRYLmoTYJiz4vhBpHaAcDKaqkr1vbR6uvaTd7lif5GI?=
 =?us-ascii?Q?Z+kS0I6beRNjN4L7HukF+GCRcM2E0rATB46/rG6qT6MW5165NxSixQyjt9gY?=
 =?us-ascii?Q?KXWSXCd+GGz+4eWC06RGvLWLbSBnDQ3Xn2actLqZePi/wuouOoThIOb/eQbT?=
 =?us-ascii?Q?D3JD7LphpcOvDikhJ8CW6OxmBKXatGl1Mp7K0TAopZxSfBhtOguyKbfE3BKi?=
 =?us-ascii?Q?KivD/ULATWK8YOwYhrs6EUw5EABtsTxh+Xj4dV5evv9ZK0DzuSBeW+ykTO4x?=
 =?us-ascii?Q?oe2FRovn5GlJ7uHaRQgf+299z6fFhg3taB5abmKpZlBgksZQ8g+KpSxui772?=
 =?us-ascii?Q?mu5cYe1gyMyXKny6r9Fb+XOXnbQ2hb0TUGpWVlwnfYYQJMIu8g0eOpWkSuFH?=
 =?us-ascii?Q?RiSIIzYQxJjfVE5d4y4NrkueE3VnzNQY5aJmHoA/W5eUvEQjj02fPObd2QrJ?=
 =?us-ascii?Q?GM2V7v3glgHhyFOaXsAzvDdz74+9SKBfiOUbbA2lCLemqkxw6F4rZt0N0r1K?=
 =?us-ascii?Q?mBT6a6W0Gn1NHWbGLqyfzfE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5769.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 220d7fe8-22ff-403f-6451-08d9f6969432
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2022 06:34:44.0243
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yWf4OTMhdep6LIYXwXTcVe2zl18GA7b1Y84Uv/NnWziT4B753hzKQkQd88nlnVgMlePlmEi6ygWUfxt4o/Dbkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3406
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: 23 February 2022 00:12
> To: Krishna Yarlagadda <kyarlagadda@nvidia.com>
> Cc: thierry.reding@gmail.com; Jonathan Hunter
> <jonathanh@nvidia.com>; linux-spi@vger.kernel.org; linux-
> tegra@vger.kernel.org; Sowjanya Komatineni
> <skomatineni@nvidia.com>; Laxman Dewangan
> <ldewangan@nvidia.com>; robh+dt@kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> p.zabel@pengutronix.de
> Subject: Re: [PATCH v2 5/5] spi: tegra210-quad: combined sequence
> mode
>=20
> On Tue, Feb 22, 2022 at 11:26:11PM +0530, Krishna Yarlagadda wrote:
>=20
> > +	val =3D tegra_qspi_readl(tqspi, QSPI_GLOBAL_CONFIG);
> > +	val |=3D QSPI_CMB_SEQ_EN;
> > +	tegra_qspi_writel(tqspi, val, QSPI_GLOBAL_CONFIG);
>=20
> I notice that nothing seems to clear QSPI_CMB_SEQ_EN - is that self
> clearing or something?
Need a change in non-combined sequence code to reset this.
Will add the change in v3