Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220223013529.67335-1-zhuyan34@huawei.com>
In-Reply-To: <20220223013529.67335-1-zhuyan34@huawei.com>
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date:   Tue, 22 Feb 2022 21:06:44 -0800
Message-ID: <CAADnVQKmBoQEG1+nmrCg2ePVncn9rZJX9R4eucP9ULiY=xVGjQ@mail.gmail.com>
Subject: Re: [PATCH] bpf: move the bpf syscall sysctl table to its own module
To:     Yan Zhu <zhuyan34@huawei.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Iurii Zaikin <yzaikin@google.com>,
        Network Development <netdev@vger.kernel.org>,
        bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
        zengweilin@huawei.com, liucheng32@huawei.com,
        Xiaoming Ni <nixiaoming@huawei.com>, xiechengliang1@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 22, 2022 at 5:35 PM Yan Zhu <zhuyan34@huawei.com> wrote:
>
> Sysctl table is easier to read under its own module.

"own module"?
What are you talking about?
It's not "easier to read" and looks like a pointless churn.

> Signed-off-by: Yan Zhu <zhuyan34@huawei.com>
> ---
>  kernel/bpf/syscall.c | 80 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  kernel/sysctl.c      | 71 ----------------------------------------------
>  2 files changed, 80 insertions(+), 71 deletions(-)