Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d49c5648-44d2-5630-fae2-52d182eb74e2@canonical.com>
Date:   Wed, 23 Feb 2022 09:02:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] dt-bindings: arm: qcom: Document sa8540p, sc8180x and
 sc8280xp
Content-Language: en-US
To:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220223034613.3725242-1-bjorn.andersson@linaro.org>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
In-Reply-To: <20220223034613.3725242-1-bjorn.andersson@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23/02/2022 04:46, Bjorn Andersson wrote:
> Add compatibles for the sa8540p automotive, as well as sc8180x and
> sc8280xp compute platforms. Also add compatibles for the ADP devboard,
> the Lenovo Flex 5G, Microsoft Surface Pro X and the sc8280xp QRD.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  .../devicetree/bindings/arm/qcom.yaml         | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index e8b1606bc849..1042f71300af 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -39,8 +39,11 @@ description: |
>          msm8994
>          msm8996
>          sa8155p
> +        sa8540p
>          sc7180
>          sc7280
> +        sc8180x
> +        sc8280xp
>          sdm630
>          sdm660
>          sdm845
> @@ -224,6 +227,18 @@ properties:
>                - google,senor
>            - const: qcom,sc7280
>  
> +      - items:
> +          - enum:
> +              - qcom,sc8180x-primus
> +              - lenovo,flex-5g
> +              - microsoft,surface-prox

How about ordering this enum alphabetically? I think most of other
places in this file is ordered.

> +          - const: qcom,sc8180x
> +
> +      - items:
> +          - enum:
> +              - qcom,sc8280xp-qrd
> +          - const: qcom,sc8280xp
> +
>        - items:
>            - enum:
>                - xiaomi,lavender
> @@ -252,6 +267,11 @@ properties:
>                - qcom,sa8155p-adp
>            - const: qcom,sa8155p
>  
> +      - items:
> +          - enum:
> +              - qcom,sa8540p-adp
> +          - const: qcom,sa8540p
> +
>        - items:
>            - enum:
>                - fairphone,fp4


Best regards,
Krzysztof