Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Feb 2022 09:14:36 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     German Gomez <german.gomez@arm.com>
Cc:     linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        acme@kernel.org, John Garry <john.garry@huawei.com>,
        Will Deacon <will@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] perf arm-spe: Use advertised caps/min_interval as
 default sample_period
Message-ID: <20220223011436.GA414932@leoy-ThinkPad-X240s>
References: <20220221171042.58460-1-german.gomez@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220221171042.58460-1-german.gomez@arm.com>
Precedence: bulk

On Mon, Feb 21, 2022 at 05:10:42PM +0000, German Gomez wrote:
> When recording SPE traces, the default sample_period is currently being
> set to 1 in the perf_event_attr fields, instead of the value advertised
> in '/sys/devices/arm_spe_0/caps/min_interval':
> 
> Before:
> 
> $ perf record -e arm_spe// -vv -- sleep 1
> [...]
>   { sample_period, sample_freq }   1
> [...]
> 
> Use the value from the above sysfs location as a more sensible default
> (it was already being read, but the value not being used)
> 
> After:
> 
> $ perf record -e arm_spe// -vv -- sleep 1
> [...]
>   { sample_period, sample_freq }   1024
> [...]
> 
> Signed-off-by: German Gomez <german.gomez@arm.com>

The change looks good to me:

Reviewed-by: Leo Yan <leo.yan@linaro.org>