Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp526702pxm; Wed, 23 Feb 2022 05:44:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJwhjdSrq9Kkyh+vMsbzvacvCQ6A6BDuszvU+74ejHAYtzyuSio/t+w/xcVUDWYpXShjo4Au X-Received: by 2002:a05:6a00:13aa:b0:4f1:1e5f:1c39 with SMTP id t42-20020a056a0013aa00b004f11e5f1c39mr16833793pfg.24.1645623881044; Wed, 23 Feb 2022 05:44:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645623881; cv=none; d=google.com; s=arc-20160816; b=vZaXO1kIybVEZ+4c4aITRM6df2bu5Hx73y9uc5QljOdFL7jyg9mUeAnNOI/dz3oG0d USbhm+IYVcD8fGZnTpHGqQDEYEqrt7HnlFyC/W4oQsB//WVL/a5V0SUzU0/CInIAbjIB QK9s0mXpibb5+PZNFqKWZTjywnxNzRczNw5X1OWg6Ji/KG12fYfuE9+S238LeYTsshjC KfOuYnhRrIC9ZcBmJWamJYxgYQJmFpDxkvUwgtz837cGZy/Om3S2Q5vDTMcEAcvkUAe+ WNjhM4+fyylB1EnLr4irz5EFDw8LiMwTEFgDS3SpBae9aqxuR0ybPAUWRzarwRZlLUmt Y39A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=iJ/0rQY//4YQjBImUmLq4dySqWY6vLK5gUkPwI0Sqhw=; b=TdVYn7TCusctl2N9OoSupNjzn5fpb6VbXufOHjedtbT0QTHVvby5gG6wY7ZyszlT5L 58gMABi3FA3hDL4EFUt6JS9TpY5j+Bm7eJlS54nkEKW6muzl2OUM7ZXK7ILCSrxMufPK 9LxuUyPWnY5tugxhNBHWDswZuLPWA/NL/Wq/4fJXpcCS8OPcOWi9fSoonKCTgdKKNYhI 7GYGpDHfKHoKHCIaKP9ZTfWi6TChrl9umR/QbZMbHJN+sIwtNT5DZ7ZeLSSOfoXr2rWt tHz6g5LiEWvI5Z7N0TFptUUymDG3IlQaL4L6li2GyQPZxzTM+LOJKYKy6gekC6zXuZ/X V0yA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a4si714011plp.533.2022.02.23.05.44.21; Wed, 23 Feb 2022 05:44:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238742AbiBWHmU (ORCPT + 99 others); Wed, 23 Feb 2022 02:42:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238714AbiBWHmP (ORCPT ); Wed, 23 Feb 2022 02:42:15 -0500 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2B10639156; Tue, 22 Feb 2022 23:41:45 -0800 (PST) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1nMmHJ-0002z4-00; Wed, 23 Feb 2022 08:41:37 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 9B37FC2742; Wed, 23 Feb 2022 08:41:27 +0100 (CET) Date: Wed, 23 Feb 2022 08:41:27 +0100 From: Thomas Bogendoerfer To: Arnd Bergmann Cc: Linus Torvalds , Christoph Hellwig , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, linux@armlinux.org.uk, will@kernel.org, guoren@kernel.org, bcain@codeaurora.org, geert@linux-m68k.org, monstr@monstr.eu, nickhu@andestech.com, green.hu@gmail.com, dinguyen@kernel.org, shorne@gmail.com, deller@gmx.de, mpe@ellerman.id.au, peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com, hca@linux.ibm.com, dalias@libc.org, davem@davemloft.net, richard@nod.at, x86@kernel.org, jcmvbkbc@gmail.com, ebiederm@xmission.com, akpm@linux-foundation.org, ardb@kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org Subject: Re: [PATCH v2 09/18] mips: use simpler access_ok() Message-ID: <20220223074127.GA8287@alpha.franken.de> References: <20220216131332.1489939-1-arnd@kernel.org> <20220216131332.1489939-10-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220216131332.1489939-10-arnd@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_NONE,T_SCC_BODY_TEXT_LINE,T_SPF_HELO_PERMERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 16, 2022 at 02:13:23PM +0100, Arnd Bergmann wrote: > diff --git a/arch/mips/include/asm/uaccess.h b/arch/mips/include/asm/uaccess.h > index db9a8e002b62..d7c89dc3426c 100644 > --- a/arch/mips/include/asm/uaccess.h > +++ b/arch/mips/include/asm/uaccess.h > @@ -19,6 +19,7 @@ > #ifdef CONFIG_32BIT > > #define __UA_LIMIT 0x80000000UL > +#define TASK_SIZE_MAX __UA_LIMIT using KSEG0 instead would IMHO be the better choice. This gives the chance to remove __UA_LIMIT completly after cleaning up ptrace.c Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]