Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220221061954.4822-1-tangmeng@uniontech.com>
In-Reply-To: <20220221061954.4822-1-tangmeng@uniontech.com>
From:   Doug Anderson <dianders@chromium.org>
Date:   Tue, 22 Feb 2022 09:30:27 -0800
Message-ID: <CAD=FV=UN0fCc4TnUj_+sHX5ap9JkBBVR+pTzV8vssZDxfao9Hw@mail.gmail.com>
Subject: Re: [PATCH] kernel/debug: remove unnecessary CONFIG options
To:     tangmeng <tangmeng@uniontech.com>
Cc:     Jason Wessel <jason.wessel@windriver.com>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        kgdb-bugreport@lists.sourceforge.net,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Sun, Feb 20, 2022 at 10:20 PM tangmeng <tangmeng@uniontech.com> wrote:
>
> In kernel/Makefile has:
> obj-$(CONFIG_KGDB) += debug/
>
> so kernel/debug/Makefile don't need this 'obj-$(CONFIG_KGDB) +=',
> delete it from kernel/debug/Makefile.
>
> Signed-off-by: tangmeng <tangmeng@uniontech.com>
> ---
>  kernel/debug/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Seems fine to me, with the nit that your Signed-off-by is supposed to
have your "real name", not your username. See
`Documentation/process/submitting-patches.rst`. Some maintainers will
let this slide, but if you're going to submit a patch fixing a nitty
issue then it seems fair to get called out on nits. ;-)

-Doug