Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Feb 2022 09:58:15 +0300
From:   Ivan Bornyakov <i.bornyakov@metrotek.ru>
To:     Wan Jiabing <wanjiabing@vivo.com>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        jiabing.wan@qq.com
Subject: Re: [PATCH] bus: imx-weim: fix NULL but dereferenced coccicheck error
Message-ID: <20220223065815.i7qbyz2gtkgjzcwv@x260>
References: <20220223035146.412499-1-wanjiabing@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220223035146.412499-1-wanjiabing@vivo.com>
Precedence: bulk

On Wed, Feb 23, 2022 at 11:51:45AM +0800, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/bus/imx-weim.c:355:18-21: ERROR: pdev is NULL but dereferenced.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  drivers/bus/imx-weim.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 60fbd42041dd..2ea0a51f79f6 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -352,8 +352,7 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action,
>  
>  		pdev = of_find_device_by_node(rd->dn);
>  		if (!pdev) {
> -			dev_err(&pdev->dev,
> -				"Could not find platform device for '%pOF'\n",
> +			pr_err("Could not find platform device for '%pOF'\n",
>  				rd->dn);
>  
>  			ret = notifier_from_errno(-EINVAL);
> -- 
> 2.35.1
> 

Acked-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>