Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6e5d6ab590f18e6ee57c9e6e4bb805c8c223259a.camel@linux.ibm.com>
Subject: Re: [PATCH v10 24/27] ima: Introduce securityfs file to activate an
 IMA namespace
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Stefan Berger <stefanb@linux.ibm.com>,
        linux-integrity@vger.kernel.org
Cc:     serge@hallyn.com, christian.brauner@ubuntu.com,
        containers@lists.linux.dev, dmitry.kasatkin@gmail.com,
        ebiederm@xmission.com, krzysztof.struczynski@huawei.com,
        roberto.sassu@huawei.com, mpeters@redhat.com, lhinds@redhat.com,
        lsturman@redhat.com, puiterwi@redhat.com, jejb@linux.ibm.com,
        jamjoom@us.ibm.com, linux-kernel@vger.kernel.org,
        paul@paul-moore.com, rgb@redhat.com,
        linux-security-module@vger.kernel.org, jmorris@namei.org
Date:   Wed, 23 Feb 2022 12:12:05 -0500
In-Reply-To: <9262a630-1f3e-0f58-110d-abfebe8274af@linux.ibm.com>
References: <20220201203735.164593-1-stefanb@linux.ibm.com>
         <20220201203735.164593-25-stefanb@linux.ibm.com>
         <9a720bf5928151a0cbc7994ee498a1c3ca779c56.camel@linux.ibm.com>
         <9262a630-1f3e-0f58-110d-abfebe8274af@linux.ibm.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2022-02-23 at 12:08 -0500, Stefan Berger wrote:
> On 2/23/22 08:54, Mimi Zohar wrote:
> > On Tue, 2022-02-01 at 15:37 -0500, Stefan Berger wrote:
> >
> >>   int ima_fs_ns_init(struct user_namespace *user_ns, struct dentry *root)
> >>   {
> >>   	struct ima_namespace *ns = ima_ns_from_user_ns(user_ns);
> >> @@ -531,6 +596,12 @@ int ima_fs_ns_init(struct user_namespace *user_ns, struct dentry *root)
> >>   		}
> >>   	}
> >>   
> >> +	if (ns != &init_ima_ns) {
> >> +		ret = ima_fs_add_ns_files(ima_dir);
> >> +		if (ret)
> >> +			goto out;
> >> +	}
> >> +
> > In all other cases, the securityfs files are directly created in
> > ima_fs_ns_init().   What is different about "active" that a new
> > function is defined?
> 
> 
> It was meant as a function to create namespace-specific files, if more 
> were to come along.  I can move the code from ima_fs_add_ns_files() into 
> this function if you want.

Perhaps defer defining a new function until that happens.

thanks,

Mimi