Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 23 Feb 2022 13:22:37 +0100
From:   Michael Walle <michael@walle.cc>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Peng Fan <peng.fan@nxp.com>, Anson Huang <Anson.Huang@nxp.com>
Cc:     Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        Li Yang <leoyang.li@nxp.com>, linux-kernel@vger.kernel.org,
        heiko.thiery@gmail.com
Subject: Re: [PATCH] dt-bindings: arm: fsl: add IMX8MN DDR3L eval board
In-Reply-To: <96f7a28b-81b9-a05f-e8f5-a4fb377476fc@canonical.com>
References: <20220222151357.1710503-1-michael@walle.cc>
 <96f7a28b-81b9-a05f-e8f5-a4fb377476fc@canonical.com>
User-Agent: Roundcube Webmail/1.4.12
Message-ID: <e45e6fd29b5c91e1413247aa50d6d809@walle.cc>
Precedence: bulk

Am 2022-02-23 12:32, schrieb Krzysztof Kozlowski:
> On 22/02/2022 16:13, Michael Walle wrote:
>> Add a new compatible string for that eval board. It features an IMX8MN
>> UltraLite and has DDR3L RAM. The product part number is 8MNANOD3L-EVK.
>> 
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>>  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml 
>> b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index 23e678232451..e11ffaa8721e 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -834,6 +834,7 @@ properties:
>>                - bsh,imx8mn-bsh-smm-s2     # i.MX8MN BSH SystemMaster 
>> S2
>>                - bsh,imx8mn-bsh-smm-s2pro  # i.MX8MN BSH SystemMaster 
>> S2 PRO
>>                - fsl,imx8mn-ddr4-evk       # i.MX8MN DDR4 EVK Board
>> +              - fsl,imx8mn-ddr3l-evk      # i.MX8MN DDR3L EVK Board
> 
> Looks good, just please put it in alphabetical order, so before ddr4,
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> 
> 
> Best regards,
> Krzysztof

Thanks, I actually forgot to put Anson on CC as he has added the
other entries. Doing that now, also adding Peng Fan. Maybe they
have an opinion on the choosen name.

-michael