X-Received: by 2002:a05:6402:278f:b0:410:d242:465e with SMTP id b15-20020a056402278f00b00410d242465emr925207ede.292.1645643889621; Wed, 23 Feb 2022 11:18:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645643889; cv=none; d=google.com; s=arc-20160816; b=D0LO2T6Jc+dECVqAwwWIYQFqL1RW7chGm03ebYfGUkP1cIAB/eFaCmY5MkD6/3nUp+ tGD6Za7REdeYITbgqpBsRoATe3OdOcVMwd3FRLws30bxKHjPz+nvEEPI5js6T1kC3eA6 E7MyLdogajPJ1vI8JJ8TExXVEOkMskMpLjvOm5XxUoFL8a5lNDh8vG1x1LU+HnKpG+g+ NY26EgnqQcjliHB6UBYRZADwltarP5+t+7S9EsTZgy1p6wpMjvXsbTVLrl6lF2+iVD+c t4NRzDOv281v1F2NWBVfustSM8XVGoBzP+IT2w6JnAjWHEk4ay7gLdDobUvRPMGhNj61 oo9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature; bh=ITKVd03HD6kI7+6MCpav/OGnslbi7iE+/HYSZu10NuY=; b=RyMbRLlV5qZT88I9RNh36z+K9HHGcmeJNqjitCdqHoUwHwcqeN/cTZb5Jnji7nzGQ5 bPi3gyS6gOnyZRGJ3rLWcLgRakfCVPz+ctDooAhEK4YvQBzOEnSvIZp7T1kUDYfy886t fzjQBdC6tABqha/Uh58hNLYx/4d/PwQGY+iA3qNG8iuOSDvsINJOiFIZEqHdeNGFig0i 7GkzX07EPSH1HnCxZn0SFVYb0JhtV7jCY08xTIqAjT+kYm7TBJpnHJoPccHMOv67XWUK UGvogBIRV5fsV4BX4ZkL1iiu6lHepgYt57tWnckUKdHBqnD+lsOmLS+TsG8/l/1dcw7I oNYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oS+r2Dvj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jg14si267197ejc.999.2022.02.23.11.17.44; Wed, 23 Feb 2022 11:18:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oS+r2Dvj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237828AbiBWJRb (ORCPT + 99 others); Wed, 23 Feb 2022 04:17:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233201AbiBWJRa (ORCPT ); Wed, 23 Feb 2022 04:17:30 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FABC32EE6 for ; Wed, 23 Feb 2022 01:17:03 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3B3C861696 for ; Wed, 23 Feb 2022 09:17:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85CC7C340E7; Wed, 23 Feb 2022 09:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645607822; bh=hs5yvpcvkFNU908smRGHGIeMdSnQU/rvrtNyOkhgjmo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oS+r2DvjETmvxCC1BXd9xacjOnzrS66dVqi7HzqdW7a51zqGXc6n0l2F8x4+feIem ldFxFw1SXfXDb231UnIKK/DZ8+O64B4wZEeJCgN//LGmsmAdLQrk9tfE89h2c7npvF M5kXB0C8+FlHIm6U+xIJb4hvC/jR+DQFp4PLXN6xy/YfhQ+ev31ivr0xm3FGfNOi/Y ewOUvvSjQk5W6x+x1HIVGtzz3rMFWUcd74bctRrxpmHsAjKcoiGUCiH0mO3Ir8Az17 9eq2/7sZv8xw+T9BoLNRbML2vhZLft/aY1fLM8n2VUEXRFDKWlaN54MvfwtSCSdveh mA26mYM1L9OJA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nMnlc-009rC7-95; Wed, 23 Feb 2022 09:17:00 +0000 Date: Wed, 23 Feb 2022 09:16:59 +0000 Message-ID: <875yp63ptg.wl-maz@kernel.org> From: Marc Zyngier To: Kalesh Singh , kernel test robot Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, will@kernel.org, qperret@google.com, tabba@google.com, surenb@google.com, kernel-team@android.com, Catalin Marinas , James Morse , Alexandru Elisei , Suzuki K Poulose , Ard Biesheuvel , Mark Rutland , Pasha Tatashin , Joey Gouly , Peter Collingbourne , Andrew Scull , Paolo Bonzini , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH v2 6/9] KVM: arm64: Detect and handle hypervisor stack overflows In-Reply-To: <202202231727.L621fVgD-lkp@intel.com> References: <20220222165212.2005066-7-kaleshsingh@google.com> <202202231727.L621fVgD-lkp@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kaleshsingh@google.com, lkp@intel.com, llvm@lists.linux.dev, kbuild-all@lists.01.org, will@kernel.org, qperret@google.com, tabba@google.com, surenb@google.com, kernel-team@android.com, catalin.marinas@arm.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, ardb@kernel.org, mark.rutland@arm.com, pasha.tatashin@soleen.com, joey.gouly@arm.com, pcc@google.com, ascull@google.com, pbonzini@redhat.com, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Feb 2022 09:05:18 +0000, kernel test robot wrote: > > Hi Kalesh, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on cfb92440ee71adcc2105b0890bb01ac3cddb8507] > > url: https://github.com/0day-ci/linux/commits/Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522 > base: cfb92440ee71adcc2105b0890bb01ac3cddb8507 > config: arm64-randconfig-r011-20220221 (https://download.01.org/0day-ci/archive/20220223/202202231727.L621fVgD-lkp@intel.com/config) > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install arm64 cross compiling tool for clang build > # apt-get install binutils-aarch64-linux-gnu > # https://github.com/0day-ci/linux/commit/7fe99fd40f7c4b2973218045ca5b9c9160524db1 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Kalesh-Singh/KVM-arm64-Hypervisor-stack-enhancements/20220223-010522 > git checkout 7fe99fd40f7c4b2973218045ca5b9c9160524db1 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > include/linux/stddef.h:8:14: note: expanded from macro 'NULL' > #define NULL ((void *)0) > ^~~~~~~~~~~ > arch/arm64/kvm/hyp/nvhe/switch.c:200:27: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides] > [ESR_ELx_EC_FP_ASIMD] = kvm_hyp_handle_fpsimd, > ^~~~~~~~~~~~~~~~~~~~~ > arch/arm64/kvm/hyp/nvhe/switch.c:196:28: note: previous initialization is here > [0 ... ESR_ELx_EC_MAX] = NULL, > ^~~~ > include/linux/stddef.h:8:14: note: expanded from macro 'NULL' > #define NULL ((void *)0) > ^~~~~~~~~~~ Kalesh, please ignore this nonsense. There may be things to improve, but this is *NOT* one of them. These reports are pretty useless, and just lead people to ignore real bug reports. M. -- Without deviation from the norm, progress is not possible.