Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Feb 2022 10:18:51 +0000
From:   Andre Przywara <andre.przywara@arm.com>
To:     Liviu Dudau <liviu.dudau@arm.com>, carsten.haitzler@foss.arm.com
Cc:     dri-devel@lists.freedesktop.org, brian.starkey@arm.com,
        airlied@linux.ie, daniel@ffwll.ch, steven.price@arm.com,
        linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
Message-ID: <20220223101851.46423dcf@donnerap.cambridge.arm.com>
In-Reply-To: <Ye/vEilz6j8gX3wu@e110455-lin.cambridge.arm.com>
References: <20220124162437.2470344-1-carsten.haitzler@foss.arm.com>
        <Ye/vEilz6j8gX3wu@e110455-lin.cambridge.arm.com>
Organization: ARM
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 25 Jan 2022 12:37:38 +0000
Liviu Dudau <liviu.dudau@arm.com> wrote:

Hi,

> On Mon, Jan 24, 2022 at 04:24:37PM +0000, carsten.haitzler@foss.arm.com wrote:
> > From: Carsten Haitzler <carsten.haitzler@arm.com>
> > 
> > Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
> > 
> > Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
> > 
> > Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>  
> 
> Acked-by: Liviu Dudau <liviu.dudau@arm.com>
> 
> I will add Steven's reviewed-by as well when pushing it.

Did this go anywhere? I see my .config just selecting HDLCD still failing
with -rc5. Any chance this can be taken now, as this is a regression
introduced with -rc1?

Cheers,
Andre

> > ---
> >  drivers/gpu/drm/arm/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> > index 58a242871b28..6e3f1d600541 100644
> > --- a/drivers/gpu/drm/arm/Kconfig
> > +++ b/drivers/gpu/drm/arm/Kconfig
> > @@ -6,6 +6,7 @@ config DRM_HDLCD
> >  	depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
> >  	depends on COMMON_CLK
> >  	select DRM_KMS_HELPER
> > +	select DRM_GEM_CMA_HELPER
> >  	help
> >  	  Choose this option if you have an ARM High Definition Colour LCD
> >  	  controller.
> > -- 
> > 2.30.1
> >   
>