Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220203093922.20754-1-tzimmermann@suse.de> <CAMuHMdWykWR4oKahC2GYF5jG4przRQ+MxNNm1BK7o62OhhGYwA@mail.gmail.com>
 <CAMuHMdXcRRgn4EMXn9qonnjTTp7EEfwP4F8FeVpLkQMNvB-6mg@mail.gmail.com>
In-Reply-To: <CAMuHMdXcRRgn4EMXn9qonnjTTp7EEfwP4F8FeVpLkQMNvB-6mg@mail.gmail.com>
From:   Doug Anderson <dianders@chromium.org>
Date:   Wed, 23 Feb 2022 08:11:04 -0800
Message-ID: <CAD=FV=UbiXx4RBQNFp1htCYsM1YzAgES+mcA6KOJ7ZmydkHnBg@mail.gmail.com>
Subject: Re: [PATCH v2] drm/panel: Select DRM_DP_HELPER for DRM_PANEL_EDP
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Thomas Zimmermann <tzimmermann@suse.de>,
        Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, Lyude Paul <lyude@redhat.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Ard Biesheuvel <ardb@kernel.org>,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        Arnd Bergmann <arnd@arndb.de>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Kernel Functional Testing <lkft@linaro.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Tue, Feb 22, 2022 at 1:31 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> On Tue, Feb 8, 2022 at 10:39 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Mon, Feb 7, 2022 at 12:31 PM Thomas Zimmermann <tzimmermann@suse.de> wrote:
> > > As reported in [1], DRM_PANEL_EDP depends on DRM_DP_HELPER. Select
> > > the option to fix the build failure. The error message is shown
> > > below.
> > >
> > >   arm-linux-gnueabihf-ld: drivers/gpu/drm/panel/panel-edp.o: in function
> > >     `panel_edp_probe': panel-edp.c:(.text+0xb74): undefined reference to
> > >     `drm_panel_dp_aux_backlight'
> > >   make[1]: *** [/builds/linux/Makefile:1222: vmlinux] Error 1
> > >
> > > The issue has been reported before, when DisplayPort helpers were
> > > hidden behind the option CONFIG_DRM_KMS_HELPER. [2]
> > >
> > > v2:
> > >         * fix and expand commit description (Arnd)
> > >
> > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> >
> > Thanks for your patch!
> >
> > This fixes the build errors I'm seeing, so
> > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Is this planned to be queued? This is still failing in drm-next.
> Thanks!

Looks like this has been in drm-misc-next since Feb 4:

---

commit eea89dff4c39a106f98d1cb5e4d626f8c63908b9
Author:     Thomas Zimmermann <tzimmermann@suse.de>
AuthorDate: Thu Feb 3 10:39:22 2022 +0100
Commit:     Thomas Zimmermann <tzimmermann@suse.de>
CommitDate: Fri Feb 4 09:38:47 2022 +0100

    drm/panel: Select DRM_DP_HELPER for DRM_PANEL_EDP

---

Maybe it needed to land elsewhere, though?

-Doug