Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Feb 2022 15:39:12 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Sui Jingfeng <15330273260@189.cn>
Cc:     Thomas Zimmermann <tzimmermann@suse.de>,
        Roland Scheidegger <sroland@vmware.com>,
        Zack Rusin <zackr@vmware.com>,
        Christian Gmeiner <christian.gmeiner@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Ilia Mirkin <imirkin@alum.mit.edu>,
        Qing Zhang <zhangqing@loongson.cn>,
        suijingfeng <suijingfeng@loongson.cn>,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Randy Dunlap <rdunlap@infradead.org>,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v10 3/4] drm/lsdc: add drm driver for loongson display
 controller
Message-ID: <20220223143912.m727fie3vtdkvklo@houat>
References: <20220220145554.117854-1-15330273260@189.cn>
 <20220220145554.117854-4-15330273260@189.cn>
 <20220222082747.66otrkc4zwvhem7w@houat>
 <54ea69d7-2fac-74dc-2ef6-843a666cff85@189.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="wam4wqm3zed2h2ms"
Content-Disposition: inline
In-Reply-To: <54ea69d7-2fac-74dc-2ef6-843a666cff85@189.cn>
Precedence: bulk


--wam4wqm3zed2h2ms
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 22, 2022 at 10:46:35PM +0800, Sui Jingfeng wrote:
>=20
> On 2022/2/22 16:27, Maxime Ripard wrote:
> > > +	if (!of_device_is_available(output)) {
> > > +		of_node_put(output);
> > > +		drm_info(ddev, "connector%d is not available\n", index);
> > > +		return NULL;
> > > +	}
> > > +
> > > +	disp_tims_np =3D of_get_child_by_name(output, "display-timings");
> > > +	if (disp_tims_np) {
> > > +		lsdc_get_display_timings_from_dtb(output, &lconn->disp_tim);
> > > +		lconn->has_disp_tim =3D true;
> > > +		of_node_put(disp_tims_np);
> > > +		drm_info(ddev, "Found display timings provided by connector%d\n", =
index);
> > > +	}
> > > +
> > > +	connector_type =3D lsdc_get_connector_type(ddev, output, index);
> > > +
> > > +	if (output) {
> > > +		of_node_put(output);
> > > +		output =3D NULL;
> > > +	}
> > > +
> > > +DT_SKIPED:
> > > +
> > > +	/* Only create the i2c channel if display timing is not provided */
> > > +	if (!lconn->has_disp_tim) {
> > > +		const struct lsdc_chip_desc * const desc =3D ldev->desc;
> > > +
> > > +		if (desc->have_builtin_i2c)
> > > +			lconn->ddc =3D lsdc_create_i2c_chan(ddev, index);
> > > +		else
> > > +			lconn->ddc =3D lsdc_get_i2c_adapter(ddev, index);
> > This looks weird: the connector bindings have a property to store the
> > i2c controller connected to the DDC lines, so you should use that
> > instead.
> >=20
> This is not=A0 weird,=A0 ast, mgag200, hibmc do the same thing.

And none of them have DT support.

Maxime

--wam4wqm3zed2h2ms
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYhZHEAAKCRDj7w1vZxhR
xXitAP9v7HOYqHz8i7UAxoCMoqbrhwBW9XOoHnf/jK5QqIkJuwEAuPDXzMoMz/sH
GrxQHl28jgBtPlbX7QJnoi4BgNwVNQA=
=4ezX
-----END PGP SIGNATURE-----

--wam4wqm3zed2h2ms--