Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1000060pxm; Wed, 23 Feb 2022 15:36:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJxHSfuaeF+v02N44dTFa5G5qv0Iy6m+zG0Zl5eTGCwTdf1Q2hnN3QD50wBRo1JQKX7305Ic X-Received: by 2002:aa7:9199:0:b0:4e1:9243:b625 with SMTP id x25-20020aa79199000000b004e19243b625mr4187pfa.21.1645659377802; Wed, 23 Feb 2022 15:36:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645659377; cv=none; d=google.com; s=arc-20160816; b=QPnpF71QPTGObjmHlETGhiNcvfrWxMcXGaprrUr6FtQIDDLRbn7MMTieFgzWzdUzNf CFcnijIV0FkqJ6j/Xq0fvGm6lvHKj6x0Bg97YXI7Dg5q8wx4+Pr7TeKJB3PRTiWNH8Km nLKkY9pNEgZuV3ox8tl7WKRp9T3QqQ7y+fFEDKXh28R/aGq2d4Izyf6buFmhnc8i72oV 6D9SmYqHOWrIbBDgTGQd3n7C4JwcuBQdDq+EXbM50GG28x5V5tAv1dELgo9+PmU1lc58 GOS+8Xc2mkUS3eY0jVTg5Gb1hKqb+Rz1ty4ODId0ipFVsFb0CPpQEJPCdyC2w9TE+8Ca cECA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=6eDB7aFq5D/vd2A4D5NeHRGvDJwnkiYofXRPTaW94Ek=; b=pTP8+T+8OyWneLuOvD+UVFdhWO43khhY7hLwZdGMYYoRxqFhW7cVmlMSaJ1RW7uNdp nkxZ1v0hlVDEj9FeWotgUgk+BArXB4S+sZxOeczgyoHkWM3pp9tMgxhfrqtZdrFhQ6g9 94XngvbSoPPtxTC13Hl1zKuysMyOBd6fgm1wQoYKhmJynul3RfeO92X7WpCcPbobYhpf WMH8awxvrior91bU7stmLQV+6yB1A4V9ZewIaiV4X1IOCjPV31lniVk2hk2bUPUFfY5F A7HmxWssv24/g+Haau2nPzeVYwqD9bQKbQ/UQ2ULSGPmSJOnPj+TEWbygppfLyXoLpKp i4+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rkQtj8PD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z4si922211ple.429.2022.02.23.15.36.02; Wed, 23 Feb 2022 15:36:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rkQtj8PD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241694AbiBWOmd (ORCPT + 99 others); Wed, 23 Feb 2022 09:42:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229893AbiBWOmc (ORCPT ); Wed, 23 Feb 2022 09:42:32 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D9DFB3E6C; Wed, 23 Feb 2022 06:42:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1339EB81FCE; Wed, 23 Feb 2022 14:42:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AABBBC340E7; Wed, 23 Feb 2022 14:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645627321; bh=54knkAHgw4FVQ6bPw0gxjMifXkkf7pu6KINdWoLri+c=; h=From:To:Cc:Subject:Date:From; b=rkQtj8PDP2Deulram9ERTWwLjDnlpnC2sBniN8+liD+2uHbKr1Kf63qH9E5vKC2cu TaRTlmooVLtbpbbSPgE/6oMo0qGBspX3dhfcq2DpSFyahkIGqtoZpmSRxzx++qaC9T 8rFD1ghTUCPHv8qPHhjfwOMf2hrpqKT+gbxScNeZDajJ/VRHEGvdgoP1nMxMYQdUx+ p94GK5cekpWzW9sAgDFTkqO2WtWbHTtE3jgd92lA0eoFOJg5/D4mreEGSIRp+hkU8b GbUBZqiR3WNFkolC/Wcd058whKkQFqsTDzi2DUDRNUrk/XvdJVGlRUYkPla+ZTvQ0E ze78UZuKW7S7Q== From: Dinh Nguyen To: gregkh@linuxfoundation.org Cc: dinguyen@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, Ang Tien Sung , stable@vger.kernel.org Subject: [PATCH] firmware: stratix10-svc: add missing callback parameter on RSU Date: Wed, 23 Feb 2022 08:41:46 -0600 Message-Id: <20220223144146.399263-1-dinguyen@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ang Tien Sung Fix a bug whereby, the return response of parameter a1 from an SMC call is not properly set to the callback data during an INTEL_SIP_SMC_RSU_ERROR command. Cc: stable@vger.kernel.org Fixes: 6b50d882d38d ("firmware: add remote status update client support") Link: https://lore.kernel.org/lkml/20220216081513.28319-1-tien.sung.ang@intel.com Signed-off-by: Ang Tien Sung Signed-off-by: Dinh Nguyen --- drivers/firmware/stratix10-svc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c index 29c0a616b317..c4bf934e3553 100644 --- a/drivers/firmware/stratix10-svc.c +++ b/drivers/firmware/stratix10-svc.c @@ -477,7 +477,7 @@ static int svc_normal_to_secure_thread(void *data) case INTEL_SIP_SMC_RSU_ERROR: pr_err("%s: STATUS_ERROR\n", __func__); cbdata->status = BIT(SVC_STATUS_ERROR); - cbdata->kaddr1 = NULL; + cbdata->kaddr1 = &res.a1; cbdata->kaddr2 = NULL; cbdata->kaddr3 = NULL; pdata->chan->scl->receive_cb(pdata->chan->scl, cbdata); -- 2.25.1