Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220223094109.192510-1-cuigaosheng1@huawei.com>
In-Reply-To: <20220223094109.192510-1-cuigaosheng1@huawei.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Wed, 23 Feb 2022 17:00:15 -0500
Message-ID: <CAHC9VhQhMG0YFYUQvn=2tYab-UwVjOWxAK9h-DA9=GCvzhRAHg@mail.gmail.com>
Subject: Re: [PATCH -next] audit: only print records that will be dropped via printk()
To:     Gaosheng Cui <cuigaosheng1@huawei.com>
Cc:     eparis@redhat.com, linux-audit@redhat.com,
        linux-kernel@vger.kernel.org, wangweiyang2@huawei.com,
        xiujianfeng@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Feb 23, 2022 at 4:41 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote:
>
> When an admin enables audit at early boot via the "audit=1" kernel
> command line, netlink send errors seen will cause the audit subsystem
> to drop some records or return records to the queue. And all records
> will be printed via printk() in the kauditd_hold_skb(), but actually
> only the records that will be dropped need to be printed via printk().
>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>  kernel/audit.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

When records are moved to the hold queue the system is in a bad state
so printing the record via printk() regardless of if the record is
able to be successfully queued or dropped is important.  If this is
happening frequently on your system, this is likely a sign your system
is misconfigured.

-- 
paul-moore.com