Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 23 Feb 2022 12:35:56 -0500
From:   =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado 
        <nfraprado@collabora.com>
To:     Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Chunfeng Yun <chunfeng.yun@mediatek.com>,
        Min Guo <Min.Guo@mediatek.com>,
        Project_Global_Chrome_Upstream_Group@mediatek.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: phy: Add compatible for Mediatek MT8192
Message-ID: <20220223173556.u3dx7ugpxpcpir2n@notapiano>
References: <20220217135620.10559-1-allen-kh.cheng@mediatek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220217135620.10559-1-allen-kh.cheng@mediatek.com>
Precedence: bulk

Hi Allen,

thanks for the patch. Please see the comment below.

On Thu, Feb 17, 2022 at 09:56:20PM +0800, Allen-KH Cheng wrote:
> This commit adds dt-binding documentation of T-Phy for Mediatek MT8192 SoC
> Platform.

Commit messages should be in imperative [1]. I'd suggest the following message:

	Add MT8192 compatible to the Mediatek T-PHY dt-binding.

[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

Also, the commit title would be better if it had the tag for the tphy file, like
this:

	dt-bindings: phy: mediatek,tphy: Add compatible for MT8192

Otherwise it's not clear that you're changing the T-PHY just from the title.

> 
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>

Other than that,

Reviewed-by: N?colas F. R. A. Prado <nfraprado@collabora.com>

Thanks,
N?colas

> ---
>  Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> index d279ba222316..7b2e1bc119be 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> @@ -81,6 +81,7 @@ properties:
>                - mediatek,mt7629-tphy
>                - mediatek,mt8183-tphy
>                - mediatek,mt8186-tphy
> +              - mediatek,mt8192-tphy
>            - const: mediatek,generic-tphy-v2
>        - items:
>            - enum:
> -- 
> 2.18.0
> 
>