Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932506AbXBPRMg (ORCPT ); Fri, 16 Feb 2007 12:12:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932504AbXBPRMg (ORCPT ); Fri, 16 Feb 2007 12:12:36 -0500 Received: from 207.47.60.150.static.nextweb.net ([207.47.60.150]:37451 "EHLO webmail.xensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932506AbXBPRMe (ORCPT ); Fri, 16 Feb 2007 12:12:34 -0500 User-Agent: Microsoft-Entourage/11.2.5.060620 Date: Fri, 16 Feb 2007 17:12:31 +0000 Subject: Re: [Xen-devel] Re: [patch 12/21] Xen-paravirt: Allocate and free vmalloc areas From: Keir Fraser To: Keir Fraser , Jeremy Fitzhardinge , Andi Kleen CC: Zachary Amsden , , , , Jan Beulich , Chris Wright , Ian Pratt , Andrew Morton , Christian Limpach Message-ID: Thread-Topic: [Xen-devel] Re: [patch 12/21] Xen-paravirt: Allocate and free vmalloc areas Thread-Index: AcdR7VulmlTzEL3gEduvqQAX8io7RQAAEi3z In-Reply-To: Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1022 Lines: 26 On 16/2/07 17:10, "Keir Fraser" wrote: > On 16/2/07 16:46, "Jeremy Fitzhardinge" wrote: > >> Yes, that would work. Unfortunately that's i386 arch-specific, whereas >> the rest of this code is generic. I guess I could just move it all to >> arch/i386/mm. > > This whole thing isn't an issue on ia64 (they no-op lock_vm_area) and > powerpc doesn't use any of the Xen driver code at this time. > vmalloc_sync_all is supported by both i386 and x86_64, so we can make the > call conditional on CONFIG_X86 so that ia64 will continue to build. This is > what I've done in xen-unstable. In fact that file is only built for i386 and x86_64, so there really is no problem with using vmalloc_sync_all() directly and without ifdef. -- Keir - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/