From: Arnd Bergmann <arnd@arndb.de>
To: Maynard Johnson <maynardj@us.ibm.com>
Subject: Re: [Cbe-oss-dev] [RFC, PATCH] CELL Oprofile SPU profiling updated patch
Date: Fri, 16 Feb 2007 18:14:26 +0100
User-Agent: KMail/1.9.5
Cc: cbe-oss-dev@ozlabs.org, linuxppc-dev@ozlabs.org,
       linux-kernel@vger.kernel.org, oprofile-list@lists.sourceforge.net,
       Carl Love <cel@us.ibm.com>
References: <1171497138.23691.8.camel@dyn9047021078.beaverton.ibm.com> <200702151537.51202.arnd@arndb.de> <45D4FBB0.7090109@us.ibm.com>
In-Reply-To: <45D4FBB0.7090109@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200702161814.26855.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1340
Lines: 35

On Friday 16 February 2007 01:32, Maynard Johnson wrote:
> config OPROFILE_CELL
> ? ? ? ? bool "OProfile for Cell Broadband Engine"
> ? ? ? ? depends on OPROFILE && SPU_FS
> ? ? ? ? default y if ((SPU_FS = y && OPROFILE = y) || (SPU_FS = m && 
> OPROFILE = m))
> ? ? ? ? help
> ? ? ? ? ? Profiling of Cell BE SPUs requires special support enabled
> ? ? ? ? ? by this option. ?Both SPU_FS and OPROFILE options must be
> ? ? ? ? ? set 'y' or both be set 'm'.
> =============
> 
> Can anyone see a problem with any of this . . . or perhaps a suggestion 
> of a better way?

The text suggests it doesn't allow SPU_FS=y with OPROFILE=m, which I think
should be allowed. I also don't see any place in the code where you actually
use CONFIG_OPROFILE_CELL.

Ideally, you should be able to have an oprofile_spu module that can be
loaded after spufs.ko and oprofile.ko. In that case you only need

config OPROFILE_SPU
	depends on OPROFILE && SPU_FS
	default y

and it will automatically build oprofile_spu as a module if one of the two
is a module and won't build it if one of them is disabled.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/