Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <7d5512ce-b94b-b890-f852-6c37e2698b7f@wolfvision.net>
Date:   Wed, 23 Feb 2022 09:41:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: enable rk809 audio codec on the
 rk3568 evb1
Content-Language: en-US
To:     Heiko Stuebner <heiko@sntech.de>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Rob Herring <robh+dt@kernel.org>, Liang Chen <cl@rock-chips.com>,
        frank-w@public-files.de
References: <20220222175004.1308990-1-michael.riesch@wolfvision.net>
 <20220222175004.1308990-2-michael.riesch@wolfvision.net>
 <3287619.yDqD7nnjd0@phil>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <3287619.yDqD7nnjd0@phil>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGV2NlNoWUNkNDkvRFFzNnBteXhFNk8xaFUxK2dWTWxyb01DZEpmcVRPaFBE?=
 =?utf-8?B?d0tQclBKVWhXdUNzTGVub21UTHQ0U0pWTGZNVTkrVmhSYU11cDRkeVZrbWhU?=
 =?utf-8?B?TDJ6dnN6ejJaN2dPa1UrUzZDSzlPZjQ1S2cycjJVM01hVjZUeEdpd2N4cnZr?=
 =?utf-8?B?WEVzOHYwdE0xcElhdlFOQUkwM2RHNVA0VnE1d2RZQ3daK04zbms4ZWJwTUtV?=
 =?utf-8?B?OE5UYjZicWdqb1Y1TGJFMHZWM0ZYWkRiL3hHdHp1NmtFczJmbVlqVnpTeTVs?=
 =?utf-8?B?YTdQUmQrUVFYalJmSHZOenR1RTJxTTlFSWFqOXJmS2xzLy81dEJJanI4KzZQ?=
 =?utf-8?B?aUVFWHV2cHdxZlpsVnd1TjA1OXhGVFd1alh1di9HcU04N0pTeGYyUDZIa2ZD?=
 =?utf-8?B?SlQ0YmZvTlc2REdSSmpBTmVvMnpGSzc1R1k1bkNyUGNWQi9mZE42UnZablR4?=
 =?utf-8?B?aUEreE11NDFoNDlJQk9tcVZaaEZRNFkvOXBQTUYvS2V6eHRmbjhvNE9VYk9a?=
 =?utf-8?B?OTh0UHB4Zy9PL3o5dE1yUlV0cWFINDA0SEJicWRwUjNXZktleUo4VkJvTXps?=
 =?utf-8?B?YnBQT0pYVjFWYUcvUXkzOFJIeUpyU1dhcUhNOGthbldhT0NxN0ViRFV5eU93?=
 =?utf-8?B?ZFpEckdYU3RZU1duSnV1ZkdiZHFvN0p3emVFQlg3a01NUkxZck95OEhWbnJO?=
 =?utf-8?B?aW8zVHpkalQyRmFrWG9JUjBmNzRwdEpwc1lKc1hud2hRbUZidHk5K2EwZDla?=
 =?utf-8?B?cjlHWUFGNlcrZU45ODgrTkY1bTA2SXNGek8yN3VOUXRzWVU0TWlRUkQvSWtn?=
 =?utf-8?B?MUpGYXpsTlpQVno2dHloaHFXandHa0xQL2FHS0RSa2FMN3Q5c3dySjNScmsz?=
 =?utf-8?B?OE5FZEhQSW1Tc2U3WTJ4c1JsV1Y1M3gzRU5iUCtxQlJ5YnNqeUFvRmdDazA0?=
 =?utf-8?B?b3NrSURFKzNqVFY1TjRDY3BOR2h3dEhvQURxVHBzYm9UR0tQeng5UG1qWnJp?=
 =?utf-8?B?SUNDNGd4UUZWczV1UmRyVGVBVm43Y09TTUMvVGYzcEwzK2JwbHRWSUc3MjdK?=
 =?utf-8?B?V1VFVE92K1AxOFdKcTZVUzVQSGFZM2ZzY3Z6THIwQ0M1TnY4Snd3WTNZc3ll?=
 =?utf-8?B?RE4ramM4NVByTUphclNDK3hDVWdCNFF0NVFySzJIcGZCb1JNY0hTTWF4R3VQ?=
 =?utf-8?B?ZE8yc3pzYVhTaEtZM2JUU3Q3WUwrR0RRdHNmdmd0azV0a1V0RzE5enEvMnZU?=
 =?utf-8?B?ejlBNTk0ZzBsSCtQd1JTdnFvVStNMDRmZjVmcTVXRnkzZlNwR1BKN3NpeWVG?=
 =?utf-8?B?ajQzZGtjVG83WnIxRjhYYm9IMDdUcCt6OFB4Z3dQRVZYQTY0dDZDeUFETURK?=
 =?utf-8?B?REYzYldvemphdzdvY0N4WUxYV1U4dGJudFA3Q3lvZFVEQUNOTXBFc3pKUjRU?=
 =?utf-8?B?dmRrcDhGSTlkVmRsWjlySVlhRW9TRXBBMysxU29lY2lBZ21nT05VWFdZRUJL?=
 =?utf-8?B?VktSYzg2VUFZcVdaN2lhUUVuTFBmcXNpSnE4dVNNK3Z6REJGTksva1RNRzUw?=
 =?utf-8?B?NjVXL0JHRG1TR0pXejlzWmpOWEtZZ3pqUGFnamlRMFZlK0U4d0FVVk54aHNG?=
 =?utf-8?B?cDg2cnJFbnVBS2pXcFY2dURTVnFBakZ1d3VCNXZLR0IwRXJCNytQY3JnRjRG?=
 =?utf-8?B?OENoTEQxemQ2YVpWZG5IYVZEQ0MrUXFkZmN5QW4wYkZjejJhNUR4cm9hNkU1?=
 =?utf-8?B?bUt6ZWU4eTJYcEJCb0dWQW4vc2p3dktFcVpESlYvc0NzZkFQSEt4QkUydWdo?=
 =?utf-8?B?TDdSQ3ZaM0lKOExGVXU5d3kvMXh5QStpaVpuQjdySlVpSlV4YXJGN05kYjJm?=
 =?utf-8?B?c2lEWFk4Tm5pYlZFZTdwSmR0T2hiSjlWaFVIdCtFY0oydUxscGNsb2FqNHFw?=
 =?utf-8?B?dkFTNTl6VnZ0WjkzSFdWc0pCczYrZGQxR3A3MmxXRytvVzZkamI2eXRaZzBo?=
 =?utf-8?B?MHVFSlFmQm5QQklSM0dUcUlGelhFYTBza1d5b2FtcW4vbTZid3VoSVRDWkxJ?=
 =?utf-8?B?bHJIOFdlMDNUb3ZCc2VXblZYV05RQWozN0x5dXJKdU9hWHlHWjFvNGtDbEVk?=
 =?utf-8?B?S3lCUkRQa1ozNmpOeW1MZkxUdlB4dERRckFwczNXb3c1VHN2eUl6aHJDMFNY?=
 =?utf-8?B?YmtjZVBXYnhTaU9kSDNtR2J5cm42SkNGR3kxRWNVTXRWY1dVTGpIMC9ZeWZQ?=
 =?utf-8?B?N0QwSzdXWmxVRXhycjB0VzlCZmt1UkJ1dm5tSGNTOWMwNGtVNjQvaExJWXpZ?=
 =?utf-8?B?dkNkT2dvQUIyZWRJZjNMWGMyWng1T2JZb1ZacVBIbzVjQnhxK2QzZz09?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 918ff529-3f91-42e7-582e-08d9f6a84557
X-MS-Exchange-CrossTenant-AuthSource: HE1PR0802MB2426.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 08:41:23.0426
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 79GB7pnn8Yg18A35yfbe8ALNsO+kKPjJtp0nWK+cJWcMLNuzYlX5B3q7cs3gN3fl/IUszjV2a+3xSvA8ERytq0H6psqraxwB7NhVjzRcR00=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4433
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Heiko,

On 2/23/22 00:11, Heiko Stuebner wrote:
> Hi,
> 
> Am Dienstag, 22. Februar 2022, 18:50:04 CET schrieb Michael Riesch:
>> Enable the Rockchip RK809 audio codec on the Rockchip RK3568
>> EVB1. This requires the VCCIO_ACODEC voltage regulator to be set
>> to always on.
>>
>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> 
> [...]
> 
>> @@ -282,6 +301,7 @@ regulator-state-mem {
>>  
>>  			vccio_acodec: LDO_REG4 {
>>  				regulator-name = "vccio_acodec";
>> +				regulator-always-on;
> 
> As this seems to supply the codec (in the rk809?) shouldn't the
> sound part model that relationship and handle regulators
> instead of requiring an arbitary regulator to be always on?

To be honest, I am not entirely sure. VCCIO_ACODEC is supplied by the
(LDO regulator part of the) RK809. As far as I can tell, the audio codec
part of the RK809 is powered internally. There is indeed a note "IO
Power = LDO4" (which corresponds to VCCIO_ACODEC) at the I2S interface,
which would make the RK809 the producer and a consumer of this voltage.
This could be modeled in the driver, but seeing that the rk808 driver
and the codec driver are directly coupled I think it would not change much.

I admit that I am going for the low-effort solution here, but it is done
in similar fashion on other boards. What do you think?

As to the other consumers of VCCIO_ACODEC: The microphone requires this
voltage, but is there a representation of an analog microphone?

And of course the voltage serves as supply for one of the PMU IO
(voltage) domains (vccio1). But I think here the principle is that the
IO voltage is only turned on if there is a peer on the other end, which
(most likely) consumes this voltage as well.

If you decide to accept the change as is, could you please fix up the
commit message "rk3568 evb1" -> "rk3568-evb1-v10" for consistency? This
did not occur to me when I sent the patches, sorry!

Best regards,
Michael

> 
> 
> Heiko
> 
>>  				regulator-min-microvolt = <3300000>;
>>  				regulator-max-microvolt = <3300000>;
>>  
>> @@ -366,6 +386,10 @@ regulator-state-mem {
>>  				};
>>  			};
>>  		};
>> +
>> +		codec {
>> +			mic-in-differential;
>> +		};
>>  	};
>>  };
>>  
>> @@ -386,6 +410,11 @@ touchscreen0: goodix@14 {
>>  	};
>>  };
>>  
>> +&i2s1_8ch {
>> +	rockchip,trcm-sync-tx-only;
>> +	status = "okay";
>> +};
>> +
>>  &mdio0 {
>>  	rgmii_phy0: ethernet-phy@0 {
>>  		compatible = "ethernet-phy-ieee802.3-c22";
>>
> 
> 
> 
>