Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20210913233325.23263-1-pcc@google.com>
In-Reply-To: <20210913233325.23263-1-pcc@google.com>
From:   Peter Collingbourne <pcc@google.com>
Date:   Wed, 23 Feb 2022 14:32:38 -0800
Message-ID: <CAMn1gO6WUATuQhVQRUgDYbytk0ohVytD_-fvOoP16xVZGJfhgg@mail.gmail.com>
Subject: Re: [PATCH] checkpatch.pl: use correct gitroot when running from
 non-top-level dir
To:     Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Sep 13, 2021 at 4:33 PM Peter Collingbourne <pcc@google.com> wrote:
>
> My workflow usually requires running checkpatch.pl from a subdirectory
> of the kernel source tree. This works for the most part, but the script
> will be unable to find the .git directory and will therefore refuse to
> run any git commands (so, e.g. commit ID verification will fail). Fix
> it by prepending $root to $gitroot when a root is set.
>
> This also requires fixing one root directory assumption in a git
> invocation.

Ping.

Peter