Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Rolf Eike Beer <eb@emlix.com>
To:     guoren@kernel.org, palmer@dabbelt.com, arnd@arndb.de,
        anup@brainfault.org, gregkh@linuxfoundation.org,
        liush@allwinnertech.com, wefu@redhat.com, drew@beagleboard.org,
        wangjunqiang@iscas.ac.cn, hch@lst.de, guoren@kernel.org
Cc:     linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-riscv@lists.infradead.org, linux-csky@vger.kernel.org,
        linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-parisc@vger.kernel.org,
        linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        x86@kernel.org, Guo Ren <guoren@linux.alibaba.com>
Subject: Re: [PATCH V5 17/21] riscv: compat: vdso: Add setup additional pages implementation
Date:   Wed, 23 Feb 2022 13:12:03 +0100
Message-ID: <4379941.LvFx2qVVIh@eto.sf-tec.de>
Organization: emlix GmbH
In-Reply-To: <20220201150545.1512822-18-guoren@kernel.org>
References: <20220201150545.1512822-1-guoren@kernel.org> <20220201150545.1512822-18-guoren@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart2230114.ElGaqSPkdT"; micalg="pgp-sha256"; protocol="application/pgp-signature"
Precedence: bulk

--nextPart2230114.ElGaqSPkdT
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"

> @@ -66,35 +68,35 @@ static int vdso_mremap(const struct vm_special_mapping
> *sm, return 0;
>  }
>=20
> -static int __init __vdso_init(void)
> +static int __init __vdso_init(struct __vdso_info *vdso_info)
>  {
>  	unsigned int i;
>  	struct page **vdso_pagelist;
>  	unsigned long pfn;
>=20
> -	if (memcmp(vdso_info.vdso_code_start, "\177ELF", 4)) {
> +	if (memcmp(vdso_info->vdso_code_start, "\177ELF", 4)) {
>  		pr_err("vDSO is not a valid ELF object!\n");
>  		return -EINVAL;
>  	}
>=20

Does anyone actually guarantee that this is at least this 4 bytes long?

Eike
=2D-=20
Rolf Eike Beer, emlix GmbH, https://www.emlix.com
=46on +49 551 30664-0, Fax +49 551 30664-11
Gothaer Platz 3, 37083 G=C3=B6ttingen, Germany
Sitz der Gesellschaft: G=C3=B6ttingen, Amtsgericht G=C3=B6ttingen HR B 3160
Gesch=C3=A4ftsf=C3=BChrung: Heike Jordan, Dr. Uwe Kracke =E2=80=93 Ust-IdNr=
=2E: DE 205 198 055

emlix - smart embedded open source
--nextPart2230114.ElGaqSPkdT
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iLMEAAEIAB0WIQQ/Uctzh31xzAxFCLur5FH7Xu2t/AUCYhYkkwAKCRCr5FH7Xu2t
/HZ1A/sGakdodHOoW1ysqdO2mluUIlVSczhoHppED9p5Oqf4/05LhsOcrrn6E4wn
FAbLE4CKEv7FmrqmAPFnGfZbWwZ84QdgQsHHh6uZYCAuT6R1HCWRl5SY1RaO1NOW
ry0P7NXzDWBNe9XTWbZgk51OxZLS3JtlUaiQaF+U03M5yVKtgw==
=oRLD
-----END PGP SIGNATURE-----

--nextPart2230114.ElGaqSPkdT--