Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1064807pxm; Wed, 23 Feb 2022 17:11:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJzVh7GMd5tu44e3WoeOj6dLzSF9Y1zjf4k0EwbYptH0SdQmmf2zyTI7SFjqKQT/9HJWOzGl X-Received: by 2002:a17:902:ab4c:b0:14f:bb61:ef0a with SMTP id ij12-20020a170902ab4c00b0014fbb61ef0amr190623plb.84.1645665089520; Wed, 23 Feb 2022 17:11:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645665089; cv=none; d=google.com; s=arc-20160816; b=q5GAOr6D2StrZpIM7eSVfGqosjEfKZvQa6liawhg+gyb0+LoIdAV/JKoK+f8wh/fNU qOGFa9k23d2ynRFQGrU7GWMwIttaOLOC9HgEWNR0j5qwMp17InVw1sONo2a+naseiJei u/WaVvP4XHOcC1jiCVomQG9JuaYfjMMtzRcV85tX4YQ5DXl6PVasKvsCKlfeScwjmgGM j7bxAsxu6rdWVZaF0oOvkU55Ft7dRX4pCVBOlRfyJzecsXBW+srMq1+vt3c9wqilwZs7 KoKJnx2XPypmcHH783fTRHw6bWuNPQKdPdKxRIPFCeh+7LdEolR6jMwvPPsz9Xm7OVi7 yYpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rb+JKqwrhcprw7ZNPfiTuYpfu5/yjDpPHHSpi/Rs7hc=; b=cj00lZZAmLVmyAFgtp+dD+VhjYZBs0d0SahQkbcf1QmNl9RhLNcVBfYZKYHVag3gJ0 dg5ShSYo94ids0RwWywQJBs4ZyfWvonCrAc68bZ94TUt+TCkZvZcWyioKiG9hoaceWsu x/wJUdrfvWZkG9boigrgWBTauCTYXShLPEtnvNl1Dq2vk0t6Ytvp5cKJKbRfvUGUjFrC RItu10goKk6jzslkfLIiI+oOBszF5kfedi2NZ3vlHbA6eCqy8OSbQkj7OAGpWh+qKu/w YrK0f92gOQUWY+FWlMHf4SF6l4dd607ZL/cMKxdNZGKTiCPKdjkTfT43S60ODnJy9ssM n3mA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="no414x/Q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id o19si1543720pgu.109.2022.02.23.17.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 17:11:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="no414x/Q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A603C158DA2; Wed, 23 Feb 2022 16:58:40 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240215AbiBWMA7 (ORCPT + 99 others); Wed, 23 Feb 2022 07:00:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237934AbiBWMA5 (ORCPT ); Wed, 23 Feb 2022 07:00:57 -0500 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BE389A4C0 for ; Wed, 23 Feb 2022 04:00:30 -0800 (PST) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 21NC0KuI056218; Wed, 23 Feb 2022 06:00:20 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1645617620; bh=rb+JKqwrhcprw7ZNPfiTuYpfu5/yjDpPHHSpi/Rs7hc=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=no414x/Q05q1rHwNKGseCW5biMLmHgE/yG6UTxKbj6dgfXkaa4Z8RhcR9V1wB+uAe rwIg33IzMjJTDBkXFiafW0MWDSt/sicI2rZiVzhcv0o9JfyK9wF2g2UuX0yVDH+l3d 8dfYK3LQR+NsaXFwsWtCFpEw7oVvXzl54P2diINo= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 21NC0KGJ048375 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 23 Feb 2022 06:00:20 -0600 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 23 Feb 2022 06:00:20 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Wed, 23 Feb 2022 06:00:20 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 21NC0Jdj082269; Wed, 23 Feb 2022 06:00:20 -0600 Date: Wed, 23 Feb 2022 17:30:19 +0530 From: Pratyush Yadav To: Michael Walle CC: , , Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Subject: Re: [PATCH v4 31/32] mtd: spi-nor: slightly change code style in spi_nor_sr_ready() Message-ID: <20220223120019.a645et7i43kx2lde@ti.com> References: <20220221120809.1531502-1-michael@walle.cc> <20220221120809.1531502-32-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220221120809.1531502-32-michael@walle.cc> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/02/22 01:08PM, Michael Walle wrote: > Now that there is almost no special case code left in > spi_nor_sr_ready(), the return check looks odd. Move the function call > closer to the return code checking. > > Signed-off-by: Michael Walle Reviewed-by: Pratyush Yadav -- Regards, Pratyush Yadav Texas Instruments Inc.