Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 22 Feb 2022 20:06:22 +0000
From:   Jonathan McDowell <noodles@earth.li>
To:     Ansuel Smith <ansuelsmth@gmail.com>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/18] Multiple addition to ipq8064 dtsi
Message-ID: <YhVCPiBr+aEwQqkG@earth.li>
References: <20220218002956.6590-1-ansuelsmth@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220218002956.6590-1-ansuelsmth@gmail.com>
Precedence: bulk

On Fri, Feb 18, 2022 at 01:29:38AM +0100, Ansuel Smith wrote:
> This try to complete the ipq8064 dtsi and introduce 2 new dtsi
> ipq8064-v2 and ipq8065. While some node are still missing (cpufreq node,
> l2 scale node, fab scale node) this would add most of the missing node
> to make ipq8064 actually usable.
> 
> Some of the changes are the fix for the pci IO that cause any secondary
> wifi card with ath10k to fail init.
> Adds regulators definition for RPM.
> Adds many missing gsbi nodes used by all the devices.
> Enable the usb phy by default as they are actually enabled internally by
> xlate only if the dwc3 driver is used.
> Add opp table and declare idle state for ipq8064.
> Fix some dtc warning.
> 
> This also add the ipq8064-v2.0 dtsi and the ipq8065 dtsi used by more
> recent devices based on this SoC.

A couple of comments directly on 2 patches, but otherwise for the set:

Tested-by: Jonathan McDowell <noodles@earth.li>

> v2:
> - Added missing patch
> - Added additional gsbi6 spi
> - Added extra description for L2 cache opp
> - Fxied smb208 enabled by default that is problematic for rb3011 devices
> 
> Ansuel Smith (18):
>   ARM: dts: qcom: add multiple missing pin definition for ipq8064
>   ARM: dts: qcom: add gsbi6 missing definition for ipq8064
>   ARM: dts: qcom: add missing rpm regulators and cells for ipq8064
>   ARM: dts: qcom: disable smb208 regulators for ipq8064-rb3011
>   ARM: dts: qcom: add missing snps,dwmac compatible for gmac ipq8064
>   ARM: dts: qcom: enable usb phy by default for ipq8064
>   ARM: dts: qcom: reduce pci IO size to 64K for ipq8064
>   ARM: dts: qcom: fix dtc warning for missing #address-cells for ipq8064
>   ARM: dts: qcom: add smem node for ipq8064
>   ARM: dts: qcom: add saw for l2 cache and kraitcc for ipq8064
>   ARM: dts: qcom: add sic non secure node for ipq8064
>   ARM: dts: qcom: fix and add some missing gsbi node for ipq8064
>   ARM: dts: qcom: add opp table for cpu and l2 for ipq8064
>   ARM: dts: qcom: add speedbin efuse nvmem binding
>   ARM: dts: qcom: add multiple missing binding for cpu and l2 for
>     ipq8064
>   ARM: dts: qcom: remove redundant binding from ipq8064 rb3011 dts
>   ARM: dts: qcom: add ipq8064-v2.0 dtsi
>   ARM: dts: qcom: add ipq8065 dtsi
> 
>  arch/arm/boot/dts/qcom-ipq8064-rb3011.dts |  21 +-
>  arch/arm/boot/dts/qcom-ipq8064-v2.0.dtsi  |  70 ++++
>  arch/arm/boot/dts/qcom-ipq8064.dtsi       | 375 +++++++++++++++++++++-
>  arch/arm/boot/dts/qcom-ipq8065.dtsi       | 168 ++++++++++
>  4 files changed, 603 insertions(+), 31 deletions(-)
>  create mode 100644 arch/arm/boot/dts/qcom-ipq8064-v2.0.dtsi
>  create mode 100644 arch/arm/boot/dts/qcom-ipq8065.dtsi
> 
> -- 
> 2.34.1
> 

J.

-- 
"evilwm - we sold our souls to the window manager" --
http://www.6809.org.uk/evilwm/