Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1073489pxm; Wed, 23 Feb 2022 17:25:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJzrUFuvrQ4IpcQxdendA1A+/RNOK0lwLnI7R1RxwjW4DaZGa/ICRWl/jp6NrJzbFNj481Xo X-Received: by 2002:a05:6a02:18b:b0:362:c8e4:d8f4 with SMTP id bj11-20020a056a02018b00b00362c8e4d8f4mr443454pgb.86.1645665930725; Wed, 23 Feb 2022 17:25:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645665930; cv=none; d=google.com; s=arc-20160816; b=wGsTVOFLp4t6n22eVL/cDoNyxXoIiBeBYEsD9bzKg+045zhRS9y+10/eRLlrdNZMC5 pCebd79HZqe3XaXf8r9WB/GKx6ssbguq97z/aqRaZwckQbZKBSqncxwYCXE08vYQXa3C ep0R96hWaI+F6Bn9XkmNRK5SJGgmSJyV2C0frCFbMpu8S7yTNiyFrYhAkvZbSYoTrNXX FmDUdosoffVjpzMQGgwXgwHvucGJi5oVfj6J1HBnmxL9qXHTdD7FhrvvI6WPmW8RQEdQ UGyanaUSyohhZA1zjNfbvkKpA/48HNjd0UJBVBoC2xHgecg2MVH3HrOP1Y5U8R55U4Te cmnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=agRAC2t1wbxohDTZY1tvrdvahcqEsXAlVugrCvK5vAI=; b=QP5BB6X3h0y+32378fHyuJUF9aaryoJL+88mkrd1BxgvfSZays/Ffsf0GuEh5uAFUL z5heRrzj8SnsNcWsfl8CY7ulq+HKGxlVpSsXjhjVlRS0lt3XCOcs43f5lG9pXZoO0lNC fam1ENZyojkBRp7/h7f/uPf2jAj/HTeVKYQ7FHJKPlolE19I+IxN4S0wP9VohGFCHbjk xmivSCflFUVdhP5sWQQdvlW7uKPN+LNPUilEXffGhrC4KTzeLqvkzjMaR9SWDrQckhOJ BTe82wzZcOIbPS2vleimcUt4sT4GBi3ATHC3GIozhfZQeT8TOQ1n9gnWw9GY4o/obBCy Ez3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=NusxRs+h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id d20si973364pls.207.2022.02.23.17.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 17:25:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=NusxRs+h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D81D1107830; Wed, 23 Feb 2022 17:07:04 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244166AbiBWTLe (ORCPT + 99 others); Wed, 23 Feb 2022 14:11:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbiBWTLc (ORCPT ); Wed, 23 Feb 2022 14:11:32 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5225A3BA6A; Wed, 23 Feb 2022 11:11:04 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id a23so54298990eju.3; Wed, 23 Feb 2022 11:11:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=agRAC2t1wbxohDTZY1tvrdvahcqEsXAlVugrCvK5vAI=; b=NusxRs+hCFFeFBdSmlJLGYQwHnHOOgK+XcGfTP8vviCjpin68ddNpvUStPpR1vs32r TSWokMdnZp3qoW8u3QQsVe614BTTiM2S1OUs2b3Vb71shGx0snmeU4iBDCba1zG8FJoQ mHYHi1vQhWLqFo5zhPqfWl1T/NBq54QQblGM0WrwdkdJunMjW/lpzylPIOAbJvXeWQ9Q KdSi/D5Ic5z76YBqYMZr3J5azQ2Ye08A1NoR++EabeIAOaB6Qer9weo9V5hyf4XvAkx7 j2yyrc9I0QvjjgeVvVrGkBDUKdsyKjeR7S2n0m8n9Oe5XA2bpGYN0v0hLpNUKX69zWaX cvwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=agRAC2t1wbxohDTZY1tvrdvahcqEsXAlVugrCvK5vAI=; b=OCQQbsjF2C+osYjRhxCArKGJWnR6ZY1bPMagzAoSCBli7jn5EhHd8ofT9Fx/1+2l8S NRaRgXuxtHYC56oWfTuMPABXG8CwcRHi9CoIFpczCJrNUPfWQHkLjTgGwcFpLqSUHG82 Q6Yr2icJDjKaC9OPmmZpxi2yEwn7FKeUsP7n/8tZpvqC7R9iBuNqYoMw7x4An0lGqAw3 mg0pxrYO7fvb7rOCkGQoFrwPK8p22S3ghiuU70jmKxWGTsdtZFqqFuI+7ixL85kEEg2+ pJ8V9Ce4bVIYzfAgdFAts2J8rvEdMUPUMn0iogmAlnkYrNWGk2H1Yb8uhIqMMlq/hiM2 8HYw== X-Gm-Message-State: AOAM53307cDkkXBpQuKMhZMAv0uLM9mM8Ad8l4qybDz4IPmApB5ddrdt PPCwLh5zFvdph1/ycIlupAS1cpRbsyGiYQsZGCQ= X-Received: by 2002:a17:906:4cc7:b0:6d0:7efb:49f with SMTP id q7-20020a1709064cc700b006d07efb049fmr841882ejt.639.1645643462730; Wed, 23 Feb 2022 11:11:02 -0800 (PST) MIME-Version: 1.0 References: <1644890386-65119-1-git-send-email-wangqing@vivo.com> In-Reply-To: <1644890386-65119-1-git-send-email-wangqing@vivo.com> From: Andy Shevchenko Date: Wed, 23 Feb 2022 21:09:38 +0200 Message-ID: Subject: Re: [PATCH] spi: add missing pci_dev_put() before return To: Qing Wang Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Mark Brown , linux-arm Mailing List , linux-spi , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 15, 2022 at 6:04 AM Qing Wang wrote: > > From: Wang Qing > > pci_get_slot() increases its reference count, the caller must > decrement the reference count by calling pci_dev_put() Thanks for the report! This is not fully correct. I'll send a patch soon. -- With Best Regards, Andy Shevchenko