Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 23 Feb 2022 13:28:26 +0530
From:   Rahul T R <r-ravikumar@ti.com>
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
CC:     Nishanth Menon <nm@ti.com>, <catalin.marinas@arm.com>,
        <will@kernel.org>, <shawnguo@kernel.org>, <krzk@kernel.org>,
        <geert+renesas@glider.be>, <marcel.ziswiler@toradex.com>,
        <biju.das.jz@bp.renesas.com>, <vkoul@kernel.org>,
        <enric.balletbo@collabora.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <tomi.valkeinen@ideasonboard.com>,
        <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] arm64: defconfig: Enable configs for DisplayPort on J721e
Message-ID: <20220223075825.ecqbyhllikh2sscx@uda0490373>
References: <20220222180703.30401-1-r-ravikumar@ti.com>
 <20220222193930.sbc5xlsofhg3amgk@overrun>
 <YhVKSpMOKWzZy9a2@ripper>
 <20220222212642.vwtw7xiz7cck63ea@zombie>
 <YhVgjFWShgc8btJP@ripper>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YhVgjFWShgc8btJP@ripper>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 14:15-20220222, Bjorn Andersson wrote:
> On Tue 22 Feb 13:26 PST 2022, Nishanth Menon wrote:
> 
> > On 12:40-20220222, Bjorn Andersson wrote:
> > > On Tue 22 Feb 11:39 PST 2022, Nishanth Menon wrote:
> > > 
> > > > On 23:37-20220222, Rahul T R wrote:
> > > > > Enable DRM and PHY configs required for supporting
> > > > > DisplayPort on J721e
> > > > > 
> > > > > Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> > > > > ---
> > > > >  arch/arm64/configs/defconfig | 5 +++++
> > > > >  1 file changed, 5 insertions(+)
> > > > > 
> > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > > > > index 9f23d7ec1232..b0cb894a392e 100644
> > > > > --- a/arch/arm64/configs/defconfig
> > > > > +++ b/arch/arm64/configs/defconfig
> > > > > @@ -702,6 +702,9 @@ CONFIG_DRM_EXYNOS_DSI=y
> > > > >  CONFIG_DRM_EXYNOS_HDMI=y
> > > > >  CONFIG_DRM_EXYNOS_MIC=y
> > > > >  CONFIG_DRM_ROCKCHIP=m
> > > > > +CONFIG_DRM_TIDSS=m
> > > > > +CONFIG_DRM_DISPLAY_CONNECTOR=m
> > > > > +CONFIG_DRM_CDNS_MHDP8546=m
> > > > 
> > > > Please use savedefconfig to place the changes in the correct location
> > > > 
> > > 
> > > Just to clarify the request, use "make savedefconfig" to generate a
> > > defconfig, then based on that put _only_ the relevant changes in the
> > > commit.
> > 
> > Yup, thanks for clarifying.
> > > 
> > > > Also indicate changes if any in vmlinux in commit message.
> > > > 
> > > 
> > > Nishanth, what are you asking for here? Just a mentioning if this has
> > > any impact to vmlinux (or is isolated to the modules selected), or are
> > > you asking for anything specific?
> > 
> > In this case, just ensure to state that vmlinux size has'nt
> > changed, in case where we see a =y, we should indicate via
> > ./scripts/bloat-o-meter change that is introduced and if yes, we
> > should explain why this is fundamental to system boot.
> > 
> > Why is this necessary? This is to prevent product specific
> > configurations (such as early display banner, chime etc) from creeping
> > and increasing vmlinux size which has an impact for all ARM SoCs.
> > 
> 
> Sounds very reasonable, I'll make sure to ask for such motivations in
> the defconfig changes that I pick up through the Qualcomm tree as well.
> 
> Regards,
> Bjorn
>

Thanks for the review!
I will send a v2 with the fixes

Regards
Rahul T R

> > 
> > [...]
> > 
> > -- 
> > Regards,
> > Nishanth Menon
> > Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D