Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 23 Feb 2022 21:48:50 +0530
From:   Aparna M <a-m1@ti.com>
To:     Nishanth Menon <nm@ti.com>
CC:     <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <praneeth@ti.com>, <grygorii.strashko@ti.com>, <nikhil.nd@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard
 LEDs
Message-ID: <20220223161850.5kpotstxkadbefp2@ti.com>
References: <20220223083229.8044-1-a-m1@ti.com>
 <20220223135534.jbmbdvc4zye7udmc@grafting>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220223135534.jbmbdvc4zye7udmc@grafting>
Precedence: bulk

On 07:55-20220223, Nishanth Menon wrote:
> On 14:02-20220223, Aparna M wrote:
> > AM642 SK has 8 leds connected to tpic2810 onboard. Add support for these
> > gpio leds.
> > 
> > Signed-off-by: Aparna M <a-m1@ti.com>
> > ---
> >  arch/arm64/boot/dts/ti/k3-am642-sk.dts | 70 ++++++++++++++++++++++++++
> >  1 file changed, 70 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> > index 6b04745147be..31e45bafa49e 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> [...]
> 
> > +
> > +	exp2: gpio@60 {
> > +		compatible = "ti,tpic2810";
> 
> Sorry, but no.
> please convert
> 	Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt to yaml
> 
> prior to any patches that enable it. (dtbs_check should have already
> warned you about this).

A patch for changing binding to yaml has already been sent. 
Link to patchwork: https://patchwork.ozlabs.org/project/linux-gpio/patch/20220223072308.31868-1-a-m1@ti.com/

> 
> > +		reg = <0x60>;
> > +		gpio-controller;
> > +		#gpio-cells = <2>;
> > +		gpio-line-names = "LED1","LED2","LED3","LED4","LED5","LED6","LED7","LED8";
> > +	};
> >  };
> >  
> >  &main_i2c3 {
> > -- 
> > 2.17.1
> > 
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Thanks,
Aparna M