Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1086155pxm; Wed, 23 Feb 2022 17:46:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJxMiDS+EntoEfgD10PgWnsZKW4gH+QXTpKgzi7WCV6cVmZwxNjipmG3XBThC70Z8OeKRQze X-Received: by 2002:a17:902:8210:b0:14d:6607:bdc4 with SMTP id x16-20020a170902821000b0014d6607bdc4mr274620pln.165.1645667175882; Wed, 23 Feb 2022 17:46:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645667175; cv=none; d=google.com; s=arc-20160816; b=tfxJKY2hugfoSMsNDnZFWcKezdJtAG6qj6vlsMWdyiJA4gfTe4Z4wm+zZSXcXhDlR3 tAqpvC446zlghs4PB2UYyjOfGas2Unqk0YkPEc1wcuE14rDPs4dZ47BGBLSLXI1XbRpB MrYUcKGMrhRAUxZsNOzH2XA25GBGZVc0Phj4cATVRln9cNRi/XtzM7ODEbDDRSyJ6qMl dk54O0Guxf7D1C8eVGHGIRyFfBCXXwGT3q2I4q7QfyKu6zoUdKyVzsZqYdkpplfzTd8Y 1AG3hRySXfbPJiUUaTn9BxJf5w4juPggRY1LAvVD2coCsrOF2F1deDgMhUjZKXVh+SD2 QZuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=OE2Z95ncOYaSFDOn4LvvHzZe2EAjcR2yJXOjWyUnz5I=; b=uySpEfnAHI9tC+kXaJS0ygyMH+X6RBu38lDwzFjbeTK2W4qZdDj8X9dswV3ZBRljmI USTaqLI5l6B7CczbwYShCewD7uhb+rjL2thHQa7BP5YDHbJRWqfj2Q7OBgJbI33X3CWw wY+yO2/GlSqGmZCuwXXn6Y5bovADtW4/zoaKEC++vseSfOJY7P7gu7BNiqsN9INXIAIT vaJ3TuiWfPKbcdc8eE29apNvinyhZEaycVmQ1HAxHfasnegKKJi3uZwAwONOEhaYCqOB 9rV95zdWq7mpoHJV4WpLgdxzwfuxlzj345OjwdpcHzEEMISIjZJLYF7HXGuccq5F/7Xn IZ9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=htHMZ4ej; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id d2si1174735pgf.730.2022.02.23.17.46.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 17:46:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=htHMZ4ej; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6833F19DEAD; Wed, 23 Feb 2022 17:21:03 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240705AbiBWUFZ (ORCPT + 99 others); Wed, 23 Feb 2022 15:05:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233174AbiBWUFY (ORCPT ); Wed, 23 Feb 2022 15:05:24 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5E2C40E63; Wed, 23 Feb 2022 12:04:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 448A1B821A3; Wed, 23 Feb 2022 20:04:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3349C340E7; Wed, 23 Feb 2022 20:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645646693; bh=M0+mVIZ0Lc26AANZRRAz4t6SzyvF92PylFUdbqphFSM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=htHMZ4ejkmVw5UZH147OWWvzPaFhKffm1si8PWKoQ3tnFx1yOLEVU9zQwxK66D03d wplmLYlyIr1r52XdFqTtlesPjts/kWIf+iN1ATyktMdKEcaUJvlYonZ1V6H/8HPLI/ jMTrjWGhifOrhupEC9mn93Sk6u/MBMyXLCtr0HLQ/nz2PeL0MlAZGOz+uRBQ2dNQP+ 1Ic12cGDQBffBc1oiHIM2JMAZUrS567iuIBAS786fIZ1Fhesjvllp4NBTINXzKcMxj GOt37pF22BkcR2HDO2jvs15Y7ID8CBJEsV/Q3gpu+i821dkJIfTeyhhFcFWSUe12Qd deVfLFRokXTYQ== Date: Wed, 23 Feb 2022 20:04:42 +0000 From: Mark Brown To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Stuart Yoder , Laurentiu Tudor , Abel Vesa , Shawn Guo , Sascha Hauer , Fabio Estevam , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , Srinivas Kandagatla , "Michael S. Tsirkin" , Jason Wang , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds , Rasmus Villemoes Subject: Re: [PATCH v2 07/11] spi: use helper for safer setting of driver_override Message-ID: References: <20220223191310.347669-1-krzysztof.kozlowski@canonical.com> <20220223191441.348109-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PaAAhqOBo3hBuacY" Content-Disposition: inline In-Reply-To: <20220223191441.348109-1-krzysztof.kozlowski@canonical.com> X-Cookie: I smell a wumpus. X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PaAAhqOBo3hBuacY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 23, 2022 at 08:14:37PM +0100, Krzysztof Kozlowski wrote: > Remove also "const" from the definition of spi_device.driver_override, > because it is not correct. The SPI driver already treats it as > dynamic, not const, memory. We don't modify the string do we, we just allocate a new one? --PaAAhqOBo3hBuacY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIWk1kACgkQJNaLcl1U h9DKugf+JTJnnQWx+6mOA4DxLKfWqeASwwB38nUbBFMpWAEhjMvez2XAp0h33Cp9 bH+dZ5NjHjeUoLGkWBHxWiyuu1r4QrqL7E32x/mV1JsG7I2svj0l0XyCx7Xw7lqT QIFJxxSknnL1YtmnB53Rz55GDGQhIg4ewuv/ayCjk0oBDS6G2WBS2UAx2FWJQg2l 0ALu1QKfCU2DfjLPbmMqLoJb9anvSLyPxe38+Q2dqLx6kUl1WqVWz/Af6dJp9YWY UDYfURm/JqyzEo/wiM5ZS39VO9Kv8M7EO9MFJvwxdkmM1evQah6crAugVx/WeCQy 4Tv/1RJYx8DyQ53XSPVEVcgh9tSx9w== =g4g9 -----END PGP SIGNATURE----- --PaAAhqOBo3hBuacY--