X-Received: by 2002:a05:6870:d29e:b0:d6:cf5e:d70a with SMTP id d30-20020a056870d29e00b000d6cf5ed70amr371198oae.289.1645668090727; Wed, 23 Feb 2022 18:01:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645668090; cv=none; d=google.com; s=arc-20160816; b=Zl26FudQy9oka11dc/5YVJZAgmYz6pLiQHdPViPKWB/4DMi1oFu4HhAOfIYM9WbquB K6JjDnezWDE8n3iONLK84YHb0U1zloYJF5ChVZx0kge8v3cOL5YnCb3/vSzxOTZfLev5 1rbNcw4EtXbOnFcnyf3t4L/NgvEuAwy2f5TXU67ybHD74Su7RwKT7/61ShWsQx5N3Kh5 vgtc3KqXWEitVL24zmouFQFXaCbgGpAyvjz04U0KPULVeQLi325QtcP034VKYAaeFiY5 Raa1PFW3Tl/t0Ljxp7mlgBhPQPECEX8Ka+/covTG2uenzOBdKt22p9NMqbCa3uZkbtX1 JYUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=oCxREwFM0y2vQTykTwYzrkwrMy1CU8qdmg0T6iynpi0=; b=pREcwGQNp6Baka5dBDr6AZtjN1Ndfr+mwKcvoLg/t5xQBiBXZLZtq/UdoB2OtA0+7O HzMVybpkMUIwUCD6WD2Cyye5E0gzR7IIL68yr8pqafV9uFXvfZVq41JgnRymXA7bQWKb UiUuv7aBwjoIwsAJyCNRCOoEWdZOf4WuJwoc7NlevMRNXT5e48EvesOr1C8be1r1W2hB dVyM1YgI4aQE6FkzsXIxoRVeOEWWdDOt8NeXqZx9lE2ugZ4EFp6l39EmA6OaIGciBLiF FMTs5SFNbM/YlV7OcL/s2/kReDo8To6otXZJC6qj3IR+DugdCzX/fNn+4QkwbITy8Mg4 MWSA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id f9si711285otq.9.2022.02.23.18.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 18:01:30 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 060A021DF19; Wed, 23 Feb 2022 17:29:52 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229453AbiBXBaR (ORCPT + 99 others); Wed, 23 Feb 2022 20:30:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbiBXBaQ (ORCPT ); Wed, 23 Feb 2022 20:30:16 -0500 Received: from out199-12.us.a.mail.aliyun.com (out199-12.us.a.mail.aliyun.com [47.90.199.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7E86151C5A for ; Wed, 23 Feb 2022 17:29:38 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0V5LP5GJ_1645665047; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0V5LP5GJ_1645665047) by smtp.aliyun-inc.com(127.0.0.1); Thu, 24 Feb 2022 09:10:48 +0800 From: Yang Li To: matthias.bgg@gmail.com Cc: tiwai@suse.com, perex@perex.cz, broonie@kernel.org, lgirdwood@gmail.com, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] ASoC: mediatek: mt8195: Remove unnecessary print function dev_err() Date: Thu, 24 Feb 2022 09:10:46 +0800 Message-Id: <20220224011046.76904-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./sound/soc/mediatek/mt8195/mt8195-afe-pcm.c:3126:2-9: line 3126 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot Signed-off-by: Yang Li --- sound/soc/mediatek/mt8195/mt8195-afe-pcm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c index b77c2ba5a629..550636500949 100644 --- a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c +++ b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c @@ -3122,10 +3122,8 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev) /* request irq */ irq_id = platform_get_irq(pdev, 0); - if (irq_id < 0) { - dev_err(dev, "%s no irq found\n", dev->of_node->name); + if (irq_id < 0) return -ENXIO; - } ret = devm_request_irq(dev, irq_id, mt8195_afe_irq_handler, IRQF_TRIGGER_NONE, "asys-isr", (void *)afe); -- 2.20.1.7.g153144c