Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946061AbXBPTHH (ORCPT ); Fri, 16 Feb 2007 14:07:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946221AbXBPTHG (ORCPT ); Fri, 16 Feb 2007 14:07:06 -0500 Received: from 207.47.60.150.static.nextweb.net ([207.47.60.150]:44727 "EHLO webmail.xensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946061AbXBPTHD (ORCPT ); Fri, 16 Feb 2007 14:07:03 -0500 User-Agent: Microsoft-Entourage/11.2.5.060620 Date: Fri, 16 Feb 2007 19:06:58 +0000 Subject: Re: [Xen-devel] Re: [patch 12/21] Xen-paravirt: Allocate and free vmalloc areas From: Keir Fraser To: Jeremy Fitzhardinge , Keir Fraser CC: Zachary Amsden , , Ian Pratt , , , Jan Beulich , Chris Wright , Andi Kleen , Andrew Morton , Christian Limpach Message-ID: Thread-Topic: [Xen-devel] Re: [patch 12/21] Xen-paravirt: Allocate and free vmalloc areas Thread-Index: AcdR/aFp4CN9q73wEduRUwAX8io7RQ== In-Reply-To: <45D5E98B.4070904@goop.org> Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1069 Lines: 26 On 16/2/07 17:27, "Jeremy Fitzhardinge" wrote: > In fact that file is only built for i386 and x86_64, so there really is no >> problem with using vmalloc_sync_all() directly and without ifdef. >> > > I had moved it to mm/vmalloc.c in response to previous review comments > (namely, its not Xen specific, so it shouldn't live in the Xen part of > the tree). Then the call will have to be CONFIG_X86. I hadn't realised powerpc were also using lock_vm_area. However I suspect that the x86 issue that those functions were written doesn't even exist on powerpc, or any other non-x86 architecture. I guess we should change the name of alloc_vm_area, by the way. Perhaps alloc_vm_area_sync() or similar, to give some hint of what it's doing and how it differs from other vmalloc-area functions? -- Keir - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/