Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Parav Pandit <parav@nvidia.com>
To:     Jakub Kicinski <kuba@kernel.org>, Moshe Shemesh <moshe@nvidia.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Jiri Pirko <jiri@nvidia.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v2 0/4] net/mlx5: Introduce devlink param to
 disable SF aux dev probe
Thread-Topic: [PATCH net-next v2 0/4] net/mlx5: Introduce devlink param to
 disable SF aux dev probe
Thread-Index: AQHYHyi7LP1bSM9810iOk5A08UDRx6yPHP2AgAPzdgCADw+mAA==
Date:   Thu, 24 Feb 2022 03:44:20 +0000
Message-ID: <PH0PR12MB5481DCB01F443BFC559430C4DC3D9@PH0PR12MB5481.namprd12.prod.outlook.com>
References: <1644571221-237302-1-git-send-email-moshe@nvidia.com>
 <20220211171251.29c7c241@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <PH0PR12MB548137BB5A70195983DFF74EDC339@PH0PR12MB5481.namprd12.prod.outlook.com>
In-Reply-To: <PH0PR12MB548137BB5A70195983DFF74EDC339@PH0PR12MB5481.namprd12.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QBPMsk1ZgeRfOvVnXUeNgWR2sQdrrM25arlNrs62UxdemVMzZatVv6bO2vmH?=
 =?us-ascii?Q?n1QFP4v8OT4AoVjHtjzqPRDe0chQuwhuocqgqrLUNrZs1DgRh0aB57Vo5aHk?=
 =?us-ascii?Q?1yX8Ny11Wur8xJy4X4S6LQ/+ZiDqkYFCz2VxxT3OtbZGD2vimNhFZc9/urpu?=
 =?us-ascii?Q?c89DrL6BBGbE0vi8egwsjxsiO+K4t2+VUeiB75rnOlG0lAab/LUFEMPlPpzH?=
 =?us-ascii?Q?m+e9pi3Vd3M3k4vvusnluwMnIMtksY37xaWwPtDOn8QRLZGZxwcQvnUiGmCP?=
 =?us-ascii?Q?uBMxStIRUFrW4UgPyCezFaFXO/5IrNHkqsNqr/wwLB6qlKrhXBD1VAn20Gm9?=
 =?us-ascii?Q?Cpwgn1SlSpqbkhXNkb9n0hCvetHztQBKp5b+Qp3hWSYUBmR5WJAfZ1WkaMcx?=
 =?us-ascii?Q?EeFf9RN1t0qYr/eeJxZ0g4J+rz4jTrrSoJrN6rXHTo37RSagBGWHiIOOICCR?=
 =?us-ascii?Q?uivLeDzF6HsKV/ZCCqcLTOmKZ8272XllY8Eh8B60DgNetTZO5Vikrn05wh5J?=
 =?us-ascii?Q?aAlhKTJMuSQyD2FEEOKs9iNxvgDaXFW2RcZ9q8fTuOioqVxEl91RgQwOuq2K?=
 =?us-ascii?Q?VCCCWh+MMmLpkJVcHnmFwLb9gdXerrlC3G0eAZX4WprFvBI8NNm6YfVkXSeP?=
 =?us-ascii?Q?/ZP1SSZ/sGEpzEE1+4cIXOh8Q4mz7T/lSVhkUZJ58lGi4ZYqcJoAlvdieHXS?=
 =?us-ascii?Q?x2ThcvDcieoTV6DF/diniYy6BpCcPgVBdhEVX2nJObyShklpgWjQr/Ojt1Jf?=
 =?us-ascii?Q?WPv6XUWOd2i2cIHD5uUkEHo+7NBN17PjRIXSBEujnSp7vlui26zfEBFprha8?=
 =?us-ascii?Q?0u+k14G4FZTHHGSWPaTfcnarFzK1Nj3supcjVFK2LK2wm40sPrzdYkpnYnH0?=
 =?us-ascii?Q?PH1v5LC6f+4/I4E5sMwgqLLgdqYb5cTAasx2lxl8WjfWUsrwQ5DEtTH52u7y?=
 =?us-ascii?Q?GYU8IzZ0eRNZvx6IyoR8D2DpveQ1xfc59L/SynQfi6nyt8SFIlWAIqxQh+7j?=
 =?us-ascii?Q?f5mc+4BdOMhK07+spTADuTHqegQA2WgPPjtfNB3eOU3CRXednIY/tNi1Qqxg?=
 =?us-ascii?Q?xo3/84hQCLMa08OYf3GbQiGJkwWC17v7co8eNkVcZILzFt3VpxEEcTCkVVKb?=
 =?us-ascii?Q?5HnUulrqsA1zCaRyQDxefVgl+Uz+gW3isTR11Qv5R2Qv5fg/vMOeYr3yrrGv?=
 =?us-ascii?Q?qgwNEucb6lmoIc4C59ZtwxfoDnxcqm31z0mPLx0OV2SYl5Ktr/pUpxuKfOG7?=
 =?us-ascii?Q?kyhdenV0+iipdhu4Gl0nXkkmhgz9hv9e9dim9Zt5xCIJMUoeqOs2G77tYZ55?=
 =?us-ascii?Q?gvo8CJ8lEef63d8jza03HDIxNqc5KZVyzw3tUk6j/QaAw64SOLXUjol5x+wj?=
 =?us-ascii?Q?svT+jNXsq1TXLUC4EVIvje4OFI8N6crFh7RLZ25MmX/G9u75Cjq8kH54yyZV?=
 =?us-ascii?Q?TAqYFXMjHIcFmeKnwj75PoZtz9FGcewvLOmFN89ZUGFu7+A+YOVnhCo3ZdZv?=
 =?us-ascii?Q?OmrQ+wqnAr2Cc53SohvBbLA+UCyUxhoWQzLbv6j89i9Uedd25sTRvnm+ha8g?=
 =?us-ascii?Q?G+GXFe1o/hSskFwo564PAnn4+sw5SRoxauumMTD52leZ7nrU3hXFnnlatdzj?=
 =?us-ascii?Q?hK0O+/X+s4b0yjciOqZycqs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB5481.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e206e14-3489-49b1-fba5-08d9f747f0df
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 03:44:20.4491
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bn5LUjFS9sKIEFlULinW7Cr6Bny5YBF0zzko1RD+u/vZPwe5kd40t704SE9YxnzhyuiAwuvRUemiBNXCHQ7ZoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0228
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jakub,

> From: Parav Pandit
> Sent: Monday, February 14, 2022 8:16 PM
>=20
> > From: Jakub Kicinski <kuba@kernel.org>
> > Sent: Saturday, February 12, 2022 6:43 AM
> >
> > On Fri, 11 Feb 2022 11:20:17 +0200 Moshe Shemesh wrote:
> > > v1->v2:
> > >  - updated example to make clear SF port and SF device creation PFs
> > >  - added example when SF port and device creation PFs are on
> > > different hosts
> >
> > How does this address my comments?
> >
> Which one?
> Your suggestion in [1] to specify vnet during port function spawning time=
?
> Or
> Your suggestion in [2] to add "noprobe" option?

> Saeed is offline this week, and I want to gather his feedback as well on =
passing
> hints from port spawning side to host side.

Saeed is back. Saeed, others and I discussed the per SF knob further.
The option to indicate to not initialize the SF device during port spawning=
 time is very useful to users.

So, how about crafting below UAPI?
Example:

Esw side:
$ devlink port add <dev> flavour pcisf ..=20
$ devlink port function set <port> hw_addr 00:11:22:33:44:55 initialize fal=
se/true ...

The "initialize" option indicates whether a function should fully initializ=
e or not at driver level on the host side.
When initialize=3Dfalse, the device will spawn but not initialize until a u=
ser on the host initialize it using the existing devlink reload API on this=
 SF device.

For example, on host side, a user will be able to do,
$ devlink dev auxiliary/mlx5_core.sf2 resource/param set
$ devlink dev reload auxiliary/mlx5_core.sf.2