Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <41ef1e0e-c4a4-4828-a573-a92cd9425615@linux.intel.com>
Date:   Thu, 24 Feb 2022 13:27:55 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 2/2] perf vendor events intel: Add uncore event list for
 Alderlake
Content-Language: en-US
To:     Ian Rogers <irogers@google.com>
Cc:     acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
        alexander.shishkin@intel.com, jolsa@redhat.com,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        adrian.hunter@intel.com, ak@linux.intel.com,
        kan.liang@linux.intel.com
References: <20220223110135.1943210-1-zhengjun.xing@linux.intel.com>
 <CAP-5=fXWZ1vJqfU4TXedGVYNpj-RjVsQsrtggnGMZQR9C0-Yew@mail.gmail.com>
From:   Xing Zhengjun <zhengjun.xing@linux.intel.com>
In-Reply-To: <CAP-5=fXWZ1vJqfU4TXedGVYNpj-RjVsQsrtggnGMZQR9C0-Yew@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2/24/2022 12:48 AM, Ian Rogers wrote:
> On Tue, Feb 22, 2022 at 7:02 PM <zhengjun.xing@linux.intel.com> wrote:
>>
>> From: Zhengjun Xing <zhengjun.xing@linux.intel.com>
>>
>> Add JSON uncore events for Alderlake to perf.
>>
>> Based on JSON list v1.06:
>>
>> https://download.01.org/perfmon/ADL/
> 
> Acked-by: Ian Rogers <irogers@google.com>
> 
> Could you post the uncore csv file on:
> https://github.com/intel/event-converter-for-linux-perf
> For example, the skylakex one is:
> https://github.com/intel/event-converter-for-linux-perf/blob/master/perf-uncore-events-skx.csv

Thanks. The ADL uncore csv file has been posted in the convert tool.

> 
> Thanks,
> Ian
> 
>> Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
>> ---
>>   .../arch/x86/alderlake/uncore-memory.json     | 222 ++++++++++++++++++
>>   .../arch/x86/alderlake/uncore-other.json      |  40 ++++
>>   2 files changed, 262 insertions(+)
>>   create mode 100644 tools/perf/pmu-events/arch/x86/alderlake/uncore-memory.json
>>   create mode 100644 tools/perf/pmu-events/arch/x86/alderlake/uncore-other.json
>>
>> diff --git a/tools/perf/pmu-events/arch/x86/alderlake/uncore-memory.json b/tools/perf/pmu-events/arch/x86/alderlake/uncore-memory.json
>> new file mode 100644
>> index 000000000000..d82d6f62a6fb
>> --- /dev/null
>> +++ b/tools/perf/pmu-events/arch/x86/alderlake/uncore-memory.json
>> @@ -0,0 +1,222 @@
>> +[
>> +    {
>> +        "BriefDescription": "Number of clocks",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x01",
>> +        "EventName": "UNC_M_CLOCKTICKS",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "Incoming VC0 read request",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x02",
>> +        "EventName": "UNC_M_VC0_REQUESTS_RD",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "Incoming VC0 write request",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x03",
>> +        "EventName": "UNC_M_VC0_REQUESTS_WR",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "Incoming VC1 read request",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x04",
>> +        "EventName": "UNC_M_VC1_REQUESTS_RD",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "Incoming VC1 write request",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x05",
>> +        "EventName": "UNC_M_VC1_REQUESTS_WR",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "Incoming read prefetch request from IA",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x0A",
>> +        "EventName": "UNC_M_PREFETCH_RD",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "Any Rank at Hot state",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x19",
>> +        "EventName": "UNC_M_DRAM_THERMAL_HOT",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "Any Rank at Warm state",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x1A",
>> +        "EventName": "UNC_M_DRAM_THERMAL_WARM",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "incoming read request page status is Page Hit",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x1C",
>> +        "EventName": "UNC_M_DRAM_PAGE_HIT_RD",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "incoming read request page status is Page Empty",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x1D",
>> +        "EventName": "UNC_M_DRAM_PAGE_EMPTY_RD",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "incoming read request page status is Page Miss",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x1E",
>> +        "EventName": "UNC_M_DRAM_PAGE_MISS_RD",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "incoming write request page status is Page Hit",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x1F",
>> +        "EventName": "UNC_M_DRAM_PAGE_HIT_WR",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "incoming write request page status is Page Empty",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x20",
>> +        "EventName": "UNC_M_DRAM_PAGE_EMPTY_WR",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "incoming write request page status is Page Miss",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x21",
>> +        "EventName": "UNC_M_DRAM_PAGE_MISS_WR",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "Read CAS command sent to DRAM",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x22",
>> +        "EventName": "UNC_M_CAS_COUNT_RD",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "Write CAS command sent to DRAM",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x23",
>> +        "EventName": "UNC_M_CAS_COUNT_WR",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "ACT command for a read request sent to DRAM",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x24",
>> +        "EventName": "UNC_M_ACT_COUNT_RD",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "ACT command for a write request sent to DRAM",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x25",
>> +        "EventName": "UNC_M_ACT_COUNT_WR",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "ACT command sent to DRAM",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x26",
>> +        "EventName": "UNC_M_ACT_COUNT_TOTAL",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "PRE command sent to DRAM for a read/write request",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x27",
>> +        "EventName": "UNC_M_PRE_COUNT_PAGE_MISS",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "PRE command sent to DRAM due to page table idle timer expiration",
>> +        "Counter": "0,1,2,3,4",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x28",
>> +        "EventName": "UNC_M_PRE_COUNT_IDLE",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "Counts every 64B read  request entering the Memory Controller 0 to DRAM (sum of all channels)",
>> +        "CounterType": "FREERUN",
>> +        "EventName": "UNC_MC0_RDCAS_COUNT_FREERUN",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "Counts every 64B read request entering the Memory Controller 1 to DRAM (sum of all channels)",
>> +        "Counter": "3",
>> +        "CounterType": "FREERUN",
>> +        "EventName": "UNC_MC1_RDCAS_COUNT_FREERUN",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "Counts every 64B write request entering the Memory Controller 0 to DRAM (sum of all channels). Each write request counts as a new request incrementing this counter. However, same cache line write requests (both full and partial) are combined to a single 64 byte data transfer to DRAM",
>> +        "Counter": "1",
>> +        "CounterType": "FREERUN",
>> +        "EventName": "UNC_MC0_WRCAS_COUNT_FREERUN",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    },
>> +    {
>> +        "BriefDescription": "Counts every 64B write request entering the Memory Controller 1 to DRAM (sum of all channels). Each write request counts as a new request incrementing this counter. However, same cache line write requests (both full and partial) are combined to a single 64 byte data transfer to DRAM",
>> +        "Counter": "4",
>> +        "CounterType": "FREERUN",
>> +        "EventName": "UNC_MC1_WRCAS_COUNT_FREERUN",
>> +        "PerPkg": "1",
>> +        "Unit": "iMC"
>> +    }
>> +]
>> diff --git a/tools/perf/pmu-events/arch/x86/alderlake/uncore-other.json b/tools/perf/pmu-events/arch/x86/alderlake/uncore-other.json
>> new file mode 100644
>> index 000000000000..50de82c29944
>> --- /dev/null
>> +++ b/tools/perf/pmu-events/arch/x86/alderlake/uncore-other.json
>> @@ -0,0 +1,40 @@
>> +[
>> +    {
>> +        "BriefDescription": "This 48-bit fixed counter counts the UCLK cycles",
>> +        "Counter": "Fixed",
>> +        "CounterType": "PGMABLE",
>> +       "EventCode": "0xff",
>> +        "EventName": "UNC_CLOCK.SOCKET",
>> +        "PerPkg": "1",
>> +        "Unit": "CLOCK"
>> +    },
>> +    {
>> +        "BriefDescription": "Counts the number of coherent and in-coherent requests initiated by IA cores, processor graphic units, or LLC",
>> +        "Counter": "0,1",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x81",
>> +        "EventName": "UNC_ARB_TRK_REQUESTS.ALL",
>> +        "PerPkg": "1",
>> +        "UMask": "0x01",
>> +        "Unit": "ARB"
>> +    },
>> +    {
>> +        "BriefDescription": "Number of requests allocated in Coherency Tracker",
>> +        "Counter": "0,1",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x84",
>> +        "EventName": "UNC_ARB_COH_TRK_REQUESTS.ALL",
>> +        "PerPkg": "1",
>> +        "UMask": "0x01",
>> +        "Unit": "ARB"
>> +    },
>> +    {
>> +        "BriefDescription": "Each cycle counts number of all outgoing valid entries in ReqTrk. Such entry is defined as valid from its allocation in ReqTrk till deallocation. Accounts for Coherent and non-coherent traffic",
>> +        "CounterType": "PGMABLE",
>> +        "EventCode": "0x80",
>> +        "EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
>> +        "PerPkg": "1",
>> +        "UMask": "0x01",
>> +        "Unit": "ARB"
>> +    }
>> +]
>> --
>> 2.25.1
>>

-- 
Zhengjun Xing