Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: n+G/rgXHcn5TF1JmY71w/ioXs9jYba99f7128WwX9lgyDY+Wss8U4efIBBmKTEa6+7zi1FZCAy
 N79s1tXOn9nB3Iu0Y16MptDm3dVzTDmeB8qMTeaZoVgTHqqNzGkXMdPm10g/hSxw2P2J8NZPBP
 X94dWtgx9zrtnYebtPGHpyQeWMvyGnYMDf6rK5RnpcnJIWgVUjzE74kIV4flspkgFLdxmNkpQp
 z+enxid/2OQg1fj2ZDgrmhfakErViSowHAc8ziHI7SYXg04B1FAaWmkbIcPx/3nJ67Oyc+TmsD
 PQR4VCTdLXBG60B4SVx0Bc8v
IronPort-SDR: ulOdA/+kKy1PMS6EtaGPU6rz6LoNdf5FgFsncPm8gR8EHlHQM17UdQgyaFB3kL1KmjgDc/OrE1
 RPB/B4voJkHz6mPsNqF3HcKMx1QrFazc0Hm3RjjMR6Dc9u75t4PgRkJDyLkd6zqN8k8f/ByB0C
 duda8oMROevG0Tc0jdpa0qpMJdksNqwBua+TfsMQXFtlc5f88sX1NL+Hzk9/8Wjk/WcQfIVIHj
 fz9o7QnN1FwY4RZww2sjXm989HaVESZX+LloecAZg1FnMG/dWeAibjR+NDp+AhaT//AVxva5E+
 tSU=
WDCIronportException: Internal
Message-ID: <b62a0767-db0b-ad4f-2fdf-9b4e32e59af2@opensource.wdc.com>
Date:   Thu, 24 Feb 2022 14:51:22 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH -next] scsi: megasas: clean up some inconsistent indenting
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>, kashyap.desai@broadcom.com
Cc:     sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
References: <20220224004748.59442-1-yang.lee@linux.alibaba.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220224004748.59442-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/24/22 09:47, Yang Li wrote:
> Eliminate the follow smatch warning:
> drivers/scsi/megaraid/megaraid_sas_fusion.c:5104 megasas_reset_fusion()
> warn: inconsistent indenting
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index c72364864bf4..aab600ef4cd6 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -5101,8 +5101,8 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int reason)
>  				for (j = 0; j < MAX_LOGICAL_DRIVES_EXT; ++j) {
>  					memset(fusion->stream_detect_by_ld[j],
>  					0, sizeof(struct LD_STREAM_DETECT));

While at it, you could fix this weird indentation too.

> -				 fusion->stream_detect_by_ld[j]->mru_bit_map
> -						= MR_STREAM_BITMAP;
> +				fusion->stream_detect_by_ld[j]->mru_bit_map
> +					= MR_STREAM_BITMAP;

Still inconsistent: missing one tab, no ?

>  				}
>  			}

Given the depth of the indentation, this initialization loop could go
into a little inline helper function.

-- 
Damien Le Moal
Western Digital Research